On Mon, Mar 03, 2025 at 01:27:10PM +0200, Jani Nikula wrote:
> Drop the dependency on gt by providing a callback for trying to unbreak
> stuck modeset. Do intel_gt_set_wedged() via the callback.
>
> It's by no means pretty, but this is perhaps the most straightforward
> alternative.
>
> Cc: Matt
On Mon, Mar 03, 2025 at 01:27:09PM +0200, Jani Nikula wrote:
> Deduplicate the gpu_reset_clobbers_display() part by passing the
> information in from gt side.
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_display_reset.c | 12 ++--
> drivers/
On Mon, Mar 03, 2025 at 01:27:07PM +0200, Jani Nikula wrote:
> Since commit d59cf7bb73f3 ("drm/i915/display: Use dma_fence interfaces
> instead of i915_sw_fence") we don't have anyone waiting on the
> I915_RESET_MODESET bit, and there's no need for its semantics. Instead,
> simply return true from
On Mon, Mar 03, 2025 at 01:27:08PM +0200, Jani Nikula wrote:
> Move the checks for whether display reset is needed at all to gt side of
> things. This way, we can decide to skip the display calls altogether if
> display reset is not required.
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
Revi
== Series Details ==
Series: drm/i915/dmc: Add debugfs for dc6 counter (rev3)
URL : https://patchwork.freedesktop.org/series/144240/
State : warning
== Summary ==
Error: dim checkpatch failed
6b5ed04d5237 drm/i915/dmc: Create debugfs entry for dc6 counter
-:76: CHECK:BRACES: braces {} should b
== Series Details ==
Series: drm/i915/dmc: Add debugfs for dc6 counter (rev3)
URL : https://patchwork.freedesktop.org/series/144240/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16217 -> Patchwork_144240v3
Summary
---
== Series Details ==
Series: drm/i915/dmc: Add debugfs for dc6 counter (rev3)
URL : https://patchwork.freedesktop.org/series/144240/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Starting from MTL we don't have a platform agnostic way to validate
DC6 state due to dc6 counter has been removed to validate DC state.
The goal is to validate that the display HW can reach the DC6 power
state. There is no HW DC6 residency counter (and there wasn't such
a counter earlier either),
== Series Details ==
Series: drm/i915/xe3lpd: Map POWER_DOMAIN_AUDIO_PLAYBACK to DC_off (rev2)
URL : https://patchwork.freedesktop.org/series/145593/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16215 -> Patchwork_145593v2
On Mon, Mar 03, 2025 at 11:55:30AM +0200, Murthy, Arun R wrote:
> [...]
> > > +{
> > > + struct intel_encoder *encoder = connector->encoder;
> > > + struct intel_display *display = to_intel_display(encoder);
> > > + const struct drm_display_mode *adjusted_mode =
> > > +
== Series Details ==
Series: series starting with [1/2] drm/i915/dp: Reject HBR3 when sink doesn't
support TPS4
URL : https://patchwork.freedesktop.org/series/145716/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16213 -> Patchwork_145716v1
===
== Series Details ==
Series: series starting with [1/2] drm/i915/dp: Reject HBR3 when sink doesn't
support TPS4
URL : https://patchwork.freedesktop.org/series/145716/
State : warning
== Summary ==
Error: dim checkpatch failed
152f8e822450 drm/i915/dp: Reject HBR3 when sink doesn't support TPS
On Mon, 03 Mar 2025, Masahiro Yamada wrote:
> On Mon, Mar 3, 2025 at 7:02 PM Jani Nikula wrote:
>>
>> On Mon, 03 Mar 2025, Masahiro Yamada wrote:
>> And one of the underlying goals is to make for minimal headers with
>> minimal includes and minimal dependencies, preferring forward
>> declaration
e' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Ville-Syrjala/drm-client-Build-the-tests-with-CONFIG_DRM_KUNIT_TEST-m/20250303-175715
base: https://git.kernel.org/pub/scm/linux/kernel/git/d
From: Ville Syrjälä
According to the DP spec TPS4 is mandatory for HBR3. We have
however seen some broken eDP sinks that violate this and
declare support for HBR3 without TPS4 support.
At least in the case of the icl Dell XPS 13 7390 this results
in an unstable output.
Reject HBR3 when TPS4 sup
LOBF can be enabled with vrr fixed rate mode, so add check
if vmin = vmax = flipline in compute_config().
Signed-off-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_alpm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
b/drivers/gpu/dr
On Mon, 3 Mar 2025 13:23:42 +0530
"Murthy, Arun R" wrote:
> On 20-02-2025 21:20, Pekka Paalanen wrote:
> > On Wed, 19 Feb 2025 09:28:51 +0530
> > "Murthy, Arun R" wrote:
> >
> >> On 18-02-2025 21:48, Pekka Paalanen wrote:
> >>> On Tue, 18 Feb 2025 11:13:39 +0530
> >>> "Murthy, Arun R" wrote:
On Mon, Mar 3, 2025 at 7:02 PM Jani Nikula wrote:
>
> On Mon, 03 Mar 2025, Masahiro Yamada wrote:
> > +CC: Linus
> >
> > On Wed, Jan 22, 2025 at 11:41 PM Jani Nikula wrote:
> >>
> >> Ensure drm headers build, are self-contained, have header guards, and
> >> have no kernel-doc warnings, when CONF
On Fri, Feb 28, 2025 at 03:31:39PM +, Kandpal, Suraj wrote:
>
>
> > -Original Message-
> > From: Ville Syrjälä
> > Sent: Friday, February 28, 2025 7:57 PM
> > To: Kandpal, Suraj
> > Cc: Jani Nikula ;
> > intel...@lists.freedesktop.org;
> > intel-gfx@lists.freedesktop.org; Syrjala,
From: Ville Syrjälä
Bspec asks us to clear the CURSOR_PROGRAM and COEFF_POLARITY
bits in PORT_TX_DW5 on icl+ combo PHYs. Make it so.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_combo_phy_regs.h | 2 ++
drivers/gpu/drm/i915/display/intel_ddi.c| 3 ++-
2 files
== Series Details ==
Series: drm/i915: display reset cleanups (rev3)
URL : https://patchwork.freedesktop.org/series/143233/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16211 -> Patchwork_143233v3
Summary
---
**FAIL
On Mon, Mar 03, 2025 at 11:52:32AM -, Patchwork wrote:
> == Series Details ==
>
> Series: drm/client: Build the tests with CONFIG_DRM_KUNIT_TEST=m
> URL : https://patchwork.freedesktop.org/series/145707/
> State : failure
>
> == Summary ==
>
> Error: make failed
> CALLscripts/checksy
== Series Details ==
Series: drm/i915: display reset cleanups (rev3)
URL : https://patchwork.freedesktop.org/series/143233/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/client: Build the tests with CONFIG_DRM_KUNIT_TEST=m
URL : https://patchwork.freedesktop.org/series/145707/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CHK kernel/kheade
On Mon, Mar 03, 2025 at 11:48:08AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use IS_ENABLED() to check for CONFIG_DRM_KUNIT_TEST so
> that it picks up the modular case as well.
>
> Cc: Maxime Ripard
> Signed-off-by: Ville Syrjälä
Acked-by: Maxime Ripard
Maxime
signature.asc
De
On Fri, 28 Feb 2025, "Teres Alexis, Alan Previn"
wrote:
> One opinion - consider it a nit, but maybe since all of the content of this
> new
> header display specific, maybe instead of "i915_ggtt_view_types", why not
> "i915_plane_gtt_types"
> (or i915_display_gtt_types), if u plan to also expan
Since commit d59cf7bb73f3 ("drm/i915/display: Use dma_fence interfaces
instead of i915_sw_fence") we don't have anyone waiting on the
I915_RESET_MODESET bit, and there's no need for its semantics. Instead,
simply return true from intel_display_reset_prepare() to indicate that
intel_display_reset_fi
On Wed, 26 Feb 2025, Matt Roper wrote:
> On Wed, Feb 26, 2025 at 12:38:40PM +0200, Jani Nikula wrote:
>> On Tue, 25 Feb 2025, Matt Roper wrote:
>> > On Tue, Feb 25, 2025 at 01:14:20PM +0200, Jani Nikula wrote:
>> >> Move the checks for whether display reset is needed as well as
>> >> I915_RESET_M
Move the checks for whether display reset is needed at all to gt side of
things. This way, we can decide to skip the display calls altogether if
display reset is not required.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_reset.c | 5 -
drivers/gp
Add a helper for checking if we want to test display reset regardless of
whether it's strictly necessary. This will come in handy in follow-up
work where we want to check this from gt reset side.
v2: Drop superfluous newline
Cc: Matt Roper
Reviewed-by: Matt Roper
Signed-off-by: Jani Nikula
---
Drop the dependency on gt by providing a callback for trying to unbreak
stuck modeset. Do intel_gt_set_wedged() via the callback.
It's by no means pretty, but this is perhaps the most straightforward
alternative.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_
Deduplicate the gpu_reset_clobbers_display() part by passing the
information in from gt side.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_reset.c | 12 ++--
drivers/gpu/drm/i915/display/intel_display_reset.h | 2 +-
drivers/gpu/drm/i915/gt/i
Add a helper for checking the gpu_reset_clobbers_display flag to make it
easier to relocate the flag later.
Reviewed-by: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +-
drivers/gpu/drm/i915/gt/intel_
Going forward, struct intel_display will be the main display device
structure. Convert display reset to it as much as possible.
Reviewed-by: Matt Roper
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_reset.c| 51 ++-
.../drm/i915/display/intel_display_reset
pending_fb_pin is more about display than GPU reset. Move it to struct
intel_display. The restore sub-struct already contains reset related
members, so move it there.
Reviewed-by: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_core.h | 2 ++
drivers/gpu/d
v3 of [1], removing I915_RESET_MODESET flag altogether for even further
simplification.
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1740481927.git.jani.nik...@intel.com
Jani Nikula (8):
drm/i915/display: convert display reset to struct intel_display *
drm/i915: move pending_fb_pin to stru
On Fri, 28 Feb 2025, Jani Nikula wrote:
> It's undesirable to have to figure out the pxp pointer in display
> code. For one thing, its type is different for i915 and xe.
>
> Since we can figure the pxp pointer out in the pxp code from the gem
> object, offload it there.
>
> v2: Rebase
>
> Cc: Dani
On Mon, 03 Mar 2025, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use IS_ENABLED() to check for CONFIG_DRM_KUNIT_TEST so
> that it picks up the modular case as well.
>
> Cc: Maxime Ripard
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/drm_client_modeset.c
== Series Details ==
Series: drm/client: Stop using legacy crtc->mode and a bunch of cleanups (rev6)
URL : https://patchwork.freedesktop.org/series/139493/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16210 -> Patchwork_139493v6
===
== Series Details ==
Series: drm/client: Stop using legacy crtc->mode and a bunch of cleanups (rev6)
URL : https://patchwork.freedesktop.org/series/139493/
State : warning
== Summary ==
Error: dim checkpatch failed
4051cb5486a3 drm/client: Constify modes
76a751da4f32 drm/client: Use array nota
On Fri, 28 Feb 2025, Jani Nikula wrote:
> Jani Nikula (3):
> drm/i915/mst: add mst sub-struct to struct intel_dp
> drm/i915/mst: add mst sub-struct to struct intel_connector
> drm/i915/hdcp: add hdcp sub-struct to struct intel_digital_port
Thanks for the reviews, pushed to din.
BR,
Jani.
== Series Details ==
Series: LOBF enablement fix (rev5)
URL : https://patchwork.freedesktop.org/series/141974/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16210 -> Patchwork_141974v5
Summary
---
**SUCCESS**
No r
== Series Details ==
Series: LOBF enablement fix (rev5)
URL : https://patchwork.freedesktop.org/series/141974/
State : warning
== Summary ==
Error: dim checkpatch failed
6e00c0aa565f drm/i915/lobf: Add lobf enablement in post plane update
2d2fbd297ebf drm/i915/lobf: Disintegrate alpm_disable f
On Mon, 03 Mar 2025, Masahiro Yamada wrote:
> +CC: Linus
>
> On Wed, Jan 22, 2025 at 11:41 PM Jani Nikula wrote:
>>
>> Ensure drm headers build, are self-contained, have header guards, and
>> have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y.
>>
>> The mechanism follows similar patters u
> Hi,
>
> I noticed a few issues in this patch (while fixing the other ones reported),
> could
> you please check and follow up on the comments below? Thanks.
>
> On Wed, Jan 22, 2025 at 11:25:42AM +0530, Arun R Murthy wrote:
> > Mandate a minimum Hblank symbol cycle count between BlankingStart
From: Ville Syrjälä
Use IS_ENABLED() to check for CONFIG_DRM_KUNIT_TEST so
that it picks up the modular case as well.
Cc: Maxime Ripard
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_client_modeset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm
From: Ville Syrjälä
The modes used by the client code live on the connectors' mode
lists, which are not owned by the client code, and thus it has
no business modifying the modes. Mark the modes const to make
that fact abundantly clear.
v2: Fix up the kunit test
Reviewed-by: Jani Nikula
Reviewe
On Mon, 3 Mar 2025 13:22:29 +0530
"Murthy, Arun R" wrote:
> On 17-02-2025 17:57, Pekka Paalanen wrote:
> > On Mon, 17 Feb 2025 12:08:08 +0200
> > Pekka Paalanen wrote:
> >
> >> Hi Arun,
> >>
> >> this whole series seems to be missing all the UAPI docs for the DRM
> >> ReST files, e.g. drm-kms.
v1: Initial version.
v2: Addressed review comments from Jani.
v3: Addressed review comments from Jouni.
v4: Addressed review comments received on v3.
v5: Addressed review comments received on v4.
Signed-off-by: Animesh Manna
Animesh Manna (8):
drm/i915/lobf: Add lobf enablement in post plane u
> -Original Message-
> From: Manna, Animesh
> Sent: Tuesday, February 25, 2025 2:32 PM
> To: Nikula, Jani ; intel-gfx@lists.freedesktop.org;
> intel...@lists.freedesktop.org
> Cc: Hogander, Jouni ; B, Jeevan
>
> Subject: RE: [PATCH v4 2/8] drm/i915/lobf: Disintegrate alpm_disable from
>
On Sun, 02 Mar 2025, "Govindapillai, Vinod"
wrote:
> Hello drm maintainers,
>
> Could you please Ack this patch to get this merged through drm-intel-next..
>From IRC last week,
Acked-by: Thomas Zimmermann
>
> Thanks
> Vinod
>
> On Fri, 2025-02-28 at 11:37 +0200, Vinod Govindapillai wrote:
>>
Lobf is enabled part of ALPM configuration and if has_lobf
is set to true respective bit for LOBF will be set. Add debug
print while setting the bitfield of LOBF.
Signed-off-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
For every commit the dependent condition for LOBF is checked
and accordingly update has_lobf flag which will be used
to update the ALPM_CTL register during commit.
v1: Initial version.
v2: Avoid reading h/w register without has_lobf check. [Jani]
Signed-off-by: Animesh Manna
---
drivers/gpu/drm
Disable LOBF/ALPM for any erroneous condition from sink side.
v1: Initial version.
v2: Add centralized alpm error handling. [Jouni]
Signed-off-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_alpm.c | 25 +++
drivers/gpu/drm/i915/display/intel_alpm.h | 1 +
drivers/
The ALPM_CTL can be updated from different context, so
add mutex to sychonize the update.
Signed-off-by: Animesh Manna
---
drivers/gpu/drm/i915/display/intel_alpm.c | 19 +--
drivers/gpu/drm/i915/display/intel_alpm.h | 6 --
drivers/gpu/drm/i915/display/intel_ddi.c
Add an interface in debugfs which will help in debugging LOBF
feature.
v1: Initial version.
v2:
- Remove FORCE_EN flag. [Jouni]
- Change prefix from I915 to INTEL. [Jani]
- Use u8 instead of bool for lobf-debug flag. [Jani]
v3:
- Use intel_connector instead of display. [Jani]
- Remove edp connecto
Currently clearing of alpm registers is done through psr_disable()
which is always not correct, without psr also alpm can exist. So
dis-integrate alpm_disable() from psr_disable().
v1: Initial version.
v2:
- Remove h/w register read from alpm_disable(). [Jani]
Signed-off-by: Animesh Manna
---
d
Enablement of LOBF is added in post plane update whenever
has_lobf flag is set. As LOBF can be enabled in non-psr
case as well so adding in post plane update. There is no
change of configuring alpm with psr path.
v1: Initial version.
v2: Use encoder-mask to find the associated encoder from
crtc-st
On 20-02-2025 21:56, Dmitry Baryshkov wrote:
On Tue, Feb 18, 2025 at 11:13:39AM +0530, Murthy, Arun R wrote:
On 17-02-2025 15:38, Pekka Paalanen wrote:
Hi Arun,
this whole series seems to be missing all the UAPI docs for the DRM
ReST files, e.g. drm-kms.rst. The UAPI header doc comments are no
59 matches
Mail list logo
