Re: Regression on linux-next (next-20250205)

2025-02-10 Thread Mike Rapoport
Hello Chaitanya, On Mon, Feb 10, 2025 at 06:52:35AM +, Borah, Chaitanya Kumar wrote: > Hello Mike, > > Hope you are doing well. I am Chaitanya from the linux graphics team in Intel. > > This mail is regarding a regression we are seeing in our CI runs[1] on > linux-next repository. > > Sinc

Re: [PATCH v3 7/8] drm/i915/vrr: Check that the push send bit is clear after delayed vblank

2025-02-10 Thread Nautiyal, Ankit K
On 2/10/2025 9:37 PM, Ville Syrjala wrote: From: Ville Syrjälä Since we don't do mailbox updates the push send bit should alwyas clear by the time the delay vblank fires and the flip completes. Check for that to make sure we haven't screwed up the sequencing/vblank evasion/etc. On the DSB pa

Re: [PATCH v6 07/12] drm/i915/psr: Changes for PSR2_MAN_TRK_CTL handling when DSB is in use

2025-02-10 Thread Hogander, Jouni
On Mon, 2025-02-10 at 18:26 +0200, Ville Syrjälä wrote: > On Mon, Jan 27, 2025 at 12:28:41PM +0200, Jouni Högander wrote: > > Do needed changes to handle PSR2_MAN_TRK_CTL correctly when DSB is > > in use: > > > > 1. Write PSR2_MAN_TRK_CTL in commit_pipe_pre_planes only when not > > using > >    DS

Re: [PATCH v4 07/11] mtd: intel-dg: wake card on operations

2025-02-10 Thread Poosa, Karthik
On 30-01-2025 03:21, Rodrigo Vivi wrote: On Wed, Jan 01, 2025 at 05:39:21PM +0200, Alexander Usyskin wrote: Enable runtime PM in mtd driver to notify graphics driver that whole card should be kept awake while nvm operations are performed through this driver. CC: Lucas De Marchi Acked-by: Miq

Re: [PATCH] drm/xe: Add per-engine pagefault and reset counts

2025-02-10 Thread Matthew Brost
On Mon, Feb 10, 2025 at 07:37:36PM +, Cavitt, Jonathan wrote: > Wrong mailing list. Sorry. Please ignore this email. > -Jonathan Cavitt > I replied here... I guess continue this conversation here? Almost everyone in on both lists... Matt > -Original Message- > From: Cavitt, Jonath

Re: [PATCH] drm/xe: Add per-engine pagefault and reset counts

2025-02-10 Thread Matthew Brost
On Mon, Feb 10, 2025 at 07:35:44PM +, Jonathan Cavitt wrote: > Add counters to all engines that count the number of pagefaults and > engine resets that have been triggered on them. Report these values > during an engine reset. > > Signed-off-by: Jonathan Cavitt > CC: Tomasz Mistat > CC: Aya

Re: [PATCH] drm/xe: Add per-engine pagefault and reset counts

2025-02-10 Thread Matthew Brost
On Mon, Feb 10, 2025 at 07:35:44PM +, Jonathan Cavitt wrote: > Add counters to all engines that count the number of pagefaults and > engine resets that have been triggered on them. Report these values > during an engine reset. > I'm not opposed to adding stats for engines, but if we do, I thi

✓ i915.CI.BAT: success for drm/i915: More display power conversions

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915: More display power conversions URL : https://patchwork.freedesktop.org/series/144636/ State : success == Summary == CI Bug Log - changes from CI_DRM_16104 -> Patchwork_144636v1 Summary --- **SUC

✗ Fi.CI.SPARSE: warning for drm/i915: More display power conversions

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915: More display power conversions URL : https://patchwork.freedesktop.org/series/144636/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[PATCH 4/4] drm/i915: Get rid of the _unchecked() runime pm stuff

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Seem to me that intel_runtime_pm.c already handles the CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n case perfectly fine internally, so I don't understand why it's being leaked into all the callers as well. Get rid of all this the externally visible _unchecked() stuff. Signed-off-by: Vi

[PATCH 3/4] drm/i915/gvt: Stop using intel_runtime_pm_put_unchecked()

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä intel_runtime_pm_put_unchecked() is not meant to be used outside the runtime pm implementation, so don't. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/gvt/aperture_gm.c | 7 --- drivers/gpu/drm/i915/gvt/debugfs.c | 5 +++-- drivers/gpu/drm/i915/gvt/gtt.

[PATCH 2/4] drm/i915: Continue intel_display_power struct intel_display conversion

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Convert the remaining intel_display_power.h interfaces to take struct intel_display instead of struct drm_i915_private. intel_display_power.c still has some internal uses due to i915->runtime_pm. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/g4x_dp.c

[PATCH 1/4] drm/i915: Fix CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n build

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Looks like I missed one of myriad CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n special cases when converting the intel_display_power_{get,put}() code to use struct intel_display. Only noticed after the fact when building a EXPERT=n kernel :/ Fixes: 5dcfda5cfa42 ("drm/i915: Convert inte

[PATCH 0/4] drm/i915: More display power conversions

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Apparently I screwed up the i915->display conversion a bit so here's a fix, and an attempt at eliminating the specific footgun hat got me. I also noticed that not much more i915 left in intel_display_power.h so I decided to finish it off. Ville Syrjälä (4): drm/i915: Fix CO

Re: [PATCH] prandom: remove next_pseudo_random32

2025-02-10 Thread Andi Shyti
Hi, On Mon, Feb 10, 2025 at 02:39:43PM +0100, Jason A. Donenfeld wrote: > Hey Markus, > > Thanks for this. I hadn't realized that next_pseudo_random32() only > had two users left. Excellent. > > I'll queue this up in the random tree (unless there are objections > from the maintainers of that tes

✓ i915.CI.BAT: success for drm/xe: Add per-engine pagefault and reset counts

2025-02-10 Thread Patchwork
== Series Details == Series: drm/xe: Add per-engine pagefault and reset counts URL : https://patchwork.freedesktop.org/series/144622/ State : success == Summary == CI Bug Log - changes from CI_DRM_16103 -> Patchwork_144622v1 Summary ---

Re: [PATCH v6 5/7] drm/i915/xe3: dirty rect support for FBC

2025-02-10 Thread Govindapillai, Vinod
Hi Ville, Regarding the async_clip I was trying a new test case but noticed that it was nuking on asyn_flip. So I checked with HW folks, then confirmed that FBC will nuke on async_flip. Dirty rectangle only works with sync flip. He pointed out that in the bspec (I overlooked that aspect though

Re: [PATCH 0/3] drm/i915: Fix scanline_offset for LNL+/BMG+

2025-02-10 Thread Matt Roper
On Mon, Feb 10, 2025 at 10:02:58PM +0200, Ville Syrjälä wrote: > On Mon, Feb 10, 2025 at 12:10:56PM -0600, Lucas De Marchi wrote: > > On Mon, Feb 10, 2025 at 06:16:58PM +0200, Ville Syrjälä wrote: > > >On Fri, Feb 07, 2025 at 04:41:11PM -0600, Lucas De Marchi wrote: > > >> On Fri, Feb 07, 2025 at 1

✗ i915.CI.BAT: failure for drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev4)

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev4) URL : https://patchwork.freedesktop.org/series/144153/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16102 -> Patchwork_144153v4 Summary ---

✓ i915.CI.BAT: success for prandom: remove next_pseudo_random32

2025-02-10 Thread Patchwork
== Series Details == Series: prandom: remove next_pseudo_random32 URL : https://patchwork.freedesktop.org/series/144613/ State : success == Summary == CI Bug Log - changes from CI_DRM_16102 -> Patchwork_144613v1 Summary --- **SUCCESS

✗ Fi.CI.SPARSE: warning for drm/xe: Add per-engine pagefault and reset counts

2025-02-10 Thread Patchwork
== Series Details == Series: drm/xe: Add per-engine pagefault and reset counts URL : https://patchwork.freedesktop.org/series/144622/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 0/3] drm/i915: Fix scanline_offset for LNL+/BMG+

2025-02-10 Thread Ville Syrjälä
On Mon, Feb 10, 2025 at 12:10:56PM -0600, Lucas De Marchi wrote: > On Mon, Feb 10, 2025 at 06:16:58PM +0200, Ville Syrjälä wrote: > >On Fri, Feb 07, 2025 at 04:41:11PM -0600, Lucas De Marchi wrote: > >> On Fri, Feb 07, 2025 at 11:54:03PM +0200, Ville Syrjälä wrote: > >> >From: Ville Syrjälä > >> >

RE: [PATCH] drm/xe: Add per-engine pagefault and reset counts

2025-02-10 Thread Cavitt, Jonathan
Wrong mailing list. Sorry. Please ignore this email. -Jonathan Cavitt -Original Message- From: Cavitt, Jonathan Sent: Monday, February 10, 2025 11:36 AM To: intel-gfx@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; Cavitt, Jonathan ; Vishwanathapura, Niranjana ; Siddiqui, Aya

[PATCH] drm/xe: Add per-engine pagefault and reset counts

2025-02-10 Thread Jonathan Cavitt
Add counters to all engines that count the number of pagefaults and engine resets that have been triggered on them. Report these values during an engine reset. Signed-off-by: Jonathan Cavitt CC: Tomasz Mistat CC: Ayaz A Siddiqui CC: Niranjana Vishwanathapura --- drivers/gpu/drm/xe/xe_gt_page

Re: xf86-video-intel is broken and with MRs disables we can't fix it

2025-02-10 Thread Enrico Weigelt, metux IT consult
On 07.02.25 22:25, Ville Syrjälä wrote: Hi, xf86-video-intel driver is currently cannot be compiled with released versions of X server. Simple reproduction steps: create Debian Bookworm container, download module sources and all required dependencies and try to build. Builds fine on my Gentoo

Re: xf86-video-intel is broken and with MRs disables we can't fix it

2025-02-10 Thread Povilas Kanapickas
On 2025-02-07 23:25, Ville Syrjälä wrote: > On Fri, Feb 07, 2025 at 08:57:34PM +0200, Povilas Kanapickas wrote: >> Hi, >> >> xf86-video-intel driver is currently cannot be compiled with released >> versions of X server. Simple reproduction steps: create Debian Bookworm >> container, download module

✗ Fi.CI.SPARSE: warning for drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev4)

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev4) URL : https://patchwork.freedesktop.org/series/144153/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bit

✗ Fi.CI.CHECKPATCH: warning for drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev4)

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev4) URL : https://patchwork.freedesktop.org/series/144153/ State : warning == Summary == Error: dim checkpatch failed f0d6bc88665f drm/i915/dsb: Move the +1 usec adjustment into dsb_wait_usec() d282fb2b1174 drm/i915/vrr:

✗ Fi.CI.BUILD: failure for Silence warns and fix up sprite stuff

2025-02-10 Thread Patchwork
== Series Details == Series: Silence warns and fix up sprite stuff URL : https://patchwork.freedesktop.org/series/144617/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/144617/revisions/1/mbox/ not applied Applying: Fix transposed calloc() argumen

Re: [PATCH 12/17] drm/i915/ddi: Configure/enable a port in DDI_BUF_CTL via read-modify-write

2025-02-10 Thread Imre Deak
On Mon, Feb 10, 2025 at 08:13:14PM +0200, Jani Nikula wrote: > On Wed, 29 Jan 2025, Imre Deak wrote: > > From: Imre Deak > > > > The various flags in DDI_BUF_CTL must be programmed at different places > > during a modeset. The expected value of the register at any moment is > > cached in the inte

✗ Fi.CI.BUILD: failure for meson: Add dependency on xv

2025-02-10 Thread Patchwork
== Series Details == Series: meson: Add dependency on xv URL : https://patchwork.freedesktop.org/series/144614/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/144614/revisions/1/mbox/ not applied Applying: meson: Add dependency on xv error: sha1 i

✗ Fi.CI.CHECKPATCH: warning for prandom: remove next_pseudo_random32

2025-02-10 Thread Patchwork
== Series Details == Series: prandom: remove next_pseudo_random32 URL : https://patchwork.freedesktop.org/series/144613/ State : warning == Summary == Error: dim checkpatch failed 5d8c46c50567 prandom: remove next_pseudo_random32 -:62: WARNING:LINE_SPACING: Missing a blank line after declarati

Re: [PATCH 12/17] drm/i915/ddi: Configure/enable a port in DDI_BUF_CTL via read-modify-write

2025-02-10 Thread Jani Nikula
On Wed, 29 Jan 2025, Imre Deak wrote: > From: Imre Deak > > The various flags in DDI_BUF_CTL must be programmed at different places > during a modeset. The expected value of the register at any moment is > cached in the intel_dp::DP variable and the whole register is written > using this variable

Re: [PATCH 0/3] drm/i915: Fix scanline_offset for LNL+/BMG+

2025-02-10 Thread Lucas De Marchi
On Mon, Feb 10, 2025 at 06:16:58PM +0200, Ville Syrjälä wrote: On Fri, Feb 07, 2025 at 04:41:11PM -0600, Lucas De Marchi wrote: On Fri, Feb 07, 2025 at 11:54:03PM +0200, Ville Syrjälä wrote: >From: Ville Syrjälä > >Something has changed in the hardware on LNL/BMG because >HDMI outputs no longer

Re: [PATCH 13/17] drm/i915/ddi: Factor out a helper to get DDI_BUF_CTL's config value

2025-02-10 Thread Jani Nikula
On Wed, 29 Jan 2025, Imre Deak wrote: > Factor out a function to get the configuration fields in the DDI_BUF_CTL > register. This can be used for configuring an HDMI output as well. > > Signed-off-by: Imre Deak Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 32 +++

✗ i915.CI.BAT: failure for drm/i915/pcode: Fix the coding style

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915/pcode: Fix the coding style URL : https://patchwork.freedesktop.org/series/144608/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16098 -> Patchwork_144608v1 Summary --- **FAILURE

[PATCH xf86-video-intel 7/7] sna/video/sprite: Reset colorkey whenever disabling the sprite plane

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Let's disable the colorkey whenever we hide the sprite. The colorkey is a non-standard thing so generic kms clients have no way to disable it, and the kernel may reject certain otherwise legal things if colorkeying is left active. Signed-off-by: Ville Syrjälä --- src/sna/sn

[PATCH xf86-video-intel 6/7] sna/video/sprite: Extract sna_video_sprite_hide()

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä --- src/sna/sna_video_sprite.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/src/sna/sna_video_sprite.c b/src/sna/sna_video_sprite.c index e2541e351b3f..5f1e4616a23e 100644 --- a/src/sna/sna_video_sprite.c +++ b/src/sn

[PATCH xf86-video-intel 3/7] sna/kgem: Add kgem_bo_replace()

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Add a helper to do the unref old + ref new bo dance. Signed-off-by: Ville Syrjälä --- src/sna/kgem.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/sna/kgem.h b/src/sna/kgem.h index 6a087a574a78..205a4eaefb75 100644 --- a/src/sna/kgem.h +++ b/src/sna/kgem.

[PATCH xf86-video-intel 4/7] sna/video/sprite: Use kgem_bo_replace()

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Replace the hand rolled bo unref+ref stuff with kgem_bo_replace(). Signed-off-by: Ville Syrjälä --- src/sna/sna_video_sprite.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/sna/sna_video_sprite.c b/src/sna/sna_video_sprite.c index db

[PATCH xf86-video-intel 5/7] sna/video/sprite: Plug bo leak

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Looks like we're leaking video->bo[index] if the entire sprite gets clipped. Let's plug that leak. Signed-off-by: Ville Syrjälä --- src/sna/sna_video_sprite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sna/sna_video_sprite.c b/src/sna/sna_video_

[PATCH xf86-video-intel 2/7] sna: Don't memcpy() between different types

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Currently we're doing a blind memcpy() from a DDXPointRec into the beginning of a BoxRec. While this apparently works it's quite dodgy. Get rid of the memcpy() and simply assign each member by hand. Signed-off-by: Ville Syrjälä --- src/sna/fb/fbspan.c | 22 +

[PATCH xf86-video-intel 1/7] Fix transposed calloc() arguments

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä gcc-14 complains: ../src/legacy/i810/i810_dri.c:281:48: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] ... Fix them all up via cocci: @@ expression E1, E2; type T; @@ ( - calloc(sizeof(T), E2)

[PATCH xf86-video-intel 0/7] Silence warns and fix up sprite stuff

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Found some old sprite xv stuff sitting around in my local repo. Also gcc-14 has become noisy wrt. transposed calloc() arguments, so fix those up as well. Ville Syrjälä (7): Fix transposed calloc() arguments sna: Don't memcpy() between different types sna/kgem: Add kgem

✓ i915.CI.BAT: success for drm/xe/display: Fix fbdev GGTT mapping handling.

2025-02-10 Thread Patchwork
== Series Details == Series: drm/xe/display: Fix fbdev GGTT mapping handling. URL : https://patchwork.freedesktop.org/series/144603/ State : success == Summary == CI Bug Log - changes from CI_DRM_16098 -> Patchwork_144603v1 Summary ---

Re: [PATCH 3/5] drm/i915: Constify 'struct bin_attribute'

2025-02-10 Thread Andi Shyti
Hi Thomas, On Mon, Dec 16, 2024 at 12:34:49PM +0100, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh

Re: [PATCH 2/5] drm/lima: Constify 'struct bin_attribute'

2025-02-10 Thread Andi Shyti
Hi Thomas, On Mon, Dec 16, 2024 at 12:34:48PM +0100, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh

Re: [PATCH 1/5] drm/sysfs: Constify 'struct bin_attribute'

2025-02-10 Thread Andi Shyti
Hi Thomas, On Mon, Dec 16, 2024 at 12:34:47PM +0100, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh

Re: [PATCH xf86-video-intel] meson: Add dependency on xv

2025-02-10 Thread Ville Syrjälä
On Sat, Feb 08, 2025 at 12:24:26AM +0200, Povilas Kanapickas wrote: > Symbols such as XvCreateImage, XvPutImage, XvGetPortAttribute come from > libXv.so. Linking to this dependency directly fixes build errors on > Debian Bookworm against xserver 21.1. Thanks, pushed to master. > --- > meson.buil

Re: [PATCH 0/5] drm: Constify 'struct bin_attribute'

2025-02-10 Thread Thomas Weißschuh
Hi, On 2024-12-16 12:34:46+0100, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. Can anybody pick up these patches? Except for lima they a

✓ i915.CI.BAT: success for drm_i915_private to intel_display cleanup

2025-02-10 Thread Patchwork
== Series Details == Series: drm_i915_private to intel_display cleanup URL : https://patchwork.freedesktop.org/series/144588/ State : success == Summary == CI Bug Log - changes from CI_DRM_16098 -> Patchwork_144588v1 Summary --- **SU

Re: [PATCH v6 11/12] drm/i915/display: Ensure we have "Frame Change" event in DSB commit

2025-02-10 Thread Ville Syrjälä
On Mon, Jan 27, 2025 at 12:28:45PM +0200, Jouni Högander wrote: > We may have commit which doesn't have any non-arming plane register > writes. In that case there aren't "Frame Change" event before DSB vblank > evasion which hangs as PIPEDSL register is reading as 0 when PSR state is > SRDENT(PSR1)

Re: [PATCH v6 10/12] drm/i915/psr: Add function for triggering "Frame Change" event

2025-02-10 Thread Ville Syrjälä
On Mon, Jan 27, 2025 at 12:28:44PM +0200, Jouni Högander wrote: > Add new function to trigger "Frame Change" event for ensuring we are waking > up before vblank evasion. > > Signed-off-by: Jouni Högander > --- > drivers/gpu/drm/i915/display/intel_psr.c | 22 ++ > drivers/gpu/

Re: [PATCH v6 09/12] drm/i915/display: Evade scanline 0 as well if PSR1 or PSR2 is enabled

2025-02-10 Thread Ville Syrjälä
On Mon, Jan 27, 2025 at 12:28:43PM +0200, Jouni Högander wrote: > PIPEDSL is reading as 0 when in SRDENT(PSR1) or DEEP_SLEEP(PSR2). On > wake-up scanline counting starts from vblank_start - 1. We don't know if > wake-up is already ongoing when evasion starts. In worst case PIPEDSL could > start rea

Re: [PATCH v6 08/12] drm/i915/psr: Remove DSB_SKIP_WAITS_EN chicken bit

2025-02-10 Thread Ville Syrjälä
On Mon, Jan 27, 2025 at 12:28:42PM +0200, Jouni Högander wrote: > We have different approach on how flip is considered being complete. We are > waiting for vblank on DSB and generate interrupt when it happens and this > interrupt is considered as indication of completion -> we definitely do not > w

Re: [PATCH v6 07/12] drm/i915/psr: Changes for PSR2_MAN_TRK_CTL handling when DSB is in use

2025-02-10 Thread Ville Syrjälä
On Mon, Jan 27, 2025 at 12:28:41PM +0200, Jouni Högander wrote: > Do needed changes to handle PSR2_MAN_TRK_CTL correctly when DSB is in use: > > 1. Write PSR2_MAN_TRK_CTL in commit_pipe_pre_planes only when not using >DSB. > 2. Add PSR2_MAN_TRK_CTL writing into DSB commit in >intel_atomic_

Re: [PATCH 0/3] drm/i915: Fix scanline_offset for LNL+/BMG+

2025-02-10 Thread Ville Syrjälä
On Fri, Feb 07, 2025 at 04:41:11PM -0600, Lucas De Marchi wrote: > On Fri, Feb 07, 2025 at 11:54:03PM +0200, Ville Syrjälä wrote: > >From: Ville Syrjälä > > > >Something has changed in the hardware on LNL/BMG because > >HDMI outputs no longer have the extra scanline offset. > > > >I confirmed that

[PATCH v3 7/8] drm/i915/vrr: Check that the push send bit is clear after delayed vblank

2025-02-10 Thread Ville Syrjala
From: Ville Syrjälä Since we don't do mailbox updates the push send bit should alwyas clear by the time the delay vblank fires and the flip completes. Check for that to make sure we haven't screwed up the sequencing/vblank evasion/etc. On the DSB path we should be able to guarantee this since we

Re: [PATCH 0/3] drm/i915: Fix scanline_offset for LNL+/BMG+

2025-02-10 Thread Gustavo Sousa
Quoting Lucas De Marchi (2025-02-07 19:41:11-03:00) >On Fri, Feb 07, 2025 at 11:54:03PM +0200, Ville Syrjälä wrote: >>From: Ville Syrjälä >> >>Something has changed in the hardware on LNL/BMG because >>HDMI outputs no longer have the extra scanline offset. >> >>I confirmed that MTL still has the o

✓ i915.CI.BAT: success for drm/i915: Fix harmfull driver register/unregister assymetry (rev2)

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix harmfull driver register/unregister assymetry (rev2) URL : https://patchwork.freedesktop.org/series/144436/ State : success == Summary == CI Bug Log - changes from CI_DRM_16098 -> Patchwork_144436v2

Re: xf86-video-intel is broken and with MRs disables we can't fix it

2025-02-10 Thread Povilas Kanapickas
Hi Ville, Thanks for quick response. Turns out due to multiple factors leading to my confusion most parts of the email are plainly wrong. Apologies for going to public mailing list without more research and discussion. On 2025-02-07 23:25, Ville Syrjälä wrote: > On Fri, Feb 07, 2025 at 08:57:34P

✓ i915.CI.BAT: success for selftests: i915: Use struct_size() helper in kmalloc()

2025-02-10 Thread Patchwork
== Series Details == Series: selftests: i915: Use struct_size() helper in kmalloc() URL : https://patchwork.freedesktop.org/series/144585/ State : success == Summary == CI Bug Log - changes from CI_DRM_16098 -> Patchwork_144585v1 Summary --

xf86-video-intel is broken and with MRs disables we can't fix it

2025-02-10 Thread Povilas Kanapickas
Hi, xf86-video-intel driver is currently cannot be compiled with released versions of X server. Simple reproduction steps: create Debian Bookworm container, download module sources and all required dependencies and try to build. Debian Bookworm is pretty much the least exciting configuration poss

[PATCH] prandom: remove next_pseudo_random32

2025-02-10 Thread Markus Theil
next_pseudo_random32 implements a LCG with known bad statistical properties and is only used in two pieces of testing code. Remove and convert users to the remaining single PRNG interface in prandom/random32. This removes another option of using an insecure PRNG. This is a preliminary patch for f

[PATCH xf86-video-intel] meson: Add dependency on xv

2025-02-10 Thread Povilas Kanapickas
Symbols such as XvCreateImage, XvPutImage, XvGetPortAttribute come from libXv.so. Linking to this dependency directly fixes build errors on Debian Bookworm against xserver 21.1. --- meson.build | 1 + src/legacy/i810/xvmc/meson.build | 1 + xvmc/meson.build | 1

✗ Fi.CI.CHECKPATCH: warning for drm/xe/display: Fix fbdev GGTT mapping handling.

2025-02-10 Thread Patchwork
== Series Details == Series: drm/xe/display: Fix fbdev GGTT mapping handling. URL : https://patchwork.freedesktop.org/series/144603/ State : warning == Summary == Error: dim checkpatch failed ab9554d7aba7 drm/xe/display: Fix fbdev GGTT mapping handling. -:85: WARNING:FILE_PATH_CHANGES: added,

✗ Fi.CI.CHECKPATCH: warning for drm_i915_private to intel_display cleanup

2025-02-10 Thread Patchwork
== Series Details == Series: drm_i915_private to intel_display cleanup URL : https://patchwork.freedesktop.org/series/144588/ State : warning == Summary == Error: dim checkpatch failed 32c4709d5b05 drm/i915/display_debug_fs: Use intel_display wherever possible -:50: WARNING:SUSPECT_CODE_INDENT

✗ Fi.CI.SPARSE: warning for drm_i915_private to intel_display cleanup

2025-02-10 Thread Patchwork
== Series Details == Series: drm_i915_private to intel_display cleanup URL : https://patchwork.freedesktop.org/series/144588/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.SPARSE: warning for drm/i915: Fix harmfull driver register/unregister assymetry (rev2)

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix harmfull driver register/unregister assymetry (rev2) URL : https://patchwork.freedesktop.org/series/144436/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix harmfull driver register/unregister assymetry (rev2)

2025-02-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix harmfull driver register/unregister assymetry (rev2) URL : https://patchwork.freedesktop.org/series/144436/ State : warning == Summary == Error: dim checkpatch failed 9793272388a1 drm/i915: Fix PM reference not released if device register fails -:19:

Re: [PATCH] drm/i915/pcode: Fix the coding style

2025-02-10 Thread Andi Shyti
Hi Nitin, On Mon, Feb 10, 2025 at 07:39:24PM +0530, Nitin Gote wrote: > Prefer binary operator at the end of the previous > line instead of putting operator at the start of > the next line as per coding style. I'm not finding any documentation for this change, where did you take it? Andi

[PATCH] drm/i915/pcode: Fix the coding style

2025-02-10 Thread Nitin Gote
Prefer binary operator at the end of the previous line instead of putting operator at the start of the next line as per coding style. Signed-off-by: Nitin Gote --- drivers/gpu/drm/i915/intel_pcode.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/

Re: [PATCH] prandom: remove next_pseudo_random32

2025-02-10 Thread Jason A. Donenfeld
Hey Markus, Thanks for this. I hadn't realized that next_pseudo_random32() only had two users left. Excellent. I'll queue this up in the random tree (unless there are objections from the maintainers of that test code). Jason

[PATCH] drm/xe/display: Fix fbdev GGTT mapping handling.

2025-02-10 Thread Maarten Lankhorst
The fbdev vma is a normal unrotated VMA, so add ane explicit check before re-using. When re-using, we have to restore the GGTT mapping on resume, so add some code to do that too. Fixes: 67a98f7e27ba ("drm/xe/display: Re-use display vmas when possible") Signed-off-by: Maarten Lankhorst --- drive

Re: [PATCH 0/3] drm/i915: Fix harmfull driver register/unregister assymetry

2025-02-10 Thread Andi Shyti
Hi Janusz, On Thu, Feb 06, 2025 at 07:07:38PM +0100, Janusz Krzysztofik wrote: > We return immediately from i915_driver_register() if drm_dev_register() > fails, skipping remaining registration steps. However, the _unregister() > counterpart called at device remove knows nothing about that skip a

[PATCH 5/9] drm/i915/dpll: Use intel_display possible in shared_dpll_mgr hooks

2025-02-10 Thread Suraj Kandpal
We use intel_display for function hooks of shared_dpll_mgr and any function that gets called when we use for_each_shared_dpll. This also contains some opportunistic display->platform.xx changes all to reductate the use of drm_i915_private. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/di

[PATCH 9/9] drm/i915/dpll: Replace all other leftover drm_i915_private

2025-02-10 Thread Suraj Kandpal
Replace all other left over drm_i915_private with intel_display in dpll_mgr.c. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 99 +-- 1 file changed, 48 insertions(+), 51 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b

[PATCH 6/9] drm/i915/dpll: Use intel_display for asserting pll

2025-02-10 Thread Suraj Kandpal
Use intel_display instead of drm_i915_private to assert pll enabled and disabled and the corresponding changes needed to make that happen. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display.c | 22 +-- .../i915/display/intel_display_power_well.c | 10 +

[PATCH 8/9] drm/i915/dpll: Accept intel_display as argument for shared_dpll_init

2025-02-10 Thread Suraj Kandpal
Use intel_display as an argument for intel_shared_dpll_init() and replace drm_i915_private in function wherever possible. While at it prefer using display->platform.xx over IS_PLATFORM. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_driver.c | 2 +- drivers/gpu/drm/i915/d

[PATCH 1/9] drm/i915/display_debug_fs: Use intel_display wherever possible

2025-02-10 Thread Suraj Kandpal
Use struct intel_display wherever possible in intel_display_debug_fs.c to reduce the use of drm_i915_private. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_debugfs.c | 157 +- 1 file changed, 81 insertions(+), 76 deletions(-) diff --git a/drivers/gpu/drm/i

[PATCH 7/9] drm/i915/dpll: Use intel_display for update_refclk hook

2025-02-10 Thread Suraj Kandpal
Use intel_display instead of drm_i915_private for update_refclk hook. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_driver.c | 2 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 32 +-- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 2 +- 3 files cha

[PATCH 4/9] drm/i915/dpll: Use intel_display for dpll dump and compare hw state

2025-02-10 Thread Suraj Kandpal
Lets use intel_display for dpll dump and compare hw state. This also helps elimanate drm_i915_private dependency from i915_shared_dplls_info in display_debug_fs. Signed-off-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_crtc_state_dump.c | 3 ++- drivers/gpu/drm/i915/display/intel_display

[PATCH 3/9] drm/i915/dpll: Change param to intel_display in for_each_shared_dpll

2025-02-10 Thread Suraj Kandpal
Change the argument of for_each_shared_dpll to take intel_display which helps move as an ongoing effort to get rid off the dependency on drm_i915_private. Some opportunistic changes in intel_pch_refclk done too. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_display_debugfs.c | 2

[PATCH 2/9] drm/i915/display_debug_fs: Prefer using display->platform

2025-02-10 Thread Suraj Kandpal
Prefer using display->platform.xx instead of IS_PLATFORM() checks Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/g

[PATCH 0/9] drm_i915_private to intel_display cleanup

2025-02-10 Thread Suraj Kandpal
This series started as a cleanup to convert as many drm_i915_private to intel_display in intel_display_debug_fs but overflowed and ended up cleaning intel_dpll_mgr.c part of the code too and some other places calling these functions. This series also replaces IS_PLATFORM() with display->platform.xx

Re: [PATCH v6 5/7] drm/i915/xe3: dirty rect support for FBC

2025-02-10 Thread Govindapillai, Vinod
Hi Ville, I need to check the async flip tests for dirty rect cases. But could you please clarify some of your comments before i send another version.. On Wed, 2025-02-05 at 17:45 +0200, Ville Syrjälä wrote: > On Wed, Feb 05, 2025 at 02:49:46PM +, Govindapillai, Vinod wrote: > > So based o

RE: [PATCH 4/3] drm/i915/hdcp: Make some functions static

2025-02-10 Thread Jani Nikula
On Fri, 07 Feb 2025, "Kandpal, Suraj" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Friday, February 7, 2025 4:29 PM >> To: Nikula, Jani ; intel-gfx@lists.freedesktop.org; >> intel...@lists.freedesktop.org >> Cc: Kandpal, Suraj >> Subject: [PATCH 4/3] drm/i915/hdcp: Make so

[PATCH] selftests: i915: Use struct_size() helper in kmalloc()

2025-02-10 Thread l1138897701
From: luoqing Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows. Signed-off-by: luoqing --- drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.c | 3 +--