Re: httpd/carddav from git sources

2016-06-29 Thread Ken Murchison via Info-cyrus
> On Jun 29, 2016, at 9:30 AM, Johan Hattne wrote: > > >>> On Jun 29, 2016, at 09:11, Ken Murchison wrote: >>> >>> On Jun 29, 2016, at 8:55 AM, Johan Hattne wrote: >>> >>> Hi Ellie & Ken; >>> On Jun 28, 2016, at 20:47, ellie timoney wrote: Hi Johan, > In the u

Re: httpd/carddav from git sources

2016-06-29 Thread Johan Hattne via Info-cyrus
> On Jun 29, 2016, at 09:11, Ken Murchison wrote: > >> On Jun 29, 2016, at 8:55 AM, Johan Hattne wrote: >> >> Hi Ellie & Ken; >> >>> On Jun 28, 2016, at 20:47, ellie timoney wrote: >>> >>> Hi Johan, >>> In the unpatched code, a sasl_http_request_t structure is created on the stac

Re: httpd/carddav from git sources

2016-06-29 Thread Ken Murchison via Info-cyrus
> On Jun 29, 2016, at 8:55 AM, Johan Hattne wrote: > > Hi Ellie & Ken; > >> On Jun 28, 2016, at 20:47, ellie timoney wrote: >> >> Hi Johan, >> >>> In the unpatched code, a sasl_http_request_t structure is created on the >>> stack and a pointer to it is copied to httpd_saslconn using >>> sas

Re: httpd/carddav from git sources

2016-06-29 Thread Johan Hattne via Info-cyrus
Hi Ellie & Ken; > On Jun 28, 2016, at 20:47, ellie timoney wrote: > > Hi Johan, > >> In the unpatched code, a sasl_http_request_t structure is created on the >> stack and a pointer to it is copied to httpd_saslconn using >> sasl_setprop(). When the structure goes out of scope, there is no >> g

Re: httpd/carddav from git sources

2016-06-28 Thread ellie timoney via Info-cyrus
Hi Johan, > In the unpatched code, a sasl_http_request_t structure is created on the > stack and a pointer to it is copied to httpd_saslconn using > sasl_setprop(). When the structure goes out of scope, there is no > guarantee that its members will be preserved. A diff against the code I > just

Re: httpd/carddav from git sources

2016-06-28 Thread Johan Hattne via Info-cyrus
> On Jun 26, 2016, at 20:02, ellie timoney wrote: > > Hi Johan, > > I don't know how your git repository got into that state... > >> $ git describe >> cyrus-imapd-2.5-snapshot-autoconf-and-automake-3857-g4049dd2 > > This says that the nearest tag your git can find is > "cyrus-imapd-2.5-snap

Re: httpd/carddav from git sources

2016-06-26 Thread ellie timoney via Info-cyrus
Hi Johan, I don't know how your git repository got into that state... > $ git describe > cyrus-imapd-2.5-snapshot-autoconf-and-automake-3857-g4049dd2 This says that the nearest tag your git can find is "cyrus-imapd-2.5-snapshot-autoconf-and-automake"(which is over four years old), and that y

Re: httpd/carddav from git sources

2016-06-24 Thread Johan Hattne via Info-cyrus
Hi Ellie; $ git remote show origin | head -n 4 * remote origin Fetch URL: git://git.cyrusimap.org/cyrus-imapd Push URL: git://git.cyrusimap.org/cyrus-imapd HEAD branch: master $ git describe cyrus-imapd-2.5-snapshot-autoconf-and-automake-3857-g4049dd2 I got this all from htt

Re: httpd/carddav from git sources

2016-06-23 Thread ellie timoney via Info-cyrus
Hi Johan, What revision are these patches against? The Makefile.am patch is unnecessary, and doesn't apply cleanly anyway, so I suspect you're looking at an old revision. I haven't studied the httpd patch in depth yet. Cheers, ellie On Thu, Jun 23, 2016, at 12:59 AM, Johan Hattne via Info-cyr