Hi John,
This was already fixed in 2.5.0 and later [1], but a lot changed to enable it,
so that fix was too invasive to backport.
Your patch looks like a good solution for 2.4! It's now on the cyrus-imapd-2.4
branch :)
Cheers,
ellie
[1]
https://github.com/cyrusimap/cyrus-imapd/commit/f0a
Replicating annotations when sync_client -u is used to move mailboxes to a
different
server does not work in 2.4.20 and probably not in 2.5.X either. At lest I
can't find
anyplace in the 2.5 code that replicates folder annotations.
Annotation replication does work in rolling replication mode.