Re: [Groff] Suggested patch to post-html.cpp

2014-09-23 Thread Steffen Nurpmeso
Hey, Robert, Robert Bocchino wrote: |> ..I agree with Betrand: it would be better to understand the code |> paths as such. | |I definitely agree, although as I said to Bertrand, I think \ |the first goal should be to get system tests in place. | |> I personally would be happy if there woul

Re: [Groff] Suggested patch to post-html.cpp

2014-09-22 Thread Robert Bocchino
Hi Steffen, > I have your message also in my queue but it will take quite some > time until i will be able to use your test. > ..I agree with Betrand: it would be better to understand the code > paths as such. I definitely agree, although as I said to Bertrand, I think the first goal should be t

Re: [Groff] Suggested patch to post-html.cpp

2014-09-22 Thread Robert Bocchino
Hi Bertrand, On Sep 22, 2014, at 2:05 AM, Bertrand Garrigues wrote: > Are you thinking of unit tests, using a test framework for C++, or more > global tests (using for example shell script) ? I was thinking of system-level tests, at least initially. For example, the grohtml postprocessor oper

Re: [Groff] Suggested patch to post-html.cpp

2014-09-22 Thread Steffen Nurpmeso
Hello Robert, Robert Bocchino wrote: |On Sep 21, 2014, at 2:25 PM, Bertrand Garrigues wrote: |> I am not qualified to review your patch because I haven't studied |> grohtml's code, but I've tested it on the few .html files that are built |> by default in the 'doc' directory from pic.ms and w

Re: [Groff] Suggested patch to post-html.cpp

2014-09-22 Thread Bertrand Garrigues
Robert, On Mon, Sep 22 2014 at 01:56:10 AM, Robert Bocchino wrote: > I'm thinking it might be a good idea to start developing a test suite > for grohtml. That would (1) document what grohtml is supposed to do, > including identifying current known bugs, and (2) provide a systematic > way to veri

Re: [Groff] Suggested patch to post-html.cpp

2014-09-21 Thread Robert Bocchino
On Sep 21, 2014, at 2:25 PM, Bertrand Garrigues wrote: > Hi Robert, > > I am not qualified to review your patch because I haven't studied > grohtml's code, but I've tested it on the few .html files that are built > by default in the 'doc' directory from pic.ms and webpage.ms, there are > a few

Re: [Groff] Suggested patch to post-html.cpp

2014-09-21 Thread Bertrand Garrigues
Hi Robert, On Thu, Sep 18 2014 at 05:25:40 AM, Robert Bocchino wrote: > Attached for your review is a suggested patch to post-html.cpp. The > motivation is that grohtml occasionally bungles the formatting of > indented lists. Bug 30043 seems related, although that one is focused > mainly on int

[Groff] Suggested patch to post-html.cpp

2014-09-17 Thread Robert Bocchino
Hi, Attached for your review is a suggested patch to post-html.cpp. The motivation is that grohtml occasionally bungles the formatting of indented lists. Bug 30043 seems related, although that one is focused mainly on interactions with -mdoc. -ms is what I use for my day-to-day formatting.