Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-18 Thread Ralph Corderoy
> +1 > and for C code as well. Please, forget I ever mentioned it. :-) Sorry to the list for the noise. Cheers, Ralph. P.S. K&R got it right. RMS just likes to be contrary. ;-)

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-18 Thread Heinz-Jürgen Oertel
Am Donnerstag 18 April 2013, 13:56:20 schrieb Keith Marshall: > I confess to a personal stylistic preference for > placement of the operator at the start of a continuation line; this is > the style I always prefer in makefiles. +1 and for C code as well. I look at it as this: If this or this

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-18 Thread Ralph Corderoy
Hi Keith, > > > > If you break a line, please start the new line with the operator: > > > > > > > > -test -d "$(DESTDIR)$(bindir)" \ > > > >|| $(mkinstalldirs) "$(DESTDIR)$(bindir)"; > > > > > > (Interesting. I have binary operators at the end of the line as, > > > like a hyphen in

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-18 Thread Keith Marshall
On 18 April 2013 13:00, Werner LEMBERG wrote: > >> If you break a line, please start the new line with the operator: > >> > >> -test -d "$(DESTDIR)$(bindir)" \ > >>|| $(mkinstalldirs) "$(DESTDIR)$(bindir)"; > > > > (Interesting. I have binary operators at the end of the line as, > >

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-18 Thread Werner LEMBERG
>> If you break a line, please start the new line with the operator: >> >> -test -d "$(DESTDIR)$(bindir)" \ >>|| $(mkinstalldirs) "$(DESTDIR)$(bindir)"; > > (Interesting. I have binary operators at the end of the line as, > like a hyphen in text, they indicate there's more to foll

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-18 Thread Ralph Corderoy
Hi, Werner wrote: > Thanks, this is fine now. A minor issue: > > + -test -d "$(DESTDIR)$(bindir)" || \ > + $(mkinstalldirs) "$(DESTDIR)$(bindir)"; > > If you break a line, please start the new line with the operator: > > -test -d "$(DESTDIR)$(bindir)" \ >|| $(mkin

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-16 Thread Werner LEMBERG
> I tried another run. I hope it's now ok. Thanks, this is fine now. A minor issue: + -test -d "$(DESTDIR)$(bindir)" || \ + $(mkinstalldirs) "$(DESTDIR)$(bindir)"; If you break a line, please start the new line with the operator: -test -d "$(DESTDIR)$(bindir)" \

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-16 Thread Bernd Warken
> Von: "Werner LEMBERG" > > this is still not OK. I tried another run. I hope it's now ok. > > RCS file: /cvsroot/groff/groff/INSTALL.gen,v > > retrieving revision 1.7 > > retrieving revision 1.8 > > diff -u -b -r1.7 -r1.8 > > *Never* change this file manually! It is a generic one provided f

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

2013-04-15 Thread Werner LEMBERG
Bernd, this is still not OK. > RCS file: /cvsroot/groff/groff/INSTALL.gen,v > retrieving revision 1.7 > retrieving revision 1.8 > diff -u -b -r1.7 -r1.8 *Never* change this file manually! It is a generic one provided from GNU (normally called `INSTALL'). Please restore it (or get the newest