Re: Why does groff require psutils?

Hi Alexis, At 2023-12-01T17:35:09+0100, Alexis wrote: > following up on my previous email I'd like to test the attached patch > (replace_psselect.patch) with groff, but am uncertain how to trigger > the patched code path. I'm sorry I let this fall onto the floor. Picking it up... > If I read sr

Re: groff now undoing .ad settings after .IP

At 2024-03-15T13:53:42-0500, G. Branden Robinson wrote: > Can you name me a misbehaving perlpod(1)-generated page? I'll check > it out. Perhaps what I really needed here was: Yup. diff --git a/tmac/an.tmac b/tmac/an.tmac index 2b1789741..b4710e23a 100644 --- a/tmac/an.tmac +++ b/tmac/an.tmac @@

Re: groff now undoing .ad settings after .IP

At 2024-03-15T12:29:36-0700, Russ Allbery wrote: > "G. Branden Robinson" writes: > > > Can you name me a misbehaving perlpod(1)-generated page? I'll check > > it out. > > Yeah, pod2man(1) itself will do it on a Debian system with recent > groff. You'll see justification switch from ragged righ

Re: groff now undoing .ad settings after .IP

"G. Branden Robinson" writes: > Can you name me a misbehaving perlpod(1)-generated page? I'll check it > out. Yeah, pod2man(1) itself will do it on a Debian system with recent groff. You'll see justification switch from ragged right to full in the body of the first option documented in OPTIONS.

Re: groff now undoing .ad settings after .IP

At 2024-03-15T10:57:03-0700, Russ Allbery wrote: > Dave Kemper writes: > > It doesn't affect the larger point of this email, but the specific .ad > > call Russ cites (in an-write-paragraph-tag) appears to have been added > > in response to http://savannah.gnu.org/bugs/?62051 . > > Right, the invo

Re: groff now undoing .ad settings after .IP

Dave Kemper writes: > On Fri, Mar 15, 2024 at 8:34 AM G. Branden Robinson > wrote: >> At 2024-03-14T22:02:26-0700, Russ Allbery wrote: >> > Now, any .TP directive restores full justification for all subsequent >> > text. This appears to be due to the addition of: >> > >> > . ad \\*[AD] >> > >>

Re: groff now undoing .ad settings after .IP

On Fri, Mar 15, 2024 at 8:34 AM G. Branden Robinson wrote: > At 2024-03-14T22:02:26-0700, Russ Allbery wrote: > > Now, any .TP directive restores full justification for all subsequent > > text. This appears to be due to the addition of: > > > > . ad \\*[AD] > > > > in an-write-paragraph-tag. I'

[PATCH v3 7/9] [indxbib]: Clear errno before calling strtol(3)

Otherwise, errno may hold ERANGE from before. See strtol(3). Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbi

[PATCH v3 1/9] [libgroff]: Remove redundant checks.

ERANGE can only happen if strtol(3) returns either LONG_MIN or LONG_MAX. Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 d

[PATCH v3 4/9] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Closes: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 5/9] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

And use it where the same logic was being open-coded. While at it, fix the logic, which was incorrect in the open-coded call sites, since for an input of 1, it produced 3, but the first prime is 2. A recent commit started rejecting 1 earlier, so this bug was now impossible to trigger, but remained

[PATCH v3 9/9] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-

[PATCH v3 6/9] [indxbib]: Don't else after [[noreturn]]

Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/utils/indxbib/indxbib.cp

[PATCH v3 8/9] [indxbib]: Remove dead code

The tests (LONG_MAX > INT_MAX && n > INT_MAX) and (n > INT_MAX) are equivalent. Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: Link: Cc: "G. Branden Robinson" Cc: Dave Kempe

[PATCH v3 3/9] src/: Remove redundant checks after strtol(3).

`str == end` can only happen if strtol(3) returns 0. Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp | 4 ++-- src/devices/grolbp/lbp.cpp | 2 +- src/devices/

[PATCH v3 0/9] strtol(3)-related fixes

Hi Branden, Here's a patch set that includes the patches that Dave reminded, the ceil_prime() one, and the fixes for the problems I noticed in your recent commit. I've rebased everything on top of git HEAD. Below is a range-diff. Have a lovely day! Alex Alejandro Colomar (9): [libgroff]: Re

[PATCH v3 2/9] [libgroff]: Remove dead code

strtol(3) can only report ERANGE, if the base is valid (and it is). Link: Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletio