Re: [Groff] [patch] unbreak make install

2014-06-21 Thread Vaibhaw Pandey
Werner, > I was handling the rest, fixing `global' glitches here and there. Since > I'm no longer actively maintaining groff, the glitches become more > visible. We need someone who is going to handle this... Basically > for license issues, Ingo won't do that, which is a pity, but we have > to

Re: [Groff] [patch] unbreak make install

2014-06-21 Thread Werner LEMBERG
> Don't we have a formal unit-test/review cycle around the commits we > make into the code base? Not really. Given the small amount of committers, it wasn't necessary. Bernd is working on his sub-projects within the repository, and this is just fine. The same for Peter and Deri. I was handlin

Re: [Groff] [patch] unbreak make install

2014-06-21 Thread Vaibhaw Pandey
This is probably a good time for me to pop this question which I have had for a while: Don't we have a formal unit-test/review cycle around the commits we make into the code base? Also do we have any test suites around major packages that can quickly sanitize our checkins? Or an automated build and

Re: [Groff] [patch] unbreak make install

2014-06-21 Thread Werner LEMBERG
>> It is certainly nice to see when upstream groff development makes >> progress. However, i would consider it common practice for >> upstream committers to test the build before committing, rather >> than relying on downstream consumers to catch trivial build system >> bugs... > > Ingo's right.

Re: [Groff] [patch] unbreak make install

2014-06-21 Thread Peter Schaffter
On Sat, Jun 21, 2014, Ingo Schwarze wrote: > It is certainly nice to see when upstream groff development makes > progress. However, i would consider it common practice for > upstream committers to test the build before committing, rather > than relying on downstream consumers to catch trivial buil

[Groff] [patch] unbreak make install

2014-06-21 Thread Ingo Schwarze
Hi, currently, when you build a distribution tarball with "make dist", extract that, configure and make, then the "make install" crashes because the tarball lacks two directories that were recently added by Bernd Warken. The patch below fixes the issue. Regarding the background: To be able to c

Re: [Groff] Three topics related to images

2014-06-21 Thread Peter Schaffter
On Sat, Jun 21, 2014, Ralph Corderoy wrote: > mom's PDF_IMAGE macro could remain a float with lots of bells and > whistles to the user but make use of an underlying macro-set-agnostic > macro to do the PDF inclusion as Tadziu suggested; "provide a > bare-bones PDF image includer à la PSPIC instead

Re: [Groff] Three topics related to images

2014-06-21 Thread Ralph Corderoy
Hi Peter, > Of these choices, e) is the preferred default behaviour since, if the > image must be kept on the same page, all five options, including > deferring... > > > ...mean re-writing or re-structuring the text > > whereas if keeping the image on the same page doesn't matter, it's an > adde

Re: [Groff] Three topics related to images

2014-06-21 Thread Peter Schaffter
On Sat, Jun 21, 2014, Ted Harding wrote: > > PDF_IMAGE was originally implemented that way, but over time, the > > advantages of treating images as floats, rather than requiring users > > to insert them into floats (which functionality is fully implemented > > separately, BTW), far outweighed whate

Re: [Groff] Three topics related to images

2014-06-21 Thread Ted Harding
Brief comment (see inloine) On 21-Jun-2014 00:57:26 Peter Schaffter wrote: > On Fri, Jun 20, 2014, Tadziu Hoffmann wrote: >> >> > - provides sensible float handling >> > - can be captioned and labelled >> >> Wouldn't it be useful to split off that functionality into >> a separate float handl