alamb commented on issue #21305:
URL: https://github.com/apache/datafusion/issues/21305#issuecomment-4202864071
I suggest using `git` directly to count contributors if we want to pubish
numbers
--
This is an automated message from the Apache Git Service.
To respond to the message, please
parthchandra merged PR #3884:
URL: https://github.com/apache/datafusion-comet/pull/3884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
parthchandra commented on PR #3884:
URL:
https://github.com/apache/datafusion-comet/pull/3884#issuecomment-4203182004
Merged. Thank you @kazuyukitanimura !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
alamb commented on issue #21450:
URL: https://github.com/apache/datafusion/issues/21450#issuecomment-4202879078
Thanks @ariel-miculas -- I think tince this is a regression we should make
sure it is done before we release 54.0.0 -- I added it to the list on
- https://github.com/apache/da
alamb commented on issue #21446:
URL: https://github.com/apache/datafusion/issues/21446#issuecomment-4202882248
Yes I agree this would be very useful. Thanks @ariel-miculas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
comphead opened a new pull request, #21452:
URL: https://github.com/apache/datafusion/pull/21452
…math modules
(cherry picked from commit 39fb9cca79db1a79e6f8ee01af79df9b59a8ec00)
## Which issue does this PR close?
- Closes #.
## Rationale for this change
comphead commented on issue #21079:
URL: https://github.com/apache/datafusion/issues/21079#issuecomment-4203114599
#20900 was applied before, prob its missing from change log
#21293 backport https://github.com/apache/datafusion/pull/21451
#21043 backport https://github.com/apache/datafu
parthchandra commented on code in PR #3895:
URL: https://github.com/apache/datafusion-comet/pull/3895#discussion_r3048736920
##
spark/src/main/scala/org/apache/comet/iceberg/IcebergReflection.scala:
##
@@ -228,11 +228,18 @@ object IcebergReflection extends Logging {
v
karuppayya commented on PR #3895:
URL:
https://github.com/apache/datafusion-comet/pull/3895#issuecomment-4202778821
cc: @andygrove @mbutrovich @parthchandra
can any of you help review?
Also looks like workflow needs maintainer approval to progress(But remember
that it used to work w
2010YOUY01 commented on PR #20926:
URL: https://github.com/apache/datafusion/pull/20926#issuecomment-4203083163
Great! Thanks everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
2010YOUY01 merged PR #20926:
URL: https://github.com/apache/datafusion/pull/20926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
xiedeyantu commented on PR #21058:
URL: https://github.com/apache/datafusion/pull/21058#issuecomment-4202839556
@neilconway @alamb Thank you for the review! I've made revisions based on
the comments. Please help me take another look.
--
This is an automated message from the Apache Git Ser
comphead opened a new pull request, #21451:
URL: https://github.com/apache/datafusion/pull/21451
…spill files
(cherry picked from commit e133dd3873a8a8ee9c57f977457e89037f992725)
## Which issue does this PR close?
- Closes #.
## Rationale for this change
xudong963 closed issue #21217: Propagate orderings through struct-producing
projections
URL: https://github.com/apache/datafusion/issues/21217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
xudong963 merged PR #21218:
URL: https://github.com/apache/datafusion/pull/21218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
manuzhang opened a new issue, #3906:
URL: https://github.com/apache/datafusion-comet/issues/3906
`cast nested ArrayType to nested ArrayType` test is ignored in #2897 due to
`java.lang.OutOfMemoryError: Java heap space` failure. We need to look into the
root cause, fix it and enable the test
github-actions[bot] commented on PR #163:
URL:
https://github.com/apache/datafusion-sandbox/pull/163#issuecomment-4203363761
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or commen
coderfender commented on issue #1109:
URL: https://github.com/apache/datafusion/issues/1109#issuecomment-4204026539
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
parthchandra commented on code in PR #3884:
URL: https://github.com/apache/datafusion-comet/pull/3884#discussion_r3048389187
##
native/core/src/execution/planner.rs:
##
@@ -406,7 +406,12 @@ impl PhysicalPlanner {
Ok(Arc::new(Cast::new(
child
neilconway commented on code in PR #21058:
URL: https://github.com/apache/datafusion/pull/21058#discussion_r3048457709
##
datafusion/optimizer/src/analyzer/resolve_grouping_function.rs:
##
@@ -184,40 +191,43 @@ fn validate_args(
fn grouping_function_on_id(
function: &Aggre
alamb commented on issue #21307:
URL: https://github.com/apache/datafusion/issues/21307#issuecomment-4202868788
Maybe this is someting that @xudong963 or @jonathanc-n have some insight into
We already have some notion of expression range analysis (that could be
applied ot the problem
adriangbot commented on PR #21429:
URL: https://github.com/apache/datafusion/pull/21429#issuecomment-4204261752
🤖 Criterion benchmark running (GKE) |
[trigger](https://github.com/apache/datafusion/pull/21429#issuecomment-4204210371)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Lin
xudong963 merged PR #21436:
URL: https://github.com/apache/datafusion/pull/21436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
xudong963 commented on PR #21436:
URL: https://github.com/apache/datafusion/pull/21436#issuecomment-4204269212
Thanks @alamb @kosiew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
coderfender opened a new pull request, #21453:
URL: https://github.com/apache/datafusion/pull/21453
## Which issue does this PR close?
- Closes #https://github.com/apache/datafusion/issues/1109
## Rationale for this change
## What changes are included in
coderfender commented on PR #21453:
URL: https://github.com/apache/datafusion/pull/21453#issuecomment-4204329180
```┌──┬─┬──┐
│ Type │ Change│ Verdict│
├──┼─┼──┤
│ u8 │ +20% slower │Regressed │
├
adriangbot commented on PR #21429:
URL: https://github.com/apache/datafusion/pull/21429#issuecomment-4204351725
🤖 Criterion benchmark completed (GKE) |
[trigger](https://github.com/apache/datafusion/pull/21429#issuecomment-4204210371)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
neilconway commented on PR #21363:
URL: https://github.com/apache/datafusion/pull/21363#issuecomment-4202849692
@crm26 Thanks for iterating on this!
The comment I was suggesting you add "Optimization:" to was actually a
different one :) My suggestion was attached to the "// Skip if no
comphead commented on issue #3817:
URL:
https://github.com/apache/datafusion-comet/issues/3817#issuecomment-4203253669
The workaround is to play `spark.sql.files.maxPartitionBytes` to 64M which
is half of default value.
Fewer this setting the fewer the difference between Spark/Comet numb
coderfender commented on issue #21116:
URL: https://github.com/apache/datafusion/issues/21116#issuecomment-4204145346
Ill take a stab at it soetime unless you are @LiaCastaneda ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
coderfender commented on issue #21116:
URL: https://github.com/apache/datafusion/issues/21116#issuecomment-4204143561
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Dandandan merged PR #20545:
URL: https://github.com/apache/datafusion/pull/20545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
Dandandan closed issue #18816: Bug: unnecessary columns projected and redundant
filters pushed down
URL: https://github.com/apache/datafusion/issues/18816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Dandandan commented on issue #21450:
URL: https://github.com/apache/datafusion/issues/21450#issuecomment-4204172933
This was _after_ https://github.com/apache/datafusion/pull/20823 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
stuhood commented on issue #21207:
URL: https://github.com/apache/datafusion/issues/21207#issuecomment-4204179190
> These are some diagrams which expla
@jayshrivastava : Can you post these?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
Dandandan commented on PR #21429:
URL: https://github.com/apache/datafusion/pull/21429#issuecomment-4204210371
run benchmark with_hashes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Dandandan commented on PR #21429:
URL: https://github.com/apache/datafusion/pull/21429#issuecomment-4204215638
```
large_utf8: single, no nulls 1.00 26.5±0.09µs?
?/sec1.37 36.2±0.41µs? ?/sec
sparse_union: multiple, no nulls 1.00
alamb commented on code in PR #20823:
URL: https://github.com/apache/datafusion/pull/20823#discussion_r3046452282
##
datafusion/core/tests/datasource/object_store_access.rs:
##
@@ -397,6 +400,348 @@ async fn query_partitioned_csv_file() {
);
}
+// ===
alamb merged PR #20823:
URL: https://github.com/apache/datafusion/pull/20823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on issue #21078:
URL: https://github.com/apache/datafusion/issues/21078#issuecomment-4202230070
I made an RC and started a vote:
https://lists.apache.org/thread/scnnmsw6g200ckjj1rgx58oj9q6xzb2h
--
This is an automated message from the Apache Git Service.
To respond to
alamb opened a new pull request, #21449:
URL: https://github.com/apache/datafusion/pull/21449
## Which issue does this PR close?
- Related to https://github.com/apache/datafusion/issues/19692
## Rationale for this change
@rluvaton noted some issues with the 53 upgrade gu
mbutrovich merged PR #3629:
URL: https://github.com/apache/datafusion-comet/pull/3629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
mbutrovich closed issue #3574: chore: DataFusion 53.0.0
URL: https://github.com/apache/datafusion-comet/issues/3574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
neilconway commented on code in PR #21366:
URL: https://github.com/apache/datafusion/pull/21366#discussion_r3046323361
##
datafusion/functions/src/unicode/substr.rs:
##
@@ -326,17 +325,111 @@ fn string_view_substr(
}
}
-fn string_substr<'a, V>(string_array: V, args: &[Ar
townsag commented on issue #21384:
URL: https://github.com/apache/datafusion/issues/21384#issuecomment-4201906146
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
alamb commented on PR #21383:
URL: https://github.com/apache/datafusion/pull/21383#issuecomment-4201927185
Looks like there is some (reproducable) slow down on some of the null cases:
```
group main
adriangbot commented on PR #21075:
URL: https://github.com/apache/datafusion/pull/21075#issuecomment-4200525894
🤖 Benchmark running (GKE) |
[trigger](https://github.com/apache/datafusion/pull/21075#issuecomment-4200500846)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux
bench-
alamb commented on issue #21079:
URL: https://github.com/apache/datafusion/issues/21079#issuecomment-4201932257
Thanks @comphead -- We should also make sure that anything backported into
52.5.0 is ported to branch-53. I will do that review tomorrow and make any
additional backports needed
alamb merged PR #21439:
URL: https://github.com/apache/datafusion/pull/21439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #21439:
URL: https://github.com/apache/datafusion/pull/21439#issuecomment-4201934829
Ok, I'll merge this one in and make a RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on PR #21439:
URL: https://github.com/apache/datafusion/pull/21439#issuecomment-4201935202
Thanks @timsaucer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
comphead commented on code in PR #3629:
URL: https://github.com/apache/datafusion-comet/pull/3629#discussion_r3046115551
##
native/core/src/execution/jni_api.rs:
##
@@ -393,6 +393,11 @@ fn prepare_datafusion_session_context(
// register UDFs from datafusion-spark crate
fn re
neilconway commented on code in PR #21405:
URL: https://github.com/apache/datafusion/pull/21405#discussion_r3045972591
##
datafusion/functions/src/unicode/rpad.rs:
##
@@ -492,16 +484,15 @@ where
builder.append_value("");
}
JeelRajodiya commented on PR #21331:
URL: https://github.com/apache/datafusion/pull/21331#issuecomment-4200339441
Hey @xanderbailey, Do I need to mention the maintainers for review?
I'm planning to open more PRs for implementing other functions but I'm
waiting for this to get merged.
neilconway commented on code in PR #21420:
URL: https://github.com/apache/datafusion/pull/21420#discussion_r3046987125
##
datafusion/sqllogictest/test_files/string/string_view.slt:
##
@@ -954,6 +954,71 @@ SELECT arrow_typeof(split_part(arrow_cast('a.b.c',
'Utf8View'), '.', 2));
alamb commented on PR #21439:
URL: https://github.com/apache/datafusion/pull/21439#issuecomment-4201222097
@timsaucer is this one ready to review / merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb commented on PR #21327:
URL: https://github.com/apache/datafusion/pull/21327#issuecomment-4200253734
> In case it's helpful my attempt (disclaimer Codex assisted, late last
night) was #21427 / [alamb#36](https://github.com/alamb/datafusion/pull/36).
>
> One observation is that I
erenavsarogullari commented on issue #21447:
URL: https://github.com/apache/datafusion/issues/21447#issuecomment-4201610311
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb commented on issue #19692:
URL: https://github.com/apache/datafusion/issues/19692#issuecomment-4202286690
> FYI, the migration guide says 53.0.0 was not released yet and it miss the
following breaking changes:
I made a PR to fix this:
- https://github.com/apache/datafusion/pu
theirix commented on PR #21383:
URL: https://github.com/apache/datafusion/pull/21383#issuecomment-4202330345
> Looks like there is some (reproducable) slow down on some of the null
cases:
>
> ```
> group main
comphead commented on PR #3858:
URL:
https://github.com/apache/datafusion-comet/pull/3858#issuecomment-4202337476
Closed in favor of #3893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
comphead closed pull request #3858: chore: fix native shuffle for batches with
no columns and 0 row count
URL: https://github.com/apache/datafusion-comet/pull/3858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
comphead merged PR #3842:
URL: https://github.com/apache/datafusion-comet/pull/3842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
comphead closed issue #3735: `native_datafusion` doesn't report input metrics
URL: https://github.com/apache/datafusion-comet/issues/3735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
timsaucer commented on PR #1472:
URL:
https://github.com/apache/datafusion-python/pull/1472#issuecomment-4201194397
> Related to #1340 This doesn't cover `find_qualified_cols` from
[apache/datafusion#19549](https://github.com/apache/datafusion/pull/19549)
(which should probably have a nice
neilconway commented on PR #21420:
URL: https://github.com/apache/datafusion/pull/21420#issuecomment-4201221754
> It might be worth adding unit tests for sliced StringViewArray inputs
(non-zero offset) and results landing exactly at the 12-byte inline/out-of-line
boundary. These are the two
alamb commented on PR #21331:
URL: https://github.com/apache/datafusion/pull/21331#issuecomment-4201235790
Thanks @xanderbailey and @JeelRajodiya -- the PR load is pretty intense! I
started the CI for this PR
--
This is an automated message from the Apache Git Service.
To respond to the
CuteChuanChuan commented on issue #21419:
URL: https://github.com/apache/datafusion/issues/21419#issuecomment-4200372756
Hi @ariel-miculas , could I give this a try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
asolimando commented on code in PR #21122:
URL: https://github.com/apache/datafusion/pull/21122#discussion_r3046225207
##
datafusion/core/src/physical_planner.rs:
##
@@ -2898,7 +2920,11 @@ impl DefaultPhysicalPlanner {
.into_iter()
.map(
alamb commented on PR #21099:
URL: https://github.com/apache/datafusion/pull/21099#issuecomment-4202060281
I kicked off the CI tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb commented on PR #21236:
URL: https://github.com/apache/datafusion/pull/21236#issuecomment-4202049546
> @alamb @xudong963 I see that the test results are now available. I'm not
entirely sure how to interpret them, but based on a rough comparison with the
baseline branch, it appears the
neilconway commented on code in PR #21405:
URL: https://github.com/apache/datafusion/pull/21405#discussion_r3046248943
##
datafusion/functions/src/unicode/lpad.rs:
##
@@ -270,22 +269,19 @@ fn lpad_scalar_unicode<'a, V: StringArrayType<'a> + Copy,
T: OffsetSizeTrait>(
let d
0lai0 commented on code in PR #3804:
URL: https://github.com/apache/datafusion-comet/pull/3804#discussion_r3047127823
##
native/spark-expr/src/datetime_funcs/hours.rs:
##
@@ -0,0 +1,299 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
neilconway commented on code in PR #21366:
URL: https://github.com/apache/datafusion/pull/21366#discussion_r3046188974
##
datafusion/functions/src/unicode/substr.rs:
##
@@ -326,17 +325,111 @@ fn string_view_substr(
}
}
-fn string_substr<'a, V>(string_array: V, args: &[Ar
comphead commented on PR #21075:
URL: https://github.com/apache/datafusion/pull/21075#issuecomment-4200497020
run benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
0lai0 commented on code in PR #3804:
URL: https://github.com/apache/datafusion-comet/pull/3804#discussion_r3047127823
##
native/spark-expr/src/datetime_funcs/hours.rs:
##
@@ -0,0 +1,299 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
xiedeyantu commented on PR #21236:
URL: https://github.com/apache/datafusion/pull/21236#issuecomment-4202582656
> I think we need to avoid performance regressions before merging this
Of course! I’ll think about other possible ways to fix this issue. Thanks
for your expert feedback.
ariel-miculas commented on issue #21450:
URL: https://github.com/apache/datafusion/issues/21450#issuecomment-4202614703
It would be nice to have this first:
https://github.com/apache/datafusion/issues/21446
--
This is an automated message from the Apache Git Service.
To respond to the mes
ariel-miculas commented on PR #20823:
URL: https://github.com/apache/datafusion/pull/20823#issuecomment-4202604980
I ran some tests with clickbench, reading from local files is worse:
```
[ec2-user@ip-172-31-0-185 datafusion]$ ./benchmarks/bench.sh compare
json-test-on-main test-json-i
ariel-miculas opened a new issue, #21450:
URL: https://github.com/apache/datafusion/issues/21450
I ran some tests with clickbench, reading from local files is worse:
```
[ec2-user@ip-172-31-0-185 datafusion]$ ./benchmarks/bench.sh compare
json-test-on-main test-json-improvement
Comp
crm26 commented on PR #21363:
URL: https://github.com/apache/datafusion/pull/21363#issuecomment-4202658920
Found and fixed the CI failure, pushed as 92884480a.
The `cargo test (amd64)` / `(macos-aarch64)` failures came from a stale
negative test in `predicates.slt:845` that asserted `
adriangbot commented on PR #21383:
URL: https://github.com/apache/datafusion/pull/21383#issuecomment-420013
🤖 Criterion benchmark running (GKE) |
[trigger](https://github.com/apache/datafusion/pull/21383#issuecomment-4200118375)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Lin
alamb commented on code in PR #21355:
URL: https://github.com/apache/datafusion/pull/21355#discussion_r3046068833
##
datafusion/sqllogictest/test_files/set_variable.slt:
##
@@ -379,6 +379,204 @@ RESET datafusion.execution.batches_size
statement error DataFusion error: Invalid o
alamb commented on PR #21407:
URL: https://github.com/apache/datafusion/pull/21407#issuecomment-4201996373
I merged up and updated the changelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on issue #21078:
URL: https://github.com/apache/datafusion/issues/21078#issuecomment-4202007656
Ok, we have the content in.
I updated the version bump / changelog
- https://github.com/apache/datafusion/pull/21407
Once that is good I'll move on to making a r
comphead commented on PR #3842:
URL:
https://github.com/apache/datafusion-comet/pull/3842#issuecomment-4202341483
Thanks @mbutrovich for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
yonatan-sevenai commented on PR #21099:
URL: https://github.com/apache/datafusion/pull/21099#issuecomment-4202190009
> I kicked off the CI tests
Merged in Master to make merge easier, but you might need to rerun CI.
--
This is an automated message from the Apache Git Service.
To re
alamb closed issue #21354: Add `datafusion.format.*` configs test coverage
URL: https://github.com/apache/datafusion/issues/21354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
neilconway commented on code in PR #21363:
URL: https://github.com/apache/datafusion/pull/21363#discussion_r3047256748
##
datafusion/optimizer/src/decorrelate_predicate_subquery.rs:
##
@@ -69,53 +70,113 @@ impl OptimizerRule for DecorrelatePredicateSubquery {
})?
alamb commented on PR #21260:
URL: https://github.com/apache/datafusion/pull/21260#issuecomment-4201251616
> Good news on step 3 — the Omega359 fork features were already upstreamed
to risinglightdb/sqllogictest-rs in v0.24.0 ([PR
#237](https://github.com/risinglightdb/sqllogictest-rs/pull/
alamb commented on PR #136:
URL: https://github.com/apache/datafusion-site/pull/136#issuecomment-4201243286
Oh no, I just got this ping. Are you still interested in working on this PR
@ethan-tyler ? If so I will review it. I am sorry that i lost track of it
--
This is an automated message
adriangbot commented on PR #21383:
URL: https://github.com/apache/datafusion/pull/21383#issuecomment-4200252248
🤖 Criterion benchmark completed (GKE) |
[trigger](https://github.com/apache/datafusion/pull/21383#issuecomment-4200118375)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
comphead commented on code in PR #3629:
URL: https://github.com/apache/datafusion-comet/pull/3629#discussion_r3046143486
##
native/core/src/parquet/schema_adapter.rs:
##
@@ -314,19 +328,40 @@ impl SparkPhysicalExprAdapter {
.find(|f| f.name().eq_ignore_a
crm26 commented on PR #21363:
URL: https://github.com/apache/datafusion/pull/21363#issuecomment-4201754197
Thanks for the thorough review, @neilconway! Addressed all three points in
the latest push (commit 12a12bcd1):
1. **Optimization: prefix** — Added to the alias preservation comme
alamb commented on PR #21415:
URL: https://github.com/apache/datafusion/pull/21415#issuecomment-4199079517
Thank you @xudong963 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
adriangb commented on PR #21182:
URL: https://github.com/apache/datafusion/pull/21182#issuecomment-4199080230
certainly worthy of a blog post!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb merged PR #21415:
URL: https://github.com/apache/datafusion/pull/21415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #21407:
URL: https://github.com/apache/datafusion/pull/21407#issuecomment-4199077554
Thanks @xudong963 -- I will wait for all the rest of the content to get
into branch-52 and then refresh the changelog and merge this PR
--
This is an automated message from the Apac
martin-g commented on PR #21387:
URL: https://github.com/apache/datafusion/pull/21387#issuecomment-4199118424
> "use arrow_field(...)['nullable']"
I like it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
adriangb commented on PR #21372:
URL: https://github.com/apache/datafusion/pull/21372#issuecomment-4199116661
This makes a lot of sense to me. We have a hacky version of this internally,
it's especially effective for filters/queries like `ts > '2026-04-05T00:15:00Z'
where many files will ha
1 - 100 of 276 matches
Mail list logo
