killzoner commented on PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#issuecomment-3919387995
> thanks @killzoner just minor comments about tests, otherwise it looks good
Thank you ! I guess there is only
https://github.com/apache/datafusion-ballista/pull/1420
milenkovicm commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3919389759
@mattcuento @killzoner @danielhumanmod any chance for a review? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Dandandan commented on PR #20417:
URL: https://github.com/apache/datafusion/pull/20417#issuecomment-3919405696
show benchmark queue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
milenkovicm commented on PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#issuecomment-3919405378
> > thanks @killzoner just minor comments about tests, otherwise it looks
good
>
> Thank you ! I guess there is only [#1420
(comment)](https://github.com/apache/da
alamb-ghbot commented on PR #20417:
URL: https://github.com/apache/datafusion/pull/20417#issuecomment-3919405819
🤖 Hi @Dandandan, you asked to view the benchmark queue
(https://github.com/apache/datafusion/pull/20417#issuecomment-3919405696).
| Job | User | Benchmarks | Comment |
|
killzoner commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3919468322
Quick search show default still on this file though :
https://github.com/killzoner/datafusion-ballista/blob/issue-1395/ballista/scheduler/scheduler_config_spec.toml#L63
--
killzoner commented on code in PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#discussion_r2820961020
##
ballista/client/tests/context_unsupported.rs:
##
@@ -143,4 +149,52 @@ mod unsupported {
Ok(())
}
+
+#[rstest]
+#[case::standal
killzoner commented on code in PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#discussion_r2820965372
##
ballista/client/tests/context_unsupported.rs:
##
@@ -143,4 +149,52 @@ mod unsupported {
Ok(())
}
+
+#[rstest]
+#[case::standal
milenkovicm opened a new pull request, #1461:
URL: https://github.com/apache/datafusion-ballista/pull/1461
# Which issue does this PR close?
Closes #.
# Rationale for this change
Pull based scheduling strategy has been use as default since version 43,
without any va
killzoner commented on code in PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#discussion_r2821158685
##
ballista/core/src/serde/mod.rs:
##
@@ -186,17 +191,63 @@ impl LogicalExtensionCodec for
BallistaLogicalExtensionCodec {
&self,
buf:
killzoner commented on code in PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#discussion_r2821161537
##
ballista/core/src/serde/mod.rs:
##
@@ -186,17 +191,63 @@ impl LogicalExtensionCodec for
BallistaLogicalExtensionCodec {
&self,
buf:
rluvaton commented on issue #19615:
URL: https://github.com/apache/datafusion/issues/19615#issuecomment-3919551819
Is it similar to this?
https://github.com/apache/datafusion/issues/16904#issuecomment-3193805380
--
This is an automated message from the Apache Git Service.
To respond to
coderfender commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2823407820
##
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##
@@ -332,6 +332,38 @@ abstract class CometTestBase
}
}
+// inspired from spa
milenkovicm commented on PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#issuecomment-3921982197
> Woohoo! Nice work @milenkovicm. At a high level this all makes sense,
acknowledging the TODOs.
>
> Some notes of my own for mile-high level understanding:
>
danielhumanmod commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#discussion_r2823453244
##
ballista/scheduler/src/state/aqe/optimizer_rule/datafusion_patch.rs:
##
@@ -0,0 +1,163 @@
+// Licensed to the Apache Software Foundation (ASF) un
mbutrovich commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2823463388
##
dev/diffs/3.5.8.diff:
##
@@ -2795,7 +2795,7 @@ index d675503a8ba..f220892396e 100644
+ }
Review Comment:
I think this file just has a whitespac
milenkovicm commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#discussion_r2823470023
##
ballista/scheduler/src/state/aqe/optimizer_rule/datafusion_patch.rs:
##
@@ -0,0 +1,163 @@
+// Licensed to the Apache Software Foundation (ASF) under
neilconway commented on code in PR #20305:
URL: https://github.com/apache/datafusion/pull/20305#discussion_r2823034152
##
datafusion/functions/src/unicode/translate.rs:
##
@@ -46,10 +46,10 @@ use datafusion_macros::user_doc;
+--+
neilconway commented on code in PR #20361:
URL: https://github.com/apache/datafusion/pull/20361#discussion_r2823138113
##
datafusion/functions/src/string/concat_ws.rs:
##
@@ -162,23 +156,55 @@ impl ScalarUDFImpl for ConcatWsFunc {
// parse sep
let sep = match
danielhumanmod commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#discussion_r2823541555
##
ballista/scheduler/src/state/aqe/optimizer_rule/distributed_exchange.rs:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF
milenkovicm commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#discussion_r2823556576
##
ballista/scheduler/src/state/aqe/optimizer_rule/distributed_exchange.rs:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) u
comphead commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2823286441
##
native/core/src/execution/operators/iceberg_scan.rs:
##
@@ -221,15 +218,12 @@ impl IcebergScanMetrics {
/// Wrapper around iceberg-rust's stream that pe
vinaygjain commented on issue #20324:
URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3921863658
I am on branch-52 and just benchmarked Q40 and see a speed-up of 35% (20 ms
without VS 13 ms with)
**SET datafusion.execution.parquet.pushdown_filters = false;**
notashes closed pull request #20332: perf: exclude aggregate dynamic filters
from parquet row-level evaluation
URL: https://github.com/apache/datafusion/pull/20332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Shekharrajak commented on code in PR #20358:
URL: https://github.com/apache/datafusion/pull/20358#discussion_r2823188990
##
datafusion/sqllogictest/test_files/spark/collection/size.slt:
##
@@ -60,12 +60,12 @@ SELECT size(arrow_cast(make_array(1, 2, 3, 4),
'FixedSizeList(4, Int3
timsaucer merged PR #1382:
URL: https://github.com/apache/datafusion-python/pull/1382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
timsaucer commented on PR #1382:
URL:
https://github.com/apache/datafusion-python/pull/1382#issuecomment-3921870439
Nice work! Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
hareshkh commented on code in PR #20422:
URL: https://github.com/apache/datafusion/pull/20422#discussion_r2823323861
##
datafusion/execution/src/memory_pool/mod.rs:
##
@@ -387,7 +387,9 @@ impl MemoryReservation {
atomic::Ordering::Relaxed,
|prev
timsaucer commented on PR #1347:
URL:
https://github.com/apache/datafusion-python/pull/1347#issuecomment-3921628046
Thank you for all the work on this @kosiew ! I think the final solution is
very nice. We couldn't have gotten here so quickly without your work.
--
This is an automated mes
neilconway commented on issue #15161:
URL: https://github.com/apache/datafusion/issues/15161#issuecomment-3922429717
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
coderfender commented on PR #3541:
URL:
https://github.com/apache/datafusion-comet/pull/3541#issuecomment-3922495630
Thank you for merging main and the suggestions re testing long to timestamp
@andygrove , @mbutrovich
--
This is an automated message from the Apache Git Service.
To resp
killzoner commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3920366464
The push policy is not supported in standalone executor, I am looking at
backporting this
--
This is an automated message from the Apache Git Service.
To respond to the m
milenkovicm commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3920411176
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
LiaCastaneda commented on code in PR #19856:
URL: https://github.com/apache/datafusion/pull/19856#discussion_r2821386586
##
datafusion/substrait/src/logical_plan/consumer/utils.rs:
##
@@ -396,10 +433,25 @@ impl NameTracker {
&mut self,
expr: Expr,
) -> dat
killzoner commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3919942944
> https://deepwiki.com/apache/datafusion-ballista does not look bad, some
diagrams make a lot of sense
>
>
https://deepwiki.com/search/pull-based-vs-push-based_d01ad
tobixdev commented on code in PR #20312:
URL: https://github.com/apache/datafusion/pull/20312#discussion_r2803054679
##
datafusion/common/src/types/extension.rs:
##
@@ -0,0 +1,71 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
cj-zhukov commented on PR #20421:
URL: https://github.com/apache/datafusion/pull/20421#issuecomment-3920591723
### High-level overview
This PR fixes incorrect handling of ordered-set aggregate syntax.
Specifically:
- Updated `datafusion/sql/src/expr/function.rs` to return a plann
martin-g commented on code in PR #20317:
URL: https://github.com/apache/datafusion/pull/20317#discussion_r2822792245
##
datafusion/functions/src/string/concat.rs:
##
@@ -207,7 +207,7 @@ impl ScalarUDFImpl for ConcatFunc {
DataType::Utf8View => {
mbutrovich merged PR #3433:
URL: https://github.com/apache/datafusion-comet/pull/3433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
Jefffrey commented on code in PR #20305:
URL: https://github.com/apache/datafusion/pull/20305#discussion_r2822774611
##
datafusion/functions/src/unicode/translate.rs:
##
@@ -99,6 +100,65 @@ impl ScalarUDFImpl for TranslateFunc {
&self,
args: datafusion_expr::Sc
Abhinandankaushik commented on issue #150:
URL:
https://github.com/apache/datafusion-site/issues/150#issuecomment-3921352808
hey @Jefffrey shall i have to close this issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
notashes commented on code in PR #20413:
URL: https://github.com/apache/datafusion/pull/20413#discussion_r2822834340
##
datafusion/datasource-parquet/src/opener.rs:
##
@@ -459,27 +465,55 @@ impl FileOpener for ParquetOpener {
// `row_filter` for details.
notashes closed pull request #20413: perf: defer expensive string predicates
from `RowFilter` when dynamic filter is present
URL: https://github.com/apache/datafusion/pull/20413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
notashes commented on PR #20413:
URL: https://github.com/apache/datafusion/pull/20413#issuecomment-3921380779
closed in favour of #20417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
Jefffrey commented on issue #150:
URL:
https://github.com/apache/datafusion-site/issues/150#issuecomment-3921393608
Thanks for the suggestion, but I don't think theres too much value to be had
here
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
Jefffrey closed issue #150: feat: Add automation to manage stale issues and PRs
URL: https://github.com/apache/datafusion-site/issues/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
milenkovicm commented on PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#issuecomment-3922342451
> LGTM, thanks for building the skeleton and leaving the TODOs for future
contributions.
>
> For better understanding, I've summarized my understanding of the AQE
milenkovicm commented on PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#issuecomment-3922375193
I'd recommend reading if you're interested
https://www.cs.cmu.edu/~15721-f24/papers/AQP_in_Lakehouse.pdf
--
This is an automated message from the Apache Git Service.
neilconway commented on PR #20423:
URL: https://github.com/apache/datafusion/pull/20423#issuecomment-3922245690
cc @Jefffrey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
neilconway opened a new pull request, #20423:
URL: https://github.com/apache/datafusion/pull/20423
Cleanup a few places where the code returned a null array but it would be a
bit cleaner and faster to return a typed scalar null instead.
## Which issue does this PR close?
Does n
alamb-ghbot commented on PR #20417:
URL: https://github.com/apache/datafusion/pull/20417#issuecomment-3922312196
🤖 Hi @darmie, thanks for the request
(https://github.com/apache/datafusion/pull/20417#issuecomment-3922311434).
[`scrape_comments.py`](https://github.com/alamb/datafusion-benchma
darmie commented on PR #20417:
URL: https://github.com/apache/datafusion/pull/20417#issuecomment-3922311434
run benchmark clickbench_partitioned
DATAFUSION_EXECUTION_PARQUET_PUSHDOWN_FILTERS=true
DATAFUSION_EXECUTION_PARQUET_REORDER_FILTERS=true
--
This is an automated message from t
timsaucer opened a new pull request, #1383:
URL: https://github.com/apache/datafusion-python/pull/1383
This is simply a `cargo update` command.
I did a drive by removal of steps that should no longer be required for CI
during testing now that all of the building happens in a different
gene-bordegaray commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2823786180
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -450,6 +531,25 @@ impl PhysicalExpr for DynamicFilterPhysicalExpr {
}
}
+///
timsaucer merged PR #1383:
URL: https://github.com/apache/datafusion-python/pull/1383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
dependabot[bot] commented on PR #1380:
URL:
https://github.com/apache/datafusion-python/pull/1380#issuecomment-3922432287
Looks like uuid is up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
dependabot[bot] commented on PR #1373:
URL:
https://github.com/apache/datafusion-python/pull/1373#issuecomment-3922432292
Looks like arrow-select is up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dependabot[bot] closed pull request #1380: build(deps): bump uuid from 1.20.0
to 1.21.0
URL: https://github.com/apache/datafusion-python/pull/1380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
neilconway commented on issue #15161:
URL: https://github.com/apache/datafusion/issues/15161#issuecomment-3922429375
@AlonSpivack Thanks for flagging this! I'm sorry that this resulted in
incorrect query results in production for you.
At a high-level, I agree with your analysis, and a
dependabot[bot] closed pull request #1373: build(deps): bump arrow-select from
57.2.0 to 57.3.0
URL: https://github.com/apache/datafusion-python/pull/1373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] commented on PR #1374:
URL:
https://github.com/apache/datafusion-python/pull/1374#issuecomment-3922432577
Looks like arrow is up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dependabot[bot] closed pull request #1374: build(deps): bump arrow from 57.2.0
to 57.3.0
URL: https://github.com/apache/datafusion-python/pull/1374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
xitep commented on code in PR #2214:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2214#discussion_r2821592152
##
src/parser/mod.rs:
##
@@ -4543,7 +4543,13 @@ impl<'a> Parser<'a> {
///
/// Returns true if the current token matches the expected keyword.
killzoner commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#discussion_r2824080937
##
ballista/scheduler/src/state/aqe/optimizer_rule/datafusion_patch.rs:
##
@@ -0,0 +1,163 @@
+// Licensed to the Apache Software Foundation (ASF) under o
milenkovicm commented on code in PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#discussion_r2821205020
##
ballista/core/src/serde/mod.rs:
##
@@ -186,17 +191,63 @@ impl LogicalExtensionCodec for
BallistaLogicalExtensionCodec {
&self,
bu
Dandandan commented on PR #20417:
URL: https://github.com/apache/datafusion/pull/20417#issuecomment-3921232137
@alamb looks like the runner isn't working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Dandandan commented on code in PR #20413:
URL: https://github.com/apache/datafusion/pull/20413#discussion_r2822745501
##
datafusion/datasource-parquet/src/opener.rs:
##
@@ -459,27 +465,55 @@ impl FileOpener for ParquetOpener {
// `row_filter` for details.
milenkovicm commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3921569620
> Results look great! Good call on the standalone.
>
> Separately, curious if either of you have played with tuning the loop
interval for pull-based? I see this con
vkverma9534 commented on PR #20148:
URL: https://github.com/apache/datafusion/pull/20148#issuecomment-3921644926
@Jefffrey Thanks for the consideration
you’re right to be skeptical here this was initially llm assisted, and on a
closer look my original suspicion doesn’t hold up the way
Shekharrajak commented on PR #3530:
URL:
https://github.com/apache/datafusion-comet/pull/3530#issuecomment-3921649071
@coderfender, Please have a look. I think this code changes will resolve
multiple issues of writer.
--
This is an automated message from the Apache Git Service.
To resp
timsaucer closed issue #1339: Cannot do udaf that returns list of timestamps
URL: https://github.com/apache/datafusion-python/issues/1339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
timsaucer merged PR #1347:
URL: https://github.com/apache/datafusion-python/pull/1347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
Mark1626 commented on issue #5619:
URL: https://github.com/apache/datafusion/issues/5619#issuecomment-3921668952
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Mark1626 commented on issue #5619:
URL: https://github.com/apache/datafusion/issues/5619#issuecomment-3921674034
The old PR for count distinct is stale and outdated (the code of COUNT seems
to have been refactored a lot). I'll be re-implementing it
--
This is an automated message from the
ishanema03 commented on issue #17375:
URL: https://github.com/apache/datafusion/issues/17375#issuecomment-3921673344
Hi @findepi
I have raised a PR for this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Jefffrey commented on code in PR #20361:
URL: https://github.com/apache/datafusion/pull/20361#discussion_r2822331972
##
datafusion/functions/src/string/concat_ws.rs:
##
@@ -162,23 +156,55 @@ impl ScalarUDFImpl for ConcatWsFunc {
// parse sep
let sep = match &
milenkovicm closed issue #1395: bug: Disable `DataFrame.cache()` for ballista
URL: https://github.com/apache/datafusion-ballista/issues/1395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
milenkovicm merged PR #1420:
URL: https://github.com/apache/datafusion-ballista/pull/1420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
milenkovicm merged PR #1462:
URL: https://github.com/apache/datafusion-ballista/pull/1462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
milenkovicm commented on PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#issuecomment-3920846943
merging this, thanks @killzoner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
neilconway commented on PR #20385:
URL: https://github.com/apache/datafusion/pull/20385#issuecomment-3921060646
Note that the commit fixing up the benchmarks is shared with #20374 -- I can
also pull that out into a separate PR, because it's a prerequisite for any
performance work on these f
Jefffrey commented on code in PR #20354:
URL: https://github.com/apache/datafusion/pull/20354#discussion_r2822558042
##
datafusion/functions/src/regex/regexplike.rs:
##
@@ -131,28 +132,39 @@ impl ScalarUDFImpl for RegexpLikeFunc {
) -> Result {
let args = &args.arg
neilconway commented on code in PR #20317:
URL: https://github.com/apache/datafusion/pull/20317#discussion_r2822606960
##
datafusion/functions/src/string/concat.rs:
##
@@ -207,7 +207,7 @@ impl ScalarUDFImpl for ConcatFunc {
DataType::Utf8View => {
getChan commented on code in PR #20422:
URL: https://github.com/apache/datafusion/pull/20422#discussion_r2822568251
##
datafusion/execution/src/memory_pool/mod.rs:
##
@@ -387,7 +387,9 @@ impl MemoryReservation {
atomic::Ordering::Relaxed,
|prev|
killzoner commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#discussion_r2824106510
##
ballista/scheduler/src/state/aqe/optimizer_rule/distributed_exchange.rs:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) und
rluvaton commented on code in PR #20308:
URL: https://github.com/apache/datafusion/pull/20308#discussion_r2824158713
##
datafusion/functions/src/regex/mod.rs:
##
@@ -65,6 +67,19 @@ pub mod expr_fn {
super::regexp_match().call(args)
}
+/// Extracts a group tha
rluvaton commented on code in PR #20308:
URL: https://github.com/apache/datafusion/pull/20308#discussion_r2824164646
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,551 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
rluvaton commented on code in PR #20308:
URL: https://github.com/apache/datafusion/pull/20308#discussion_r2824158713
##
datafusion/functions/src/regex/mod.rs:
##
@@ -65,6 +67,19 @@ pub mod expr_fn {
super::regexp_match().call(args)
}
+/// Extracts a group tha
milenkovicm commented on code in PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#discussion_r2824191028
##
ballista/scheduler/src/state/aqe/optimizer_rule/distributed_exchange.rs:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) u
milenkovicm commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3919607092
> https://private-user-images.githubusercontent.com/3322938/551420965-8acd63cd-bb2d-4733-83e6-dd2a2a8319be.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIu
milenkovicm commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3919608665
> Quick search shows old default still on this file though :
https://github.com/killzoner/datafusion-ballista/blob/issue-1395/ballista/scheduler/scheduler_config_spec.toml
milenkovicm commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3919652532
I believe sleep at
https://github.com/milenkovicm/datafusion-ballista/blob/0e1bcd278e58ad81f98dcb5cec8df8628331b54a/ballista/executor/src/execution_loop.rs#L205-L206
does
iffyio commented on code in PR #2210:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2210#discussion_r2821252792
##
tests/sqlparser_mssql.rs:
##
@@ -1702,6 +1702,43 @@ fn test_parse_throw() {
);
}
+#[test]
+fn test_parse_waitfor() {
+// WAITFOR DELAY
+
killzoner commented on code in PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#discussion_r2821295163
##
ballista/core/src/serde/mod.rs:
##
@@ -186,17 +191,63 @@ impl LogicalExtensionCodec for
BallistaLogicalExtensionCodec {
&self,
buf:
milenkovicm opened a new pull request, #1462:
URL: https://github.com/apache/datafusion-ballista/pull/1462
# Which issue does this PR close?
Closes #.
# Rationale for this change
we have removed option to configure ballista using toml files (dependencies
was unmaintaine
milenkovicm commented on PR #1462:
URL:
https://github.com/apache/datafusion-ballista/pull/1462#issuecomment-3919639089
cc @killzoner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
milenkovicm commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3919640927
> Quick search shows old default still on this file though :
https://github.com/killzoner/datafusion-ballista/blob/issue-1395/ballista/scheduler/scheduler_config_spec.toml
killzoner commented on PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#issuecomment-3919754197
> I believe sleep at
https://github.com/milenkovicm/datafusion-ballista/blob/0e1bcd278e58ad81f98dcb5cec8df8628331b54a/ballista/executor/src/execution_loop.rs#L205-L206
does
killzoner commented on code in PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#discussion_r2821824193
##
ballista/executor/src/config.rs:
##
@@ -78,7 +78,7 @@ pub struct Config {
)]
pub concurrent_tasks: usize,
/// Task scheduling policy: p
killzoner commented on code in PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#discussion_r2821824193
##
ballista/executor/src/config.rs:
##
@@ -78,7 +78,7 @@ pub struct Config {
)]
pub concurrent_tasks: usize,
/// Task scheduling policy: p
1 - 100 of 248 matches
Mail list logo
