Dandandan commented on issue #20324:
URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3912989383
> We should detect constant true filters
Testing in https://github.com/apache/datafusion/pulls
Perhaps we should make it a bit more smart so it will do this at the row
pepijnve commented on PR #19994:
URL: https://github.com/apache/datafusion/pull/19994#issuecomment-3913031913
Since `scatter` is currently implemented in DataFusion, keeping it there
might be the simplest. It would probably make sense to migrate this to arrow-rs
eventually if it can be made
dependabot[bot] opened a new pull request, #20398:
URL: https://github.com/apache/datafusion/pull/20398
Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action)
from 2.67.27 to 2.68.0.
Release notes
Sourced from https://github.com/taiki-e/install-action/releases";>
dependabot[bot] opened a new pull request, #20397:
URL: https://github.com/apache/datafusion/pull/20397
Bumps [actions/stale](https://github.com/actions/stale) from 10.1.1 to
10.2.0.
Release notes
Sourced from https://github.com/actions/stale/releases";>actions/stale's
releases.
CuteChuanChuan commented on PR #19994:
URL: https://github.com/apache/datafusion/pull/19994#issuecomment-3913069578
> Since `scatter` is currently implemented in DataFusion, keeping it there
might be the simplest. It would probably make sense to migrate this to arrow-rs
eventually if it can
dependabot[bot] opened a new pull request, #20400:
URL: https://github.com/apache/datafusion/pull/20400
Bumps [maturin](https://github.com/pyo3/maturin) from 1.11.5 to 1.12.2.
Release notes
Sourced from https://github.com/pyo3/maturin/releases";>maturin's releases.
v1.12.2
dependabot[bot] opened a new pull request, #20402:
URL: https://github.com/apache/datafusion/pull/20402
Bumps [env_logger](https://github.com/rust-cli/env_logger) from 0.11.8 to
0.11.9.
Release notes
Sourced from https://github.com/rust-cli/env_logger/releases";>env_logger's
relea
dependabot[bot] opened a new pull request, #20401:
URL: https://github.com/apache/datafusion/pull/20401
Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.20.0 to 1.21.0.
Release notes
Sourced from https://github.com/uuid-rs/uuid/releases";>uuid's releases.
v1.21.0
What'
gabotechs opened a new issue, #20396:
URL: https://github.com/apache/datafusion/issues/20396
### Is your feature request related to a problem or challenge?
The main purpose of this issue is to gather information about whether
there's appetite from the community for having the ability
Dandandan commented on PR #20395:
URL: https://github.com/apache/datafusion/pull/20395#issuecomment-3912980532
run benchmark clickbench_partitioned
DATAFUSION_EXECUTION_PARQUET_PUSHDOWN_FILTERS=true
DATAFUSION_EXECUTION_PARQUET_REORDER_FILTERS=true
--
This is an automated
dependabot[bot] opened a new pull request, #20399:
URL: https://github.com/apache/datafusion/pull/20399
Bumps [syn](https://github.com/dtolnay/syn) from 2.0.114 to 2.0.116.
Release notes
Sourced from https://github.com/dtolnay/syn/releases";>syn's
releases.
2.0.116
Op
dependabot[bot] opened a new pull request, #20404:
URL: https://github.com/apache/datafusion/pull/20404
Bumps [clap](https://github.com/clap-rs/clap) from 4.5.57 to 4.5.59.
Release notes
Sourced from https://github.com/clap-rs/clap/releases";>clap's releases.
v4.5.59
[4.5.
dependabot[bot] opened a new pull request, #20408:
URL: https://github.com/apache/datafusion/pull/20408
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from
0.60.0 to 0.61.0.
Commits
https://github.com/apache/datafusion-sqlparser-rs/commit/272c25ed83b97cce5
dependabot[bot] opened a new pull request, #20407:
URL: https://github.com/apache/datafusion/pull/20407
Bumps [aws-config](https://github.com/smithy-lang/smithy-rs) from 1.8.13 to
1.8.14.
Commits
See full diff in https://github.com/smithy-lang/smithy-rs/commits";>compare view
dependabot[bot] opened a new pull request, #20410:
URL: https://github.com/apache/datafusion/pull/20410
Bumps [indicatif](https://github.com/console-rs/indicatif) from 0.18.3 to
0.18.4.
Release notes
Sourced from https://github.com/console-rs/indicatif/releases";>indicatif's
relea
dependabot[bot] opened a new pull request, #20411:
URL: https://github.com/apache/datafusion/pull/20411
Bumps [sysinfo](https://github.com/GuillaumeGomez/sysinfo) from 0.38.1 to
0.38.2.
Changelog
Sourced from https://github.com/GuillaumeGomez/sysinfo/blob/main/CHANGELOG.md";>sysinf
dependabot[bot] opened a new pull request, #20403:
URL: https://github.com/apache/datafusion/pull/20403
Bumps [rand_distr](https://github.com/rust-random/rand_distr) from 0.5.1 to
0.6.0.
Changelog
Sourced from https://github.com/rust-random/rand_distr/blob/master/CHANGELOG.md";>ran
dependabot[bot] opened a new pull request, #20406:
URL: https://github.com/apache/datafusion/pull/20406
Bumps [tonic](https://github.com/hyperium/tonic) from 0.14.3 to 0.14.4.
Release notes
Sourced from https://github.com/hyperium/tonic/releases";>tonic's releases.
v0.14.4
dependabot[bot] opened a new pull request, #20405:
URL: https://github.com/apache/datafusion/pull/20405
Bumps [sqllogictest](https://github.com/risinglightdb/sqllogictest-rs) from
0.29.0 to 0.29.1.
Release notes
Sourced from https://github.com/risinglightdb/sqllogictest-rs/releases
dependabot[bot] opened a new pull request, #20409:
URL: https://github.com/apache/datafusion/pull/20409
Bumps [liblzma](https://github.com/portable-network-archive/liblzma-rs) from
0.4.5 to 0.4.6.
Release notes
Sourced from https://github.com/portable-network-archive/liblzma-rs/rel
milenkovicm commented on PR #1372:
URL:
https://github.com/apache/datafusion-ballista/pull/1372#issuecomment-3916775195
@danielhumanmod @killzoner @mattcuento I'd like to ask you for review if you
have some time. Please note that this functionality is far from finished (or
useful) but I'd
sdf-jkl commented on issue #18319:
URL: https://github.com/apache/datafusion/issues/18319#issuecomment-3916823216
> [@sdf-jkl](https://github.com/sdf-jkl) I have a couple questions I'm
hoping you can help me out with:
>
> 1. for `take_function_args` for `date_trunc` function, do I get
sdf-jkl commented on issue #18319:
URL: https://github.com/apache/datafusion/issues/18319#issuecomment-3916856934
@alamb Is there a reason to use
[`DateTruncGranularity`](https://github.com/apache/datafusion/blob/468b690d71350bc19c7e7bafd5dc61800973d91e/datafusion/functions/src/datetime/date
coderfender opened a new pull request, #3544:
URL: https://github.com/apache/datafusion-comet/pull/3544
## Which issue does this PR close?
Closes #.
This is a lighweight PR to return null when we cast from Date to Int / Long
in Spark. Spark returns null so we do the sa
coderfender commented on PR #3544:
URL:
https://github.com/apache/datafusion-comet/pull/3544#issuecomment-3916849223
@andygrove , Please take a look whenever you get a chance. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
comphead closed pull request #3470: chore: DataFusion 52 migration
URL: https://github.com/apache/datafusion-comet/pull/3470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
comphead commented on PR #3470:
URL:
https://github.com/apache/datafusion-comet/pull/3470#issuecomment-3916939876
Closing in favor of #3536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
neilconway opened a new issue, #20415:
URL: https://github.com/apache/datafusion/issues/20415
### Is your feature request related to a problem or challenge?
We currently implement uncorrelated scalar subqueries as joins. For example,
the query from #18181 is (after inlining a CTE):
neilconway commented on issue #3781:
URL: https://github.com/apache/datafusion/issues/3781#issuecomment-3917157685
I'd like to take this on! If anyone has bandwidth to help with reviewing,
that would be great -- I'd love to get some high-level feedback before writing
code.
--
This is an
neilconway closed issue #20415: Avoid representing uncorrelated scalar
subqueries as joins
URL: https://github.com/apache/datafusion/issues/20415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
neilconway commented on issue #20415:
URL: https://github.com/apache/datafusion/issues/20415#issuecomment-3917158883
Closing in favor of #3781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
neilconway commented on issue #3781:
URL: https://github.com/apache/datafusion/issues/3781#issuecomment-3917159911
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
neilconway commented on issue #3781:
URL: https://github.com/apache/datafusion/issues/3781#issuecomment-3917203388
@andygrove Looking at your suggestion for the optimizer trait, it sounds
like you had in mind that the logical optimization would evaluate the subquery,
rather than doing evalu
gene-bordegaray commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2819394087
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -450,6 +531,25 @@ impl PhysicalExpr for DynamicFilterPhysicalExpr {
}
}
+///
gene-bordegaray commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2819378323
##
datafusion/common/src/config.rs:
##
@@ -996,6 +996,39 @@ config_namespace! {
///
/// Note: This may reduce parallelism, rooting from t
gene-bordegaray commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2819378323
##
datafusion/common/src/config.rs:
##
@@ -996,6 +996,39 @@ config_namespace! {
///
/// Note: This may reduce parallelism, rooting from t
rafafrdz commented on code in PR #3497:
URL: https://github.com/apache/datafusion-comet/pull/3497#discussion_r2819446184
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -146,6 +146,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
cl
andygrove commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2819296741
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -707,22 +707,38 @@ pub fn spark_cast(
data_type: &DataType,
cast_options: &SparkCastOption
andygrove commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2819302829
##
native/spark-expr/src/utils.rs:
##
@@ -71,6 +72,49 @@ pub fn array_with_timezone(
to_type: Option<&DataType>,
) -> Result {
match array.data_ty
andygrove commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2819304750
##
native/core/src/parquet/parquet_exec.rs:
##
@@ -166,27 +203,24 @@ fn get_options(
(table_parquet_options, spark_parquet_options)
}
-fn get_file_co
darmie commented on issue #20324:
URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3917344339
I profiled a large category of regressions and have a fix for them. Sharing
findings below.
### Filter columns ⊆ projection columns: zero I/O benefit from RowFilter
andygrove commented on issue #3781:
URL: https://github.com/apache/datafusion/issues/3781#issuecomment-3917346520
Thanks for looking into this @neilconway. This issue is more than 3 years
old, so who knows what I was thinking at the time 🤔 ... this issue may be
somewhat stale at this point
adriangb commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2818058399
##
datafusion/common/src/config.rs:
##
@@ -996,6 +996,39 @@ config_namespace! {
///
/// Note: This may reduce parallelism, rooting from the I/O
coderfender commented on PR #3542:
URL:
https://github.com/apache/datafusion-comet/pull/3542#issuecomment-3917357349
Tes failures :
```
- sql-file: expressions/string/concat_ws.sql
[parquet.enable.dictionary=false] *** FAILED *** (719 milliseconds)
org.apache.spark.SparkExceptio
andygrove commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2819299162
##
native/spark-expr/src/utils.rs:
##
@@ -127,6 +171,7 @@ pub fn array_with_timezone(
}
fn datetime_cast_err(value: i64) -> ArrowError {
+println!("{
andygrove commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2819297807
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -930,7 +951,19 @@ fn cast_array(
)))
}
};
-Ok(spark_cast_postprocess(
kazuyukitanimura commented on PR #2774:
URL:
https://github.com/apache/datafusion-comet/pull/2774#issuecomment-3917489565
> I could look into this perhaps next week if we still need to address this
@kazuyukitanimura ?
Yes please, thank you @coderfender
--
This is an automated mes
darmie commented on issue #20324:
URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3917493563
@adriangb you raise a valid point. My approach is a bit too broad. With a
multi-conjunct predicate like `WHERE id = 123 AND long_message LIKE '%foo%'`,
the RowFilter evaluates co
coderfender commented on PR #3542:
URL:
https://github.com/apache/datafusion-comet/pull/3542#issuecomment-3917679967
@0lai0 , @andygrove . We might want to hold off onto this PR before
merging. There is a test failure and I am not sure we covered all possible
`Literal` conditions in our
coderfender commented on PR #3542:
URL:
https://github.com/apache/datafusion-comet/pull/3542#issuecomment-3917696373
We have 2 options here .
1. We could either merge this PR to handle NULL separator (but continue to
ignore the failed test)
2. Handle case where all inputs are litera
coderfender commented on code in PR #3542:
URL: https://github.com/apache/datafusion-comet/pull/3542#discussion_r2819656681
##
spark/src/test/resources/sql-tests/expressions/string/concat_ws.sql:
##
@@ -43,5 +43,5 @@ query
SELECT concat_ws(' ', first_name, middle_initial, last_
coderfender commented on code in PR #3542:
URL: https://github.com/apache/datafusion-comet/pull/3542#discussion_r2819652823
##
spark/src/test/resources/sql-tests/expressions/string/concat_ws.sql:
##
@@ -43,5 +43,5 @@ query
SELECT concat_ws(' ', first_name, middle_initial, last_
jayshrivastava opened a new issue, #20418:
URL: https://github.com/apache/datafusion/issues/20418
### Is your feature request related to a problem or challenge?
Dynamic filters are "inlined" when serialized and deserialized (ex. maybe
converted to a `LiteralExpr` or something).
jayshrivastava commented on issue #20418:
URL: https://github.com/apache/datafusion/issues/20418#issuecomment-3917720183
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
darmie opened a new pull request, #20417:
URL: https://github.com/apache/datafusion/pull/20417
## Which issue does this PR close?
- Closes part of #20324 (addresses the "filter columns ⊆ projection columns"
category of regressions).
- Related: #20325 (Q10 investigation)
## R
gene-bordegaray commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2819378323
##
datafusion/common/src/config.rs:
##
@@ -996,6 +996,39 @@ config_namespace! {
///
/// Note: This may reduce parallelism, rooting from t
gene-bordegaray commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2819378323
##
datafusion/common/src/config.rs:
##
@@ -996,6 +996,39 @@ config_namespace! {
///
/// Note: This may reduce parallelism, rooting from t
adriangb commented on issue #20324:
URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3917416683
> 15 of the regressing ClickBench queries (Q10-Q22, Q25, Q27) filter on a
column that is also in the `SELECT` projection. When all filter columns are
already projected, the Row
gene-bordegaray commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2819394087
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -450,6 +531,25 @@ impl PhysicalExpr for DynamicFilterPhysicalExpr {
}
}
+///
gene-bordegaray commented on code in PR #20331:
URL: https://github.com/apache/datafusion/pull/20331#discussion_r2819399629
##
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##
@@ -809,6 +831,23 @@ impl HashJoinExec {
self.dynamic_filter.as_ref().map(|df| &df.fil
comphead commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2819550773
##
native/core/src/parquet/parquet_exec.rs:
##
@@ -166,27 +203,24 @@ fn get_options(
(table_parquet_options, spark_parquet_options)
}
-fn get_file_con
comphead opened a new pull request, #3545:
URL: https://github.com/apache/datafusion-comet/pull/3545
## Which issue does this PR close?
Closes #.
## Rationale for this change
Upon benchmarking chcking if default config values are not optimal for
initial setup
comphead commented on PR #3545:
URL:
https://github.com/apache/datafusion-comet/pull/3545#issuecomment-3917736047
The results actually mixed 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
darmie commented on issue #20324:
URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3917751164
@adriangb I have tightened the guard in [#20417
](https://github.com/apache/datafusion/pull/20417, the batch filter path now
only triggers when the predicate has a single *stati
adriangb commented on code in PR #20414:
URL: https://github.com/apache/datafusion/pull/20414#discussion_r2819706516
##
.github/workflows/docs_pr.yaml:
##
@@ -44,16 +44,10 @@ jobs:
with:
submodules: true
fetch-depth: 1
- - name: Setup Python
-
adriangb commented on code in PR #20414:
URL: https://github.com/apache/datafusion/pull/20414#discussion_r2819707382
##
pyproject.toml:
##
@@ -0,0 +1,2 @@
+[tool.uv.workspace]
+members = ["benchmarks", "dev", "docs"]
Review Comment:
Dunno, maybe personal preference, I feel i
neilconway commented on issue #3781:
URL: https://github.com/apache/datafusion/issues/3781#issuecomment-3917789923
@andygrove Thanks, makes sense! I'll plan to start with the approach that I
outlined for the time being.
--
This is an automated message from the Apache Git Service.
To respo
Dandandan merged PR #20364:
URL: https://github.com/apache/datafusion/pull/20364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
hareshkh commented on PR #20382:
URL: https://github.com/apache/datafusion/pull/20382#issuecomment-3916558148
@mbutrovich @comphead : Sorry, my bad here. This PR only fixes a bug
introduced by https://github.com/apache/datafusion/pull/19759 so branch-51 and
branch-52 (which use usize instea
nuno-faria commented on code in PR #20282:
URL: https://github.com/apache/datafusion/pull/20282#discussion_r2818588829
##
.github/workflows/extended.yml:
##
@@ -167,11 +167,19 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
mbutrovich merged PR #3543:
URL: https://github.com/apache/datafusion-comet/pull/3543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
andygrove commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2819037616
##
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##
@@ -332,6 +332,38 @@ abstract class CometTestBase
}
}
+// inspired from spark
andygrove commented on code in PR #3491:
URL: https://github.com/apache/datafusion-comet/pull/3491#discussion_r2819793815
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -1138,25 +1123,26 @@ fn cast_binary_formatter(value: &[u8]) -> String {
/// Determines if DataFusio
andygrove commented on code in PR #3491:
URL: https://github.com/apache/datafusion-comet/pull/3491#discussion_r2819802100
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -1138,25 +1123,26 @@ fn cast_binary_formatter(value: &[u8]) -> String {
/// Determines if DataFusio
andygrove commented on PR #3545:
URL:
https://github.com/apache/datafusion-comet/pull/3545#issuecomment-3917896710
@sqlbenchmark run tpch --iterations 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
comphead merged PR #20400:
URL: https://github.com/apache/datafusion/pull/20400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #20401:
URL: https://github.com/apache/datafusion/pull/20401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #20378:
URL: https://github.com/apache/datafusion/pull/20378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
drin commented on issue #18319:
URL: https://github.com/apache/datafusion/issues/18319#issuecomment-3916520294
For example:
```rust
// lhs(>) --> column >= next_interval(part, const_rhs)
// lhs(<=) --> column < next_interval(part, const_rhs)
```
If I have `date_trunc('mon
andygrove commented on code in PR #3544:
URL: https://github.com/apache/datafusion-comet/pull/3544#discussion_r2818948744
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -960,44 +960,40 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHel
coderfender commented on code in PR #3544:
URL: https://github.com/apache/datafusion-comet/pull/3544#discussion_r2818971097
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -960,44 +960,40 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanH
andygrove commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2818993832
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -223,12 +223,22 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHel
andygrove commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2818993832
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -223,12 +223,22 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHel
coderfender commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2818999894
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -223,12 +223,22 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanH
andygrove commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2819007933
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -613,6 +613,20 @@ macro_rules! cast_decimal_to_int32_up {
}};
}
+macro_rules! cast_int_to_ti
andygrove commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2819010657
##
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##
@@ -332,6 +332,38 @@ abstract class CometTestBase
}
}
+// inspired from spark
andygrove commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2819012872
##
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##
@@ -332,6 +332,38 @@ abstract class CometTestBase
}
}
+// inspired from spark
timsaucer commented on code in PR #20414:
URL: https://github.com/apache/datafusion/pull/20414#discussion_r2818270003
##
.github/workflows/docs.yaml:
##
@@ -40,17 +40,11 @@ jobs:
ref: asf-site
path: asf-site
- - name: Setup Python
-uses: acti
comphead merged PR #20404:
URL: https://github.com/apache/datafusion/pull/20404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
dependabot[bot] commented on PR #20404:
URL: https://github.com/apache/datafusion/pull/20404#issuecomment-3916311019
Dependabot attempted to update this pull request, but because the branch
`dependabot/cargo/main/clap-4.5.59` is protected it was unable to do so.
--
This is an automated me
comphead merged PR #20406:
URL: https://github.com/apache/datafusion/pull/20406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
drin commented on issue #18319:
URL: https://github.com/apache/datafusion/issues/18319#issuecomment-3916501200
@sdf-jkl I have a couple questions I'm hoping you can help me out with:
1. for `take_function_args` for `date_trunc` function, do I get the
comparison operator? I need to know fo
comphead merged PR #20405:
URL: https://github.com/apache/datafusion/pull/20405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #20402:
URL: https://github.com/apache/datafusion/pull/20402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #20397:
URL: https://github.com/apache/datafusion/pull/20397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #20410:
URL: https://github.com/apache/datafusion/pull/20410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #20409:
URL: https://github.com/apache/datafusion/pull/20409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #20407:
URL: https://github.com/apache/datafusion/pull/20407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
xanderbailey commented on PR #19856:
URL: https://github.com/apache/datafusion/pull/19856#issuecomment-3916679171
@LiaCastaneda are you able to give this a look, seems like @dd-annarose and
@hareshkh are good with it but I know you're also invested in the substrait
work.
--
This is an a
jayshrivastava opened a new pull request, #20416:
URL: https://github.com/apache/datafusion/pull/20416
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes
1 - 100 of 225 matches
Mail list logo
