Re: [PR] chore: Extend backtrace coverage [datafusion]

2025-10-05 Thread via GitHub
dqkqd commented on code in PR #17921: URL: https://github.com/apache/datafusion/pull/17921#discussion_r2404690254 ## datafusion-examples/examples/memory_pool_execution_plan.rs: ## @@ -247,9 +248,7 @@ impl ExecutionPlan for BufferingExecutionPlan { children[0].cl

Re: [PR] chore: Extend backtrace coverage [datafusion]

2025-10-05 Thread via GitHub
comphead commented on code in PR #17921: URL: https://github.com/apache/datafusion/pull/17921#discussion_r2404697498 ## datafusion/core/src/execution/context/mod.rs: ## @@ -1196,9 +1184,11 @@ impl SessionContext { match function_factory { Some(f)

Re: [I] `SortMergeJoinExec` fails to allocate memory but should spill instead [datafusion-comet]

2025-10-05 Thread via GitHub
andygrove commented on issue #2452: URL: https://github.com/apache/datafusion-comet/issues/2452#issuecomment-3369204525 I learned more about this, and the issue may be in Comet rather than DataFusion. Because we share one pool between concurrent tasks, when one SMJ instance fails to alloca

Re: [PR] feat: Change default off-heap memory pool from from `greedy_unified` to `fair_unified` [datafusion-comet]

2025-10-05 Thread via GitHub
codecov-commenter commented on PR #2526: URL: https://github.com/apache/datafusion-comet/pull/2526#issuecomment-3369296018 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2526?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] infra: use macos-15-intel for x86_64 [datafusion-ballista]

2025-10-05 Thread via GitHub
kevinjqliu commented on code in PR #1325: URL: https://github.com/apache/datafusion-ballista/pull/1325#discussion_r2404716727 ## .github/workflows/build.yml: ## @@ -166,7 +166,7 @@ jobs: build-macos-x86_64: needs: [generate-license] name: Mac x86_64 -runs-on: m