Re: [PR] GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #49507: URL: https://github.com/apache/arrow/pull/49507#issuecomment-4058247998 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a315b961cd6ab7b438d02a02f7aee3ff5c0c87c2. There were no

Re: [I] [Variant] Add `shred_variant` support for `LargeUtf8` and `LargeBinary` types [arrow-rs]

2026-03-13 Thread via GitHub
sdf-jkl commented on issue #9525: URL: https://github.com/apache/arrow-rs/issues/9525#issuecomment-4057616113 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] fix(c/driver_manager): test and fix bugs in profiles [arrow-adbc]

2026-03-13 Thread via GitHub
lidavidm merged PR #4080: URL: https://github.com/apache/arrow-adbc/pull/4080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] Add has_true() and has_false() to BooleanArray [arrow-rs]

2026-03-13 Thread via GitHub
adriangb commented on PR #9511: URL: https://github.com/apache/arrow-rs/pull/9511#issuecomment-4057469543 @alamb this is the point: ``` true_count(all_true, 65536) 1.00228.0±0.13ns? ?/sec vs has_true(all_true, 65536)1.00 13.7±0.03ns

Re: [PR] Optimize `take_fixed_size_binary` For Predefined Value Lengths [arrow-rs]

2026-03-13 Thread via GitHub
Dandandan commented on code in PR #9535: URL: https://github.com/apache/arrow-rs/pull/9535#discussion_r2933375858 ## arrow-select/src/take.rs: ## @@ -723,46 +724,128 @@ fn take_fixed_size_binary( ArrowError::InvalidArgumentError(format!("Cannot convert size '{}' to usi

Re: [PR] perf: Reuse page buffers across data pages in column writer [arrow-rs]

2026-03-13 Thread via GitHub
asuresh8 commented on PR #9521: URL: https://github.com/apache/arrow-rs/pull/9521#issuecomment-4058085028 No worries. I was just working on a very specific use case and saw performance increase with this change, but looking at the broader use of this package, it doesn't really make sense.

[PR] add `shred_variant` support for `LargeUtf8` and `LargeBinary` [arrow-rs]

2026-03-13 Thread via GitHub
sdf-jkl opened a new pull request, #9554: URL: https://github.com/apache/arrow-rs/pull/9554 # Which issue does this PR close? - Closes #9525 . # Rationale for this change check issue. # What changes are included in this PR? Add `shred_variant` suppor

Re: [I] [C++][Python] Table.join_asof occasionally fails in doctest [arrow]

2026-03-13 Thread via GitHub
icexelloss commented on issue #49511: URL: https://github.com/apache/arrow/issues/49511#issuecomment-4058024374 Hi Rok, I don’t why this happens but doesn’t look like an actual failure. Looks like the test condition is just too strict, it should ignore different batch slicing when co

Re: [I] [C++][Python] Table.join_asof occasionally fails in doctest [arrow]

2026-03-13 Thread via GitHub
rok commented on issue #49511: URL: https://github.com/apache/arrow/issues/49511#issuecomment-4058040794 Oh, I was expecting the output would be a concated table. That makes a lot of sense, we should fix the test, thanks! -- This is an automated message from the Apache Git Service. To res

Re: [PR] GH-49380: [R] Remove hidden CI test chunks from setup.Rmd to fix r-de… [arrow]

2026-03-13 Thread via GitHub
vanshaj2023 commented on PR #49381: URL: https://github.com/apache/arrow/pull/49381#issuecomment-4058044634 Hi @jonkeane @thisisnic Please review these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[I] [Security Alert] Exposed API key(s) detected: AWS Access Key [arrow-rs-object-store]

2026-03-13 Thread via GitHub
hdhdn opened a new issue, #659: URL: https://github.com/apache/arrow-rs-object-store/issues/659 Hi, An automated responsible-disclosure scan found pattern(s) matching the following API key type(s) in this file: **https://github.com/apache/arrow-rs-object-store/blob/bdcac43fc63

Re: [PR] perf: Reuse page buffers across data pages in column writer [arrow-rs]

2026-03-13 Thread via GitHub
asuresh8 closed pull request #9521: perf: Reuse page buffers across data pages in column writer URL: https://github.com/apache/arrow-rs/pull/9521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] perf: DictionaryArray passthrough optimization for Parquet writer [arrow-rs]

2026-03-13 Thread via GitHub
asuresh8 commented on code in PR #9520: URL: https://github.com/apache/arrow-rs/pull/9520#discussion_r2933855741 ## parquet/src/arrow/arrow_writer/byte_array.rs: ## @@ -356,6 +416,51 @@ impl DictEncoder { } } +/// Fast path for DictionaryArray input with a la

Re: [I] [C++] C++20: Re-enable timezone tests once GCC fixes chrono::time_zone::get_info behavior [arrow]

2026-03-13 Thread via GitHub
rok commented on issue #48743: URL: https://github.com/apache/arrow/issues/48743#issuecomment-4058833977 Upstream [update](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] Move `ValueIter` into own module, and add public `record_count` function [arrow-rs]

2026-03-13 Thread via GitHub
Rafferty97 opened a new pull request, #9557: URL: https://github.com/apache/arrow-rs/pull/9557 # Which issue does this PR close? Another smaller PR extracted from #9494. # Rationale for this change I've moved `ValueIter` into its own module because it's already self-cont

Re: [PR] feat(parquet/file): pre-allocate BinaryBuilder data buffer using column chunk metadata to eliminate resize overhead [arrow-go]

2026-03-13 Thread via GitHub
zeroshade commented on PR #689: URL: https://github.com/apache/arrow-go/pull/689#issuecomment-4059543056 You're absolutely correct there, this really gives the best benefit to very specific use cases that were causing multiple reallocate-and-copy scenarios but doesn't do anything to help th

Re: [PR] GH-49272: [C++][CI] Fix intermittent segfault in arrow-json-test on M… [arrow]

2026-03-13 Thread via GitHub
vanshaj2023 commented on PR #49462: URL: https://github.com/apache/arrow/pull/49462#issuecomment-4057774821 Hi @kou I fixed the lint failure. Please review the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] add `shred_variant` support for `LargeUtf8` and `LargeBinary` [arrow-rs]

2026-03-13 Thread via GitHub
sdf-jkl commented on PR #9554: URL: https://github.com/apache/arrow-rs/pull/9554#issuecomment-4057922182 @klion26 @codephage2020 @scovich -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[I] Flight encoding panics with "no dict id for field" with nested dict arrays [arrow-rs]

2026-03-13 Thread via GitHub
asubiotto opened a new issue, #9555: URL: https://github.com/apache/arrow-rs/issues/9555 **Describe the bug** Flight encoding panics with "no dict id for field" when sending dictionary-encoded arrays nested inside RunEndEncoded, ListView, LargeListView, FixedSizeList, or Dictionary-o

Re: [PR] GH-48926: [C++] Upgrade Abseil/Protobuf/GRPC/Google-Cloud-CPP bundled versions [arrow]

2026-03-13 Thread via GitHub
kou commented on PR #48964: URL: https://github.com/apache/arrow/pull/48964#issuecomment-4059290108 Great! I'll also take a look at the Google Cloud C++ and OpenTelemetry later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] ci: update Node.js actions to 24 and test matrix to [20, 24] [arrow-js]

2026-03-13 Thread via GitHub
kou merged PR #411: URL: https://github.com/apache/arrow-js/pull/411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] Replace interleave overflow panic with error [arrow-rs]

2026-03-13 Thread via GitHub
xudong963 commented on PR #9549: URL: https://github.com/apache/arrow-rs/pull/9549#issuecomment-4059351583 @alamb Thanks for the review, looks like no regression -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] arrow-flight: generate dict_ids for dicts nested inside complex types [arrow-rs]

2026-03-13 Thread via GitHub
asubiotto opened a new pull request, #9556: URL: https://github.com/apache/arrow-rs/pull/9556 Some cases were missing. # Which issue does this PR close? - Closes #9555 . # Rationale for this change Fix flight encoding panic # What changes are inc

Re: [PR] arrow-flight: generate dict_ids for dicts nested inside complex types [arrow-rs]

2026-03-13 Thread via GitHub
asubiotto commented on PR #9556: URL: https://github.com/apache/arrow-rs/pull/9556#issuecomment-4058602966 cc @brancz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] add `shred_variant` support for `LargeUtf8` and `LargeBinary` [arrow-rs]

2026-03-13 Thread via GitHub
sdf-jkl commented on PR #9554: URL: https://github.com/apache/arrow-rs/pull/9554#issuecomment-4058608343 @scovich It is, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] GH-49268: [C++][FlightRPC] Fix ODBC tests for MacOS [arrow]

2026-03-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #49267: URL: https://github.com/apache/arrow/pull/49267#issuecomment-4053453905 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 21a2d4f81df61ff49ceb12e5205ea38cd1f70012. There were no

Re: [I] c/driver_manager: investigate/test overriding driver (and other params) in profile [arrow-adbc]

2026-03-13 Thread via GitHub
lidavidm commented on issue #4085: URL: https://github.com/apache/arrow-adbc/issues/4085#issuecomment-4053208922 Does this seem reasonable? - We check all arguments for a profile first. - Multiple profiles is an error. - If we have a profile, we load it. - We then check driver

[PR] Replace interleave overflow panic with error [arrow-rs]

2026-03-13 Thread via GitHub
xudong963 opened a new pull request, #9549: URL: https://github.com/apache/arrow-rs/pull/9549 # Which issue does this PR close? - Closes #NNN. # Rationale for this change # What changes are included in this PR? Replace interleave ove

Re: [I] Snappy and Brotli debug libraries linked in Release builds when using vcpkg with multi-config generators [arrow]

2026-03-13 Thread via GitHub
marcin-krystianc commented on issue #49499: URL: https://github.com/apache/arrow/issues/49499#issuecomment-4053777580 > Could you provide `ArrowConfig.cmake` in your environment? > > Could you provide the log of `cmake -B build/ -S . -D VCPKG_TARGET_TRIPLET=$triplet -D CMAKE_TOOLCHAI

Re: [I] [Variant] Align cast logic for `variant_get` to cast kernel [arrow-rs]

2026-03-13 Thread via GitHub
klion26 commented on issue #8982: URL: https://github.com/apache/arrow-rs/issues/8982#issuecomment-4053798018 @scovich, sorry for the late reply; this notification mail is located in a different folder this time. > so unifying them would require factoring out a common scalar cast cap

Re: [I] [Python] Reintroduce docstring injection for stubfiles [arrow]

2026-03-13 Thread via GitHub
rok commented on issue #49452: URL: https://github.com/apache/arrow/issues/49452#issuecomment-4054233425 Issue resolved by pull request 49453 https://github.com/apache/arrow/pull/49453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-49452: [Python] Reintroduce docstring injection for stubfiles [arrow]

2026-03-13 Thread via GitHub
rok merged PR #49453: URL: https://github.com/apache/arrow/pull/49453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] GH-37937: [C++][FlightRPC] Investigate using gRPC's generic API using gRPC's BidiReactor [arrow]

2026-03-13 Thread via GitHub
raulcd commented on PR #49339: URL: https://github.com/apache/arrow/pull/49339#issuecomment-4054210770 @lidavidm @pitrou I've moved the serialization / Deserialization logic from `arrow/flight/transport/grpc/serialization_internal.cc` to `arrow/flight/serialization_internal.cc`. Those ar

Re: [PR] GH-49438: [C++][Gandiva] Optimize LPAD/RPAD functions [arrow]

2026-03-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #49439: URL: https://github.com/apache/arrow/pull/49439#issuecomment-4054403464 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 570771343b2666e801e5d289e33cca22243a6bf1. There were no

Re: [I] [Python] Type aliases for timestamp with timezone [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on issue #31072: URL: https://github.com/apache/arrow/issues/31072#issuecomment-4054394424 This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 1

Re: [I] [R] [CI] Fail the build if there is a documentation mismatch? [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on issue #31077: URL: https://github.com/apache/arrow/issues/31077#issuecomment-4054394575 This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 1

Re: [I] [FlightRPC][Docs] Document the authentication methods [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on issue #31087: URL: https://github.com/apache/arrow/issues/31087#issuecomment-4054395359 This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 1

Re: [I] [C++] Correctly handle Substrait nullability of types [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on issue #20108: URL: https://github.com/apache/arrow/issues/20108#issuecomment-4054394696 This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 1

Re: [I] [C++] Add compute functionality for Substrait types [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on issue #20109: URL: https://github.com/apache/arrow/issues/20109#issuecomment-4054394849 This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 1

Re: [I] [C++] Add extension types to the YAML for different timestamp resolutions [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on issue #31080: URL: https://github.com/apache/arrow/issues/31080#issuecomment-4054395017 This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 1

Re: [PR] arrow-buffer: i256: Implement num_traits wrapping shift [arrow-rs]

2026-03-13 Thread via GitHub
Rafferty97 commented on code in PR #9418: URL: https://github.com/apache/arrow-rs/pull/9418#discussion_r2930739609 ## arrow-buffer/src/bigint/mod.rs: ## @@ -807,6 +807,46 @@ impl Shr for i256 { } } +impl WrappingShl for i256 { +#[inline] +fn wrapping_shl(&self, r

Re: [I] [Python] Extension dtype in the index is not preserved on a roundtrip from Pandas [arrow]

2026-03-13 Thread via GitHub
AlenkaF commented on issue #31031: URL: https://github.com/apache/arrow/issues/31031#issuecomment-4054555862 This has been fixed in the meantime: ```python In [1]: import pandas as pd ...: import pyarrow as pa ...: df = pd.DataFrame(index=pd.interval_range(start=0, end=3

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
Dandandan commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505 run benchmark arrow_reader_clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579865 Benchmark job started for [this request](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) (job `bench-c4054579505-208`). Results will be posted here when complete

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054594205 🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) `Linux bench-c4054579505-208-wfbb2 6.12.55+ #1 SMP Sun Fe

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054611440 🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) `Linux bench-c4054579505-208-8tk29 6.12.55+ #1 SMP Sun Fe

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054602606 Benchmark for [this request](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) failed. Last 20 lines of output: Click to expand ``` Cloning int

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054607209 Benchmark for [this request](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) failed. Last 20 lines of output: Click to expand ``` Cloning int

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054612561 Benchmark for [this request](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) failed. Last 20 lines of output: Click to expand ``` Cloning int

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054605921 🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) `Linux bench-c4054579505-208-42nss 6.12.55+ #1 SMP Sun Fe

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054619861 Benchmark for [this request](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) failed. Last 20 lines of output: Click to expand ``` Cloning int

Re: [PR] [bench] Snappy tweaks [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9541: URL: https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054618225 🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/9541#issuecomment-4054579505) `Linux bench-c4054579505-208-5jf84 6.12.55+ #1 SMP Sun Fe

Re: [PR] arrow-buffer: i256: Implement num_traits wrapping shift [arrow-rs]

2026-03-13 Thread via GitHub
theirix commented on code in PR #9418: URL: https://github.com/apache/arrow-rs/pull/9418#discussion_r2930787302 ## arrow-buffer/src/bigint/mod.rs: ## @@ -807,6 +807,46 @@ impl Shr for i256 { } } +impl WrappingShl for i256 { +#[inline] +fn wrapping_shl(&self, rhs:

Re: [PR] arrow-buffer: i256: Implement num_traits wrapping shift [arrow-rs]

2026-03-13 Thread via GitHub
theirix commented on code in PR #9418: URL: https://github.com/apache/arrow-rs/pull/9418#discussion_r2930567422 ## arrow-buffer/src/bigint/mod.rs: ## @@ -807,6 +807,46 @@ impl Shr for i256 { } } +impl WrappingShl for i256 { +#[inline] +fn wrapping_shl(&self, rhs:

Re: [PR] GH-49454: [C++][Gandiva] Fix castVARCHAR_timestamp for pre-epoch timestamps [arrow]

2026-03-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #49455: URL: https://github.com/apache/arrow/pull/49455#issuecomment-4054390228 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d436b238a9df1472c86bc2cc1bce46df7cb1d6db. There were no

Re: [I] [C++] Store generated Flight protocol buffer headers in src/generated [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on issue #31083: URL: https://github.com/apache/arrow/issues/31083#issuecomment-4054395191 This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 1

Re: [PR] GH-49420: [C++][Gandiva] Fix castVARCHAR memory allocation and len<=0 handling [arrow]

2026-03-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #49421: URL: https://github.com/apache/arrow/pull/49421#issuecomment-4054628975 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b9274bc9e043338e070f342503e392b935e5fbfa. There were no

[PR] [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
rok opened a new pull request, #49507: URL: https://github.com/apache/arrow/pull/49507 ### Rationale for this change See https://github.com/apache/arrow/issues/49506. ### What changes are included in this PR? We skip cuda docstests in CI, since we don't build for CUDA.

Re: [PR] [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on PR #49507: URL: https://github.com/apache/arrow/pull/49507#issuecomment-4054692683 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue f

Re: [PR] GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
github-actions[bot] commented on PR #49507: URL: https://github.com/apache/arrow/pull/49507#issuecomment-4054700753 :warning: GitHub issue #49506 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] fix: trim before parsing numbers [arrow-rs]

2026-03-13 Thread via GitHub
aryan-212 commented on PR #9537: URL: https://github.com/apache/arrow-rs/pull/9537#issuecomment-4054717162 > Have you run the benchmarks for this? sorry, new here, could you tell me how do I run them? 😅 -- This is an automated message from the Apache Git Service. To respond to the

[PR] fix(avro): correctly set nullability for ListType [arrow-go]

2026-03-13 Thread via GitHub
Willem-J-an opened a new pull request, #709: URL: https://github.com/apache/arrow-go/pull/709 ### Rationale for this change Nullability of a list field itself is lost when converting from avro to arrow schema; only the nullability of the list members is applied. ### What changes ar

Re: [I] InvalidArgumentError("Expected 1 buffers in array of type FixedSizeBinary(4), got 2" [arrow-rs]

2026-03-13 Thread via GitHub
vigneshsiva11 commented on issue #9247: URL: https://github.com/apache/arrow-rs/issues/9247#issuecomment-4054781339 hi @alamb Thanks for the suggestion! That makes sense — I'll start by adding a regression test that reproduces the failure and then work on fixing the bug once the tes

Re: [I] [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
rok commented on issue #49506: URL: https://github.com/apache/arrow/issues/49506#issuecomment-4054825440 This is likely due to the new release of [pytest-cython v0.4.0](https://github.com/pytest-cython/pytest-cython/releases/tag/v0.4.0) that started to be used [on runners](https://github.c

Re: [PR] GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
rok commented on PR #49507: URL: https://github.com/apache/arrow/pull/49507#issuecomment-4054830812 Crossposting from the issue: > This is likely due to the new release of [pytest-cython v0.4.0](https://github.com/pytest-cython/pytest-cython/releases/tag/v0.4.0) that started to be used [

Re: [PR] GH-49103: [Python] Add internal type system stubs (_types, error, _stubs_typing) [arrow]

2026-03-13 Thread via GitHub
dangotbanned commented on PR #48622: URL: https://github.com/apache/arrow/pull/48622#issuecomment-4054882255 > @dangotbanned with packaging part mostly solved I'd like to get this and maybe #49200 through review this week. > Any chance you'd have time to review? :) Thanks for the

Re: [PR] GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
rok commented on PR #49507: URL: https://github.com/apache/arrow/pull/49507#issuecomment-4054918800 @raulcd - this is to fix the current CI failure. Quick cehck before I merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] feat: two-stage builder API for async Avro reader [arrow-rs]

2026-03-13 Thread via GitHub
mzabaluev closed pull request #9462: feat: two-stage builder API for async Avro reader URL: https://github.com/apache/arrow-rs/pull/9462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat: two-stage builder API for async Avro reader [arrow-rs]

2026-03-13 Thread via GitHub
mzabaluev commented on PR #9462: URL: https://github.com/apache/arrow-rs/pull/9462#issuecomment-4054960756 Superseded by #9548. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] GH-49103: [Python] Add internal type system stubs (_types, error, _stubs_typing) [arrow]

2026-03-13 Thread via GitHub
rok commented on PR #48622: URL: https://github.com/apache/arrow/pull/48622#issuecomment-4054994878 > Thanks for the ping @rok Yeah I will try my best to review this week. Perfect! Looking forward :). > 1. Are you just looking for a review of: > >* [`_stubs_typing

Re: [I] [Java][Dataset] OOM Killer triggered by unbounded native memory usage during Parquet read; NativeMemoryPool.createListenable crashes with JNI error #49472 [arrow-java]

2026-03-13 Thread via GitHub
10183974 commented on issue #1057: URL: https://github.com/apache/arrow-java/issues/1057#issuecomment-4053641917 this is indeed a bug. I was able to identify and resolve the issue with the assistance of AI. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] GH-49452: [Python] Reintroduce docstring injection for stubfiles [arrow]

2026-03-13 Thread via GitHub
raulcd commented on code in PR #49453: URL: https://github.com/apache/arrow/pull/49453#discussion_r2930091610 ## python/CMakeLists.txt: ## @@ -1025,3 +1025,39 @@ if(PYARROW_BUILD_PARQUET) target_link_libraries(_parquet_encryption PRIVATE arrow_python_parquet_encryption)

Re: [PR] arrow-buffer: i256: implement ilog via i256 crate [arrow-rs]

2026-03-13 Thread via GitHub
theirix commented on code in PR #9453: URL: https://github.com/apache/arrow-rs/pull/9453#discussion_r2930126304 ## arrow-buffer/src/bigint/mod.rs: ## @@ -614,6 +615,62 @@ impl i256 { let n = (n.high >> 64) as i64; // throw away the lower 192 bits (n as f64) * f

Re: [PR] arrow-buffer: i256: implement ilog via i256 crate [arrow-rs]

2026-03-13 Thread via GitHub
theirix commented on code in PR #9453: URL: https://github.com/apache/arrow-rs/pull/9453#discussion_r2930127562 ## arrow-buffer/src/bigint/mod.rs: ## @@ -614,6 +615,62 @@ impl i256 { let n = (n.high >> 64) as i64; // throw away the lower 192 bits (n as f64) * f

Re: [PR] arrow-buffer: i256: implement ilog via i256 crate [arrow-rs]

2026-03-13 Thread via GitHub
theirix commented on code in PR #9453: URL: https://github.com/apache/arrow-rs/pull/9453#discussion_r2930154287 ## arrow-buffer/src/bigint/mod.rs: ## @@ -614,6 +615,62 @@ impl i256 { let n = (n.high >> 64) as i64; // throw away the lower 192 bits (n as f64) * f

Re: [PR] GH-49272: [C++][CI] Fix intermittent segfault in arrow-json-test on M… [arrow]

2026-03-13 Thread via GitHub
vanshaj2023 commented on PR #49462: URL: https://github.com/apache/arrow/pull/49462#issuecomment-4053869311 Thanks for the review @kou I’ll check the CI/CD issues on my fork branch and push a final commit shortly. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add benchmark for `infer_json_schema` [arrow-rs]

2026-03-13 Thread via GitHub
Dandandan merged PR #9546: URL: https://github.com/apache/arrow-rs/pull/9546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] chore: Protect `main` branch with required reviews [arrow-rs]

2026-03-13 Thread via GitHub
Dandandan commented on PR #9547: URL: https://github.com/apache/arrow-rs/pull/9547#issuecomment-4053954174 @comphead I merged it without review :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] chore: Protect `main` branch with required reviews [arrow-rs]

2026-03-13 Thread via GitHub
Dandandan merged PR #9547: URL: https://github.com/apache/arrow-rs/pull/9547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] Add benchmark for `infer_json_schema` [arrow-rs]

2026-03-13 Thread via GitHub
alamb commented on code in PR #9546: URL: https://github.com/apache/arrow-rs/pull/9546#discussion_r2930170348 ## arrow-json/benches/json_reader.rs: ## @@ -323,13 +325,83 @@ fn bench_serialize_list(c: &mut Criterion) { }); } +fn bench_schema_inference(c: &mut Criterion) {

Re: [PR] Add benchmark for `infer_json_schema` [arrow-rs]

2026-03-13 Thread via GitHub
alamb commented on PR #9546: URL: https://github.com/apache/arrow-rs/pull/9546#issuecomment-4053954847 Thanks @Rafferty97 for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add has_true() and has_false() to BooleanArray [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9511: URL: https://github.com/apache/arrow-rs/pull/9511#issuecomment-4053957747 Benchmark job started for [this request](https://github.com/apache/arrow-rs/pull/9511#issuecomment-4053957332) (job `bench-c4053957332-207`). Results will be posted here when complete

Re: [PR] Add has_true() and has_false() to BooleanArray [arrow-rs]

2026-03-13 Thread via GitHub
alamb commented on PR #9511: URL: https://github.com/apache/arrow-rs/pull/9511#issuecomment-4053957332 run benchmark boolean_array -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] fix: trim before parsing numbers [arrow-rs]

2026-03-13 Thread via GitHub
tustvold commented on PR #9537: URL: https://github.com/apache/arrow-rs/pull/9537#issuecomment-4053976982 Have you run the benchmarks for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add has_true() and has_false() to BooleanArray [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9511: URL: https://github.com/apache/arrow-rs/pull/9511#issuecomment-4054003293 🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/9511#issuecomment-4053957332) `Linux bench-c4053957332-207-22g2d 6.12.55+ #1 SMP Sun Fe

Re: [PR] GH-49452: [Python] Reintroduce docstring injection for stubfiles [arrow]

2026-03-13 Thread via GitHub
rok commented on code in PR #49453: URL: https://github.com/apache/arrow/pull/49453#discussion_r2930239569 ## python/CMakeLists.txt: ## @@ -1025,3 +1025,39 @@ if(PYARROW_BUILD_PARQUET) target_link_libraries(_parquet_encryption PRIVATE arrow_python_parquet_encryption) en

Re: [PR] GH-49452: [Python] Reintroduce docstring injection for stubfiles [arrow]

2026-03-13 Thread via GitHub
rok commented on PR #49453: URL: https://github.com/apache/arrow/pull/49453#issuecomment-4054033148 Thanks for reviews @raulcd @kou! Will merge when CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] arrow-buffer: i256: implement ilog via i256 crate [arrow-rs]

2026-03-13 Thread via GitHub
Rafferty97 commented on code in PR #9453: URL: https://github.com/apache/arrow-rs/pull/9453#discussion_r2930251035 ## arrow-buffer/src/bigint/mod.rs: ## @@ -614,6 +615,62 @@ impl i256 { let n = (n.high >> 64) as i64; // throw away the lower 192 bits (n as f64)

Re: [PR] Add benchmark for `infer_json_schema` [arrow-rs]

2026-03-13 Thread via GitHub
Rafferty97 commented on code in PR #9546: URL: https://github.com/apache/arrow-rs/pull/9546#discussion_r2930261866 ## arrow-json/benches/json_reader.rs: ## @@ -323,13 +325,83 @@ fn bench_serialize_list(c: &mut Criterion) { }); } +fn bench_schema_inference(c: &mut Criteri

Re: [PR] Add has_true() and has_false() to BooleanArray [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9511: URL: https://github.com/apache/arrow-rs/pull/9511#issuecomment-4054032857 🤖 Arrow criterion benchmark completed (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/9511#issuecomment-4053957332) **New benchmark — branch-only results (no baseline

Re: [PR] Add benchmark for `infer_json_schema` [arrow-rs]

2026-03-13 Thread via GitHub
Rafferty97 commented on code in PR #9546: URL: https://github.com/apache/arrow-rs/pull/9546#discussion_r2930276935 ## arrow-json/Cargo.toml: ## @@ -61,6 +61,7 @@ tokio = { version = "1.27", default-features = false, features = ["io-util"] } bytes = "1.4" criterion = { workspa

[I] Remove dependency on `arbitrary` [arrow-rs]

2026-03-13 Thread via GitHub
Rafferty97 opened a new issue, #9550: URL: https://github.com/apache/arrow-rs/issues/9550 When authoring https://github.com/apache/arrow-rs/pull/9546, I introduced a dependency on `arbitrary` that wasn't really necessary, so it should be removed. Instead, the test data used by the JSON sche

Re: [I] Remove dependency on `arbitrary` [arrow-rs]

2026-03-13 Thread via GitHub
Rafferty97 commented on issue #9550: URL: https://github.com/apache/arrow-rs/issues/9550#issuecomment-4054072764 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
rok commented on PR #49507: URL: https://github.com/apache/arrow/pull/49507#issuecomment-4055536733 Thanks for review @raulcd, will merge once CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent [arrow]

2026-03-13 Thread via GitHub
raulcd commented on code in PR #49507: URL: https://github.com/apache/arrow/pull/49507#discussion_r2931368108 ## python/pyarrow/conftest.py: ## @@ -239,10 +246,7 @@ def pytest_ignore_collect(collection_path, config): return True if 'pyarrow/cuda' in s

Re: [I] [Docs][Python][C++] Minimize warnings and docutils errors for Sphinx build html where possible [arrow]

2026-03-13 Thread via GitHub
tadeja commented on issue #49509: URL: https://github.com/apache/arrow/issues/49509#issuecomment-4056024035 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] fix(parquet/pqarrow): fix Decimal256 sign extension [arrow-go]

2026-03-13 Thread via GitHub
dimakuz opened a new pull request, #710: URL: https://github.com/apache/arrow-go/pull/710 …imal256 bigEndianToDecimal256 in column_readers.go has a bug in the partial-word sign extension path: it shifts by wordLen (byte count) instead of wordLen*8 (bit count). This is a copy-paste er

Re: [PR] fix(parquet/pqarrow): fix Decimal256 sign extension [arrow-go]

2026-03-13 Thread via GitHub
dimakuz closed pull request #710: fix(parquet/pqarrow): fix Decimal256 sign extension URL: https://github.com/apache/arrow-go/pull/710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Replace interleave overflow panic with error [arrow-rs]

2026-03-13 Thread via GitHub
alamb commented on PR #9549: URL: https://github.com/apache/arrow-rs/pull/9549#issuecomment-4056074296 run benchmark interleave -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Replace interleave overflow panic with error [arrow-rs]

2026-03-13 Thread via GitHub
adriangbot commented on PR #9549: URL: https://github.com/apache/arrow-rs/pull/9549#issuecomment-4056074527 Benchmark job started for [this request](https://github.com/apache/arrow-rs/pull/9549#issuecomment-4056074296) (job `bench-c4056074296-209`). Results will be posted here when complete

  1   2   >