caicancai opened a new pull request, #9426:
URL: https://github.com/apache/arrow-datafusion/pull/9426
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tes
caicancai commented on PR #9426:
URL:
https://github.com/apache/arrow-datafusion/pull/9426#issuecomment-1974704475
Please forgive me for adding some negative tests at will. I am not sure
whether it is appropriate to add negative tests to scalar.slt. I am compiling a
negative test document
advancedxy opened a new pull request, #152:
URL: https://github.com/apache/arrow-datafusion-comet/pull/152
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these ch
advancedxy closed pull request #152: support cross compile for spark 3.2 and
spark 3.3
URL: https://github.com/apache/arrow-datafusion-comet/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509945936
##
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##
@@ -635,6 +640,102 @@ async fn verify_udf_return_type() -> Result<()> {
Ok(())
}
alamb commented on issue #9405:
URL:
https://github.com/apache/arrow-datafusion/issues/9405#issuecomment-1974771388
> I'm gonna reopen this because I think we should at the very least enhance
the documentation for supports_filters_pushdown, and maybe even introduce a
runtime check somewher
milenkovicm commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509951359
##
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##
@@ -635,6 +640,102 @@ async fn verify_udf_return_type() -> Result<()> {
Ok(
milenkovicm commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509951559
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -303,3 +321,66 @@ pub struct DropCatalogSchema {
/// Dummy schema
pub schema: DFSchemaRef,
}
+
thinkharderdev commented on code in PR #9395:
URL: https://github.com/apache/arrow-datafusion/pull/9395#discussion_r1509951518
##
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##
@@ -756,6 +766,105 @@ impl LogicalExtensionCodec for TopKExtensionCodec {
}
}
+#[d
alamb opened a new issue, #5453:
URL: https://github.com/apache/arrow-rs/issues/5453
## Is your feature request related to a problem or challenge? Please
describe what you are trying to do.
50.0.0 was released about 2 months ago:
https://crates.io/crates/arrow/50.0.0 (Jan 12, 2024)
milenkovicm commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509952063
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -303,3 +321,66 @@ pub struct DropCatalogSchema {
/// Dummy schema
pub schema: DFSchemaRef,
}
+
milenkovicm commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509952063
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -303,3 +321,66 @@ pub struct DropCatalogSchema {
/// Dummy schema
pub schema: DFSchemaRef,
}
+
alamb commented on PR #5293:
URL: https://github.com/apache/arrow-rs/pull/5293#issuecomment-1974773422
Tracking next release in https://github.com/apache/arrow-rs/issues/5453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
alamb commented on issue #5453:
URL: https://github.com/apache/arrow-rs/issues/5453#issuecomment-1974773664
I am happy to help with the logistics of this release
I don't think it is blocked on the object store release (which is minor)
https://github.com/apache/arrow-rs/issues/5436
milenkovicm commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509952350
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -303,3 +321,66 @@ pub struct DropCatalogSchema {
/// Dummy schema
pub schema: DFSchemaRef,
}
+
milenkovicm commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509953513
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -303,3 +321,66 @@ pub struct DropCatalogSchema {
/// Dummy schema
pub schema: DFSchemaRef,
}
+
alamb opened a new issue, #5454:
URL: https://github.com/apache/arrow-rs/issues/5454
**Describe the bug**
`lexsort_to_indices` a `ListArray` itself works fine
However, `lexsort_to_indices` with a `ListArray` and another array results
in an error:
**To Reprodu
alamb opened a new pull request, #5455:
URL: https://github.com/apache/arrow-rs/pull/5455
# Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/5454
# Rationale for this change
Fix bug
# What changes are included in this PR?
Add sup
alamb commented on code in PR #9410:
URL: https://github.com/apache/arrow-datafusion/pull/9410#discussion_r1509954476
##
datafusion/sqllogictest/test_files/order.slt:
##
@@ -784,3 +784,110 @@ SortPreservingMergeExec: [m@0 ASC NULLS LAST,t@1 ASC
NULLS LAST]
Aggr
alamb commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509957293
##
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##
@@ -635,6 +640,102 @@ async fn verify_udf_return_type() -> Result<()> {
Ok(())
}
alamb commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509957464
##
datafusion/core/src/execution/context/mod.rs:
##
@@ -1261,7 +1313,38 @@ impl QueryPlanner for DefaultQueryPlanner {
.await
}
}
+/// A plugg
milenkovicm commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1509959181
##
datafusion/core/src/execution/context/mod.rs:
##
@@ -1306,6 +1381,12 @@ pub struct SessionState {
table_factories: HashMap>,
/// Runtime envir
milenkovicm commented on PR #9333:
URL:
https://github.com/apache/arrow-datafusion/pull/9333#issuecomment-1974785906
> Thanks again @milenkovicm -- the only thing left from my perspective is to
"error on multi-part identifiers" which I think we could do as a follow on PR
if needed.
>
milenkovicm commented on PR #9333:
URL:
https://github.com/apache/arrow-datafusion/pull/9333#issuecomment-1974786736
and please squash commit on merge, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
alamb commented on code in PR #9304:
URL: https://github.com/apache/arrow-datafusion/pull/9304#discussion_r1509959592
##
datafusion/expr/src/udf.rs:
##
@@ -338,6 +346,13 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
fn monotonicity(&self) -> Result> {
Ok(None)
Kikkon opened a new pull request, #5456:
URL: https://github.com/apache/arrow-rs/pull/5456
# Which issue does this PR close?
Closes #5430 .
# Rationale for this change
# What changes are included in this PR?
Modifying comments to satisfy the function's
my-vegetable-has-exploded commented on PR #9236:
URL:
https://github.com/apache/arrow-datafusion/pull/9236#issuecomment-1974818649
Sorry for late response. I added some tests and more comments.
> 2. **Projection Length Check**: The check **`projection_index.len() >=
hash_join.sch
advancedxy opened a new pull request, #153:
URL: https://github.com/apache/arrow-datafusion-comet/pull/153
## Which issue does this PR close?
Closes #143.
## Rationale for this change
Software quality and makes sure we don't introduce breaking code that breaks
lower Spark versio
advancedxy commented on code in PR #153:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/153#discussion_r1509989272
##
.github/workflows/pr_build.yml:
##
@@ -44,13 +44,14 @@ jobs:
os: [ubuntu-latest]
java_version: [8, 11, 17]
test-target: [
advancedxy commented on PR #153:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/153#issuecomment-1974823572
cc @sunchao @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
yyy1000 commented on PR #9395:
URL:
https://github.com/apache/arrow-datafusion/pull/9395#issuecomment-1974825842
> @yyy1000 We do still need to handle serde for physical expressions as
well. This would follow the same pattern as for logical expressions.
>
> We can either do that here
alamb commented on PR #9333:
URL:
https://github.com/apache/arrow-datafusion/pull/9333#issuecomment-1974832950
> and please squash commit on merge, thanks
Yes, this will be done (as on all commits)
--
This is an automated message from the Apache Git Service.
To respond to the messa
andygrove commented on issue #8754:
URL:
https://github.com/apache/arrow-datafusion/issues/8754#issuecomment-1974833213
This issue can be closed now because we are going with the new top-level
Apache DataFusion logo instead
(https://github.com/apache/arrow-datafusion/issues/8788).
--
Th
andygrove closed issue #8754: Add trademark symbol to DataFusion logo
URL: https://github.com/apache/arrow-datafusion/issues/8754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
andygrove merged PR #9385:
URL: https://github.com/apache/arrow-datafusion/pull/9385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove closed issue #8788: Create new logo for Apache DataFusion
URL: https://github.com/apache/arrow-datafusion/issues/8788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
thinkharderdev commented on PR #9395:
URL:
https://github.com/apache/arrow-datafusion/pull/9395#issuecomment-1974834031
> > @yyy1000 We do still need to handle serde for physical expressions as
well. This would follow the same pattern as for logical expressions.
>
> >
>
> > W
thinkharderdev closed issue #8706: Handle Serde for Custom `ScalarUDFImpl`
traits
URL: https://github.com/apache/arrow-datafusion/issues/8706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
thinkharderdev merged PR #9395:
URL: https://github.com/apache/arrow-datafusion/pull/9395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
alamb commented on PR #9395:
URL:
https://github.com/apache/arrow-datafusion/pull/9395#issuecomment-1974834446
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
alamb commented on PR #9426:
URL:
https://github.com/apache/arrow-datafusion/pull/9426#issuecomment-1974835758
> Please forgive me for adding some negative tests at will. I am not sure
whether it is appropriate to add negative tests to scalar.slt. I am compiling a
negative test document ab
alamb merged PR #9426:
URL: https://github.com/apache/arrow-datafusion/pull/9426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb commented on PR #9077:
URL:
https://github.com/apache/arrow-datafusion/pull/9077#issuecomment-1974836161
Now that @Omega359 started moving the date time functions to
`datafusion-functions` perhaps you can follow the same pattern for
`to_unixtime` 🤔
--
This is an automated messag
alamb commented on PR #9188:
URL:
https://github.com/apache/arrow-datafusion/pull/9188#issuecomment-1974836633
This thing is crazy complicated -- I don't plan to pursue it unless there is
a real need to improve this performance
--
This is an automated message from the Apache Git Service.
alamb closed pull request #9188: Implement streaming for specialized group by
string aggregator
URL: https://github.com/apache/arrow-datafusion/pull/9188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb closed pull request #9101: WIP Move regexp_match functions into
datafusion-functions
URL: https://github.com/apache/arrow-datafusion/pull/9101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb commented on PR #9101:
URL:
https://github.com/apache/arrow-datafusion/pull/9101#issuecomment-1974836692
Being covered by other PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Tangruilin commented on PR #9077:
URL:
https://github.com/apache/arrow-datafusion/pull/9077#issuecomment-1974836640
> Now that @Omega359 started moving the date time functions to
`datafusion-functions` perhaps you can follow the same pattern for
`to_unixtime` 🤔
I see that.
I
alamb closed pull request #9222: Move `make_array`, `array_{intersect, union,
distinct} to `datafusion-functions-array`
URL: https://github.com/apache/arrow-datafusion/pull/9222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
alamb merged PR #9414:
URL: https://github.com/apache/arrow-datafusion/pull/9414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb commented on PR #9414:
URL:
https://github.com/apache/arrow-datafusion/pull/9414#issuecomment-1974836940
Thanks again @mustafasrepo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
yyy1000 opened a new issue, #9428:
URL: https://github.com/apache/arrow-datafusion/issues/9428
### Is your feature request related to a problem or challenge?
As the comment by @thinkharderdev in
https://github.com/apache/arrow-datafusion/pull/9395#pullrequestreview-1912647814
> We
yyy1000 commented on issue #9428:
URL:
https://github.com/apache/arrow-datafusion/issues/9428#issuecomment-1974837404
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
yyy1000 commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r150190
##
datafusion/functions/src/regex/regexplike.rs:
##
@@ -0,0 +1,252 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
yyy1000 commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r150190
##
datafusion/functions/src/regex/regexplike.rs:
##
@@ -0,0 +1,252 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
devinjdangelo commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r150834
##
datafusion/core/src/datasource/file_format/parquet.rs:
##
@@ -952,31 +932,21 @@ async fn concatenate_parallel_row_groups(
let mut row_count = 0;
ZhangHuiGui commented on code in PR #40200:
URL: https://github.com/apache/arrow/pull/40200#discussion_r1510002479
##
cpp/src/arrow/compute/expression_internal.h:
##
@@ -278,8 +278,11 @@ struct FlattenedAssociativeChain {
inline Result> GetFunction(
const Expression::Cal
mapleFU commented on issue #39227:
URL: https://github.com/apache/arrow/issues/39227#issuecomment-1974846463
@pitrou Yeah I understand your meaning. Previously I make it wrong, it uses
bool type here:
https://github.com/apache/arrow/blob/main/cpp/src/parquet/arrow/reader_internal.cc#L361
devinjdangelo commented on PR #9422:
URL:
https://github.com/apache/arrow-datafusion/pull/9422#issuecomment-1974846550
Also be aware #9414 was recently merged and caused some conflicts since
`SpawnedTask` was moved.
--
This is an automated message from the Apache Git Service.
To respond
DDtKey commented on PR #9422:
URL:
https://github.com/apache/arrow-datafusion/pull/9422#issuecomment-1974847335
> Also be aware https://github.com/apache/arrow-datafusion/pull/9414 was
recently merged and caused some conflicts since SpawnedTask was moved.
Thanks! Rebased from onto ma
andygrove opened a new pull request, #599:
URL: https://github.com/apache/arrow-datafusion-python/pull/599
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing c
jonkeane opened a new pull request, #40321:
URL: https://github.com/apache/arrow/pull/40321
### Rationale for this change
I'll make an issue if this works
### What changes are included in this PR?
Replace `library/r-base` with `rocker/r-ver` to see if that is more stable
github-actions[bot] commented on PR #40321:
URL: https://github.com/apache/arrow/pull/40321#issuecomment-1974852112
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
jonkeane commented on PR #40321:
URL: https://github.com/apache/arrow/pull/40321#issuecomment-1974852255
@github-actions crossbow submit test-r-minimal-build test-r-offline-minimal
test-r-depsource-bundled
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on PR #40321:
URL: https://github.com/apache/arrow/pull/40321#issuecomment-1974852950
Revision: 31dae1a3aa9552e2519d94446dd4a7133b272793
Submitted crossbow builds: [ursacomputing/crossbow @
actions-f6184930e1](https://github.com/ursacomputing/crossbow/bra
andygrove opened a new issue, #600:
URL: https://github.com/apache/arrow-datafusion-python/issues/600
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
Python 3.11 is not currently supported
**Describe the solution you'd like*
alamb commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510006631
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the res
alamb commented on code in PR #9425:
URL: https://github.com/apache/arrow-datafusion/pull/9425#discussion_r1510006973
##
datafusion/functions-array/src/kernels.rs:
##
@@ -319,3 +316,125 @@ pub fn gen_range(
)?);
Ok(arr)
}
+
+/// Returns the length of each array dimens
alamb commented on PR #9425:
URL:
https://github.com/apache/arrow-datafusion/pull/9425#issuecomment-1974855011
Looks like there is a conflict that needs to be resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb commented on code in PR #9420:
URL: https://github.com/apache/arrow-datafusion/pull/9420#discussion_r1510007573
##
datafusion/functions-array/Cargo.toml:
##
@@ -38,7 +38,8 @@ path = "src/lib.rs"
[dependencies]
arrow = { workspace = true }
-datafusion-common = { workspa
Lordworms commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r1510008598
##
datafusion/functions/src/regex/regexplike.rs:
##
@@ -0,0 +1,252 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
Lordworms commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r1510008639
##
datafusion/physical-expr/Cargo.toml:
##
@@ -61,6 +61,7 @@ chrono = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
alamb commented on code in PR #9407:
URL: https://github.com/apache/arrow-datafusion/pull/9407#discussion_r1510008892
##
datafusion/sql/src/planner.rs:
##
@@ -85,6 +85,10 @@ pub trait ContextProvider {
/// Get configuration options
fn options(&self) -> &ConfigOptions
Lordworms commented on code in PR #9420:
URL: https://github.com/apache/arrow-datafusion/pull/9420#discussion_r1510009155
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -5549,26 +5549,32 @@ from arrays_range;
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9] [3, 4, 5, 6, 7, 8, 9] [3, 5, 7
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510009377
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
alamb commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r1510009696
##
datafusion/physical-expr/benches/regexp.rs:
##
@@ -23,15 +23,12 @@ use std::sync::Arc;
use arrow_array::builder::StringBuilder;
use arrow_array::{ArrayRef,
alamb commented on PR #9420:
URL:
https://github.com/apache/arrow-datafusion/pull/9420#issuecomment-1974860157
Bonus points for updating the docs to mention the new support:
https://arrow.apache.org/datafusion/user-guide/sql/scalar_functions.html#range
(we can do this as a follow on
epompeii commented on issue #5504:
URL:
https://github.com/apache/arrow-datafusion/issues/5504#issuecomment-1974860217
@gruuya I would be more than happy to help with the integration of Bencher,
which could actually help with both 1. and 2.
I set up a similar approach to 1. for Diesel re
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510010180
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510010180
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
alamb commented on code in PR #9396:
URL: https://github.com/apache/arrow-datafusion/pull/9396#discussion_r1510010540
##
datafusion/physical-expr/src/functions.rs:
##
@@ -2628,6 +2530,87 @@ mod tests {
Int32Array
);
#[cfg(feature = "unicode_express
alamb commented on PR #9385:
URL:
https://github.com/apache/arrow-datafusion/pull/9385#issuecomment-1974862035
👏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510009377
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510012535
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510012535
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510012535
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510009377
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
DDtKey commented on code in PR #9422:
URL: https://github.com/apache/arrow-datafusion/pull/9422#discussion_r1510009377
##
datafusion/common_runtime/src/common.rs:
##
@@ -51,10 +51,22 @@ impl SpawnedTask {
Self { inner }
}
+/// Joins the task, returning the re
Lordworms commented on PR #9420:
URL:
https://github.com/apache/arrow-datafusion/pull/9420#issuecomment-1974865617
> Bonus points for updating the docs to mention the new support for date:
https://arrow.apache.org/datafusion/user-guide/sql/scalar_functions.html#range
>
> (we can do t
Lordworms commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r1510013557
##
datafusion/physical-expr/Cargo.toml:
##
@@ -61,6 +61,7 @@ chrono = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
Lordworms commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r1510013736
##
datafusion/physical-expr/benches/regexp.rs:
##
@@ -23,15 +23,12 @@ use std::sync::Arc;
use arrow_array::builder::StringBuilder;
use arrow_array::{ArrayR
lidavidm commented on code in PR #40243:
URL: https://github.com/apache/arrow/pull/40243#discussion_r1510013638
##
format/FlightSql.proto:
##
@@ -1797,6 +1797,15 @@ message DoPutUpdateResult {
int64 record_count = 1;
}
+// An optional response returned when `DoPut` is call
SuperSandro2000 opened a new pull request, #40322:
URL: https://github.com/apache/arrow/pull/40322
sysconfig is available since Python 3.2
Tested on nixpkgs and works as expected
### Rationale for this change
Support Python 3.12
### What changes
github-actions[bot] commented on PR #40322:
URL: https://github.com/apache/arrow/pull/40322#issuecomment-1974866490
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
mweinelt commented on code in PR #40322:
URL: https://github.com/apache/arrow/pull/40322#discussion_r1510015008
##
cpp/cmake_modules/FindPython3Alt.cmake:
##
@@ -67,7 +67,7 @@ get_target_property(NUMPY_INCLUDE_DIRS Python3::NumPy
INTERFACE_INCLUDE_DIRECTOR
# detect it ourselve
comphead commented on code in PR #151:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/151#discussion_r1510016183
##
.github/workflows/pr_build.yml:
##
@@ -126,3 +126,17 @@ jobs:
- if: matrix.test-target == 'java'
name: Java test steps
uses:
comphead commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1510016373
##
datafusion/core/tests/sql/sql_api.rs:
##
@@ -16,6 +16,7 @@
// under the License.
use datafusion::prelude::*;
+
use tempfile::TempDir;
Review Commen
comphead commented on code in PR #9333:
URL: https://github.com/apache/arrow-datafusion/pull/9333#discussion_r1510016448
##
datafusion/core/src/execution/context/mod.rs:
##
@@ -794,6 +797,55 @@ impl SessionContext {
Ok(false)
}
+async fn create_function(&self
Lordworms commented on code in PR #9397:
URL: https://github.com/apache/arrow-datafusion/pull/9397#discussion_r1510016507
##
datafusion/physical-expr/benches/regexp.rs:
##
@@ -78,20 +74,6 @@ fn flags(rng: &mut ThreadRng) -> StringArray {
}
fn criterion_benchmark(c: &mut Crit
lidavidm opened a new pull request, #1586:
URL: https://github.com/apache/arrow-adbc/pull/1586
Fixes #1476.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
1 - 100 of 221 matches
Mail list logo
