Re: [PR] GH-44985: [C++] Use recommended downloads URLs for ORC and Thrift [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44977: URL: https://github.com/apache/arrow/pull/44977#issuecomment-2579379026 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5a042fc4a00cf832d3ce4fd92712af38122a3456. There was 1 b

Re: [PR] MINOR: [Dev] Fix handling minor issues on Dev PR worflow [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44987: URL: https://github.com/apache/arrow/pull/44987#issuecomment-2579376131 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9d57a252ec7f91a341ae724b51bd1160b9bf6b55. There were no

Re: [PR] GH-44976: [C++] Enable mimalloc by default, disable jemalloc by default and more [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44951: URL: https://github.com/apache/arrow/pull/44951#issuecomment-2579373020 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b907c5dadb516b525c8fafbf34b0116d44044733. There were no

Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]

2025-01-08 Thread via GitHub
zanmato1984 commented on PR #45210: URL: https://github.com/apache/arrow/pull/45210#issuecomment-2579367945 cc @kou @wgtmac . My apology for not thoroughly testing my last PR and having to make this patch. Would you please take a look again? Thanks. -- This is an automated message from th

Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #45210: URL: https://github.com/apache/arrow/pull/45210#issuecomment-2579366374 :warning: GitHub issue #45209 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]

2025-01-08 Thread via GitHub
zanmato1984 opened a new pull request, #45210: URL: https://github.com/apache/arrow/pull/45210 ### Rationale for this change I gave the reason in #45209 ### What changes are included in this PR? Respect the cmake policy of resolving conflict variables from

Re: [PR] GH-45201: [C++][Parquet] Improve performance of generating size statistics [arrow]

2025-01-08 Thread via GitHub
mapleFU commented on code in PR #45202: URL: https://github.com/apache/arrow/pull/45202#discussion_r1908106005 ## cpp/src/parquet/column_writer.cc: ## @@ -1468,42 +1468,43 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter< // which case we ca

Re: [PR] GH-45201: [C++][Parquet] Improve performance of generating size statistics [arrow]

2025-01-08 Thread via GitHub
pitrou commented on code in PR #45202: URL: https://github.com/apache/arrow/pull/45202#discussion_r1908281821 ## cpp/src/parquet/size_statistics.cc: ## @@ -91,4 +100,83 @@ std::unique_ptr SizeStatistics::Make(const ColumnDescriptor* des return size_stats; } +std::ostream&

Re: [PR] GH-45201: [C++][Parquet] Improve performance of generating size statistics [arrow]

2025-01-08 Thread via GitHub
pitrou commented on code in PR #45202: URL: https://github.com/apache/arrow/pull/45202#discussion_r1908280590 ## cpp/src/parquet/column_writer.cc: ## @@ -1468,42 +1468,43 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter< // which case we cal

Re: [PR] GH-45201: [C++][Parquet] Improve performance of generating size statistics [arrow]

2025-01-08 Thread via GitHub
pitrou commented on code in PR #45202: URL: https://github.com/apache/arrow/pull/45202#discussion_r1908281280 ## cpp/src/parquet/size_statistics.cc: ## @@ -91,4 +100,83 @@ std::unique_ptr SizeStatistics::Make(const ColumnDescriptor* des return size_stats; } +std::ostream&

[PR] add guidelines for choosing panics or error results [arrow-rs]

2025-01-08 Thread via GitHub
jp0317 opened a new pull request, #6958: URL: https://github.com/apache/arrow-rs/pull/6958 # Which issue does this PR close? Closes #6737 # Rationale for this change Add guidelines as per discussed in #6737 # What changes are included in this PR? guidelines

[PR] GH-494: [Flight] Improve handling of unreachable locations in JDBC [arrow-java]

2025-01-08 Thread via GitHub
lidavidm opened a new pull request, #495: URL: https://github.com/apache/arrow-java/pull/495 - Expose gRPC for the client builder - Cache failed locations and try them last - Allow configuring the connect timeout via `connectTimeoutMs` and the client cache via `useClientCache` F

Re: [PR] test(c): don't use sketchy cast to test backwards compatibility [arrow-adbc]

2025-01-08 Thread via GitHub
lidavidm merged PR #2425: URL: https://github.com/apache/arrow-adbc/pull/2425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [I] [C++][CMake] Consider adding cmake presets for sanitizer builds [arrow]

2025-01-08 Thread via GitHub
zanmato1984 commented on issue #45206: URL: https://github.com/apache/arrow/issues/45206#issuecomment-2579242606 Issue resolved by pull request 45207 https://github.com/apache/arrow/pull/45207 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] GH-45206: [C++][CMake] Add sanitizer presets [arrow]

2025-01-08 Thread via GitHub
zanmato1984 merged PR #45207: URL: https://github.com/apache/arrow/pull/45207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] GH-45206: [C++][CMake] Add sanitizer presets [arrow]

2025-01-08 Thread via GitHub
zanmato1984 commented on PR #45207: URL: https://github.com/apache/arrow/pull/45207#issuecomment-2579241937 The CI failures are unrelated. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Enhance sanity check on Parquet metadata [arrow-rs]

2025-01-08 Thread via GitHub
jp0317 commented on issue #6228: URL: https://github.com/apache/arrow-rs/issues/6228#issuecomment-2579219891 > close this ticket sure, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GH-40797: [Python] Additional functionality to concat_tables [arrow]

2025-01-08 Thread via GitHub
killakill0101 closed pull request #41161: GH-40797: [Python] Additional functionality to concat_tables URL: https://github.com/apache/arrow/pull/41161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] test(c): don't use sketchy cast to test backwards compatibility [arrow-adbc]

2025-01-08 Thread via GitHub
lidavidm commented on code in PR #2425: URL: https://github.com/apache/arrow-adbc/pull/2425#discussion_r1908136379 ## docker-compose.yml: ## @@ -38,10 +38,21 @@ services: context: . dockerfile: ci/docker/cpp-clang-latest.dockerfile args: -VCPKG: ${VC

Re: [PR] test(c): don't use sketchy cast to test backwards compatibility [arrow-adbc]

2025-01-08 Thread via GitHub
lidavidm commented on code in PR #2425: URL: https://github.com/apache/arrow-adbc/pull/2425#discussion_r1908136023 ## docker-compose.yml: ## @@ -38,10 +38,21 @@ services: context: . dockerfile: ci/docker/cpp-clang-latest.dockerfile args: -VCPKG: ${VC

Re: [I] [C++][CMake] Consider adding cmake presets for sanitizer builds [arrow]

2025-01-08 Thread via GitHub
zanmato1984 commented on issue #45206: URL: https://github.com/apache/arrow/issues/45206#issuecomment-2579135779 > That's what `CMakeUserPresets.json` is for! It's already in the gitignore and should also be picked up by vsc. > > But regardless a preset for sanitizers makes sense :)

Re: [PR] feat(parquet): Add support for Page Indexes [arrow-go]

2025-01-08 Thread via GitHub
lidavidm commented on code in PR #223: URL: https://github.com/apache/arrow-go/pull/223#discussion_r1908130718 ## parquet/metadata/page_index.go: ## @@ -0,0 +1,889 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

Re: [I] [C++][CMake] Consider adding cmake presets for sanitizer builds [arrow]

2025-01-08 Thread via GitHub
assignUser commented on issue #45206: URL: https://github.com/apache/arrow/issues/45206#issuecomment-2579130077 > manually modify CMakePresets.json file to add a temporary preset with necessary sanitizer variables (and carefully avoid including this changes along with other intended changes

Re: [PR] GH-44513: [C++] Fix overflow issues for large build side in swiss join [arrow]

2025-01-08 Thread via GitHub
zanmato1984 commented on code in PR #45108: URL: https://github.com/apache/arrow/pull/45108#discussion_r1908132326 ## cpp/src/arrow/compute/key_map_internal_avx2.cc: ## @@ -392,16 +392,32 @@ int SwissTable::extract_group_ids_avx2(const int num_keys, const uint32_t* hashe } e

Re: [PR] GH-45206: [C++][CMake] Add sanitizer presets [arrow]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #45207: URL: https://github.com/apache/arrow/pull/45207#issuecomment-2579128181 Revision: d575a47f1db39b1a89b84bb7e92c134388c7c822 Submitted crossbow builds: [ursacomputing/crossbow @ actions-764caeec7d](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45206: [C++][CMake] Add sanitizer presets [arrow]

2025-01-08 Thread via GitHub
zanmato1984 commented on PR #45207: URL: https://github.com/apache/arrow/pull/45207#issuecomment-2579126509 @github-actions crossbow submit -g cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [C++][Parquet] Limit RowGroup num to i16 during writing [arrow]

2025-01-08 Thread via GitHub
mapleFU commented on issue #44042: URL: https://github.com/apache/arrow/issues/44042#issuecomment-2579119347 Still open, sorry I'll move forward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] test(c): don't use sketchy cast to test backwards compatibility [arrow-adbc]

2025-01-08 Thread via GitHub
kou commented on code in PR #2425: URL: https://github.com/apache/arrow-adbc/pull/2425#discussion_r1908123793 ## docker-compose.yml: ## @@ -38,10 +38,21 @@ services: context: . dockerfile: ci/docker/cpp-clang-latest.dockerfile args: -VCPKG: ${VCPKG}

Re: [I] [C++][Parquet] Limit RowGroup num to i16 during writing [arrow]

2025-01-08 Thread via GitHub
curioustien commented on issue #44042: URL: https://github.com/apache/arrow/issues/44042#issuecomment-2579093784 @mapleFU Is it still open? I'd like to take a stab at it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] GH-45201: [C++][Parquet] Improve performance of generating size statistics [arrow]

2025-01-08 Thread via GitHub
mapleFU commented on code in PR #45202: URL: https://github.com/apache/arrow/pull/45202#discussion_r1908106005 ## cpp/src/parquet/column_writer.cc: ## @@ -1468,42 +1468,43 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter< // which case we ca

Re: [PR] GH-45206: [C++][CMake] Add sanitizer cmake presets [arrow]

2025-01-08 Thread via GitHub
zanmato1984 commented on code in PR #45207: URL: https://github.com/apache/arrow/pull/45207#discussion_r1908101346 ## cpp/CMakePresets.json: ## @@ -527,16 +554,45 @@ "displayName": "Benchmarking build with everything enabled", "cacheVariables": {} }, +{ +

Re: [PR] GH-45206: [C++][CMake] Add sanitizer cmake presets [arrow]

2025-01-08 Thread via GitHub
zanmato1984 commented on PR #45207: URL: https://github.com/apache/arrow/pull/45207#issuecomment-2579074971 Hi @kou @pitrou @mapleFU , does this make sense to you? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] GH-45206: [C++][CMake] Add sanitizer cmake presets [arrow]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #45207: URL: https://github.com/apache/arrow/pull/45207#issuecomment-2579074954 :warning: GitHub issue #45206 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-45206: [C++][CMake] Add sanitizer cmake presets [arrow]

2025-01-08 Thread via GitHub
zanmato1984 opened a new pull request, #45207: URL: https://github.com/apache/arrow/pull/45207 ### Rationale for this change See #45206 ### What changes are included in this PR? Add base presets for ASAN/TSAN/UBSAN. And cross product such base presets by

Re: [PR] GH-44513: [C++] Fix overflow issues for large build side in swiss join [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #45108: URL: https://github.com/apache/arrow/pull/45108#issuecomment-2579061893 Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 4462ceb7a464ab61319fa67c725561af67896bc9. There were 29

Re: [PR] GH-44952: [C++][Python] Add Hyperbolic Trig functions [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44630: URL: https://github.com/apache/arrow/pull/44630#issuecomment-2579061406 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 104b0406ab7e6bfc296f64649a6a71314436f06e. There were no

Re: [PR] test(c): don't use sketchy cast to test backwards compatibility [arrow-adbc]

2025-01-08 Thread via GitHub
kou commented on code in PR #2425: URL: https://github.com/apache/arrow-adbc/pull/2425#discussion_r1908081775 ## .github/workflows/nightly-verify.yml: ## @@ -190,6 +190,11 @@ jobs: pushd arrow-adbc docker compose run --rm cpp-clang-latest + - name: c

Re: [PR] GH-45201: [C++][Parquet] Improve performance of generating size statistics [arrow]

2025-01-08 Thread via GitHub
wgtmac commented on code in PR #45202: URL: https://github.com/apache/arrow/pull/45202#discussion_r1908070840 ## cpp/src/parquet/size_statistics.cc: ## @@ -91,4 +100,83 @@ std::unique_ptr SizeStatistics::Make(const ColumnDescriptor* des return size_stats; } +std::ostream&

Re: [PR] GH-45201: [C++][Parquet] Improve performance of generating size statistics [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #45202: URL: https://github.com/apache/arrow/pull/45202#issuecomment-2578994560 Thanks for your patience. Conbench analyzed the 2 benchmarking runs that have been run so far on PR commit e67472b946bec531f3ce34067e177534cebfb390. There weren't

Re: [PR] GH-44974: [Dev] Fix minor issue handling [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44975: URL: https://github.com/apache/arrow/pull/44975#issuecomment-2578994442 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f1b293d70e725f51f67e5df541b6d87a175edf68. There were no

Re: [PR] Faster parquet utf8 validation using `simdjson` [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on code in PR #6668: URL: https://github.com/apache/arrow-rs/pull/6668#discussion_r1908033297 ## parquet/src/arrow/array_reader/byte_view_array.rs: ## @@ -679,9 +679,12 @@ impl ByteViewArrayDecoderDelta { /// Check that `val` is a valid UTF-8 sequence pub fn

[PR] test(c): don't use sketchy cast to test backwards compatibility [arrow-adbc]

2025-01-08 Thread via GitHub
lidavidm opened a new pull request, #2425: URL: https://github.com/apache/arrow-adbc/pull/2425 - Backport nanoarrow patch to satisfy newer Clang - Add test using GCC 15 - Update tests using sketchy casts to satisfy these compilers - Refactor the clang/gcc Docker jobs Fixes #24

Re: [I] c: error: allocation of insufficient size with GCC 14 [arrow-adbc]

2025-01-08 Thread via GitHub
kou commented on issue #2424: URL: https://github.com/apache/arrow-adbc/issues/2424#issuecomment-2578933936 Ah, it's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
kou commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578931535 > Hmm. verify-rc-source-python-macos-conda-amd64 isn't failed in nightly build with this error. This error may be transient or caused by a conda package problem. I re-run the job: https://gi

Re: [PR] Faster parquet utf8 validation using `simdjson` [arrow-rs]

2025-01-08 Thread via GitHub
etseidl commented on code in PR #6668: URL: https://github.com/apache/arrow-rs/pull/6668#discussion_r1907995431 ## parquet/src/arrow/array_reader/byte_view_array.rs: ## @@ -679,9 +679,12 @@ impl ByteViewArrayDecoderDelta { /// Check that `val` is a valid UTF-8 sequence pub f

Re: [PR] Faster parquet utf8 validation using `simdjson` [arrow-rs]

2025-01-08 Thread via GitHub
etseidl commented on PR #6668: URL: https://github.com/apache/arrow-rs/pull/6668#issuecomment-2578891295 > @etseidl I wonder if you have any thoughts on this PR? None that haven't already been voiced. It seems like a fairly low risk (especially if made optional) way to get a significa

Re: [PR] [Parquet] Fix slow dictionary encoding of NaN float values [arrow-rs]

2025-01-08 Thread via GitHub
adamreeve commented on PR #6953: URL: https://github.com/apache/arrow-rs/pull/6953#issuecomment-2578887593 OK I've rebased this now and switched to comparing byte representations for all types rather than needing a new trait, which is a simpler solution and is consistent with how values are

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
amoeba commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578886138 Thanks @kou > Hmm. verify-rc-source-python-macos-conda-amd64 isn't failed in nightly build with this error. I also ran the job on my crossbow queue and it succeeds. It's str

Re: [I] c: error: allocation of insufficient size with GCC 14 [arrow-adbc]

2025-01-08 Thread via GitHub
lidavidm commented on issue #2424: URL: https://github.com/apache/arrow-adbc/issues/2424#issuecomment-2578873652 Maybe I can change it to allocate the full struct and just check that the new fields were not touched? -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
raulcd commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578859247 I think we might have some possible leaks on parquet encryption based on the valgrind failures that we should investigate. -- This is an automated message from the Apache Git Service. To

Re: [PR] Add `peek_next_page_offset` to `SerializedPageReader` [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on PR #6945: URL: https://github.com/apache/arrow-rs/pull/6945#issuecomment-2578844356 I'll plan to merge this PR tomorrow unless anyone else would like some time to reivew -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578838099 Revision: 77b39d7f0715db3c4ecd996c59fa94dbbe9223ed Submitted crossbow builds: [ursacomputing/crossbow @ actions-e6674a8807](https://github.com/ursacomputing/crossbow/bra

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
raulcd commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578835271 @github-actions crossbow submit test-conda-cpp-valgrind -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] 1. user can choose to show nested type when write to csv 2. Add features to show struct type data as json format [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on PR #6950: URL: https://github.com/apache/arrow-rs/pull/6950#issuecomment-2578821476 Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look -- This is an automated message from the Apach

Re: [PR] 1. user can choose to show nested type when write to csv 2. Add features to show struct type data as json format [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on PR #6950: URL: https://github.com/apache/arrow-rs/pull/6950#issuecomment-2578819704 I think this pR would also need some tests that show what it is attemping to do. But in general I agree with @tustvold that the idea of writing structured data to CSV is likely not

[PR] [53.0.0_maintenance] [arrow-cast] Support cast boolean from/to string view (#6822) [arrow-rs]

2025-01-08 Thread via GitHub
alamb opened a new pull request, #6957: URL: https://github.com/apache/arrow-rs/pull/6957 Draft as it - builds on https://github.com/apache/arrow-rs/pull/6956 # Which issue does this PR close? - Part of https://github.com/apache/arrow-rs/issues/6887 # Rationale fo

[PR] [53.0.0_maintenance] Enable matching temporal as from_type to Utf8View (#6872) [arrow-rs]

2025-01-08 Thread via GitHub
alamb opened a new pull request, #6956: URL: https://github.com/apache/arrow-rs/pull/6956 # Which issue does this PR close? - Part of https://github.com/apache/arrow-rs/issues/6887 # Rationale for this change Backport some specific fixes to the 53 line for a maintena

Re: [PR] [53.0.0_maintenance] [arrow-cast] Support cast numeric to string view (alternate) (#6816) [arrow-rs]

2025-01-08 Thread via GitHub
alamb merged PR #6944: URL: https://github.com/apache/arrow-rs/pull/6944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [PR] [Parquet] Fix slow dictionary encoding of NaN float values [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on PR #6953: URL: https://github.com/apache/arrow-rs/pull/6953#issuecomment-2578805209 > > Thank you @adamreeve -- is there any chance you could break out the benchmark into its own PR so it is easier to compare the before/after performance of this change? > > Sure, I

Re: [PR] [53.0.0_maintenance] fix: Encoding of List offsets was incorrect when slice offsets begin [arrow-rs]

2025-01-08 Thread via GitHub
alamb merged PR #6943: URL: https://github.com/apache/arrow-rs/pull/6943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [PR] [53.0.0_maintenance] fix: Encoding of List offsets was incorrect when slice offsets begin [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on PR #6943: URL: https://github.com/apache/arrow-rs/pull/6943#issuecomment-2578788549 Since this is a cherry-pick of a previously approved PR I am going to merge it in and anyone can review if they want as part of the release approval process. -- This is an automated mes

Re: [PR] [53.0.0_maintenance] [arrow-cast] Support cast numeric to string view (alternate) (#6816) [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on PR #6944: URL: https://github.com/apache/arrow-rs/pull/6944#issuecomment-2578788932 Since this is a cherry-pick of a previously approved PR I am going to merge it in and anyone can review if they want as part of the release approval process. -- This is an automated mes

Re: [PR] [Parquet] Add benchmark and test for writing NaNs to Parquet [arrow-rs]

2025-01-08 Thread via GitHub
alamb merged PR #6955: URL: https://github.com/apache/arrow-rs/pull/6955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
kou commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578740453 Hmm. verify-rc-source-python-macos-conda-amd64 isn't failed in nightly build with this error. This error may be transient or caused by a conda package problem. I re-run the job: https://git

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
kou commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578732728 > Altogether, none of the current failures look like we need to delay cutting a release candidate I agree with you but we may be able to fix the verify-rc-source-python-macos-conda-amd

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
kou commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578730090 The verify-rc-source-python-macos-conda-amd64 failure: https://github.com/ursacomputing/crossbow/actions/runs/12658197249/job/35274591929#step:6:1653 ```text [ 58%] Linking CX

[PR] Test removing gold file skips in Archery (do not merge) [arrow-nanoarrow]

2025-01-08 Thread via GitHub
paleolimbot opened a new pull request, #704: URL: https://github.com/apache/arrow-nanoarrow/pull/704 Test of https://github.com/apache/arrow/pull/45205 , which removes the compression skips in the integration test job (except for lz4, which we don't support) -- This is an automated messa

Re: [I] [C++] version script assignment of 'local' to symbol '__once_proxy' failed: symbol not defined [arrow]

2025-01-08 Thread via GitHub
kou commented on issue #43355: URL: https://github.com/apache/arrow/issues/43355#issuecomment-2578704866 Could you open a PR with the patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] chore(ci): Stop skipping Rust integration tests [arrow-nanoarrow]

2025-01-08 Thread via GitHub
paleolimbot merged PR #703: URL: https://github.com/apache/arrow-nanoarrow/pull/703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

Re: [I] Add benchmark CI: Debian [arrow-go]

2025-01-08 Thread via GitHub
kou commented on issue #85: URL: https://github.com/apache/arrow-go/issues/85#issuecomment-2578698608 Correct. But we need help from others: * We need to set secrets for `CONBENCH_EMAIL` and `CONBENCH_PASSWORD` to apache/arrow-go * We need to confirm that apache/arrow-go can use

Re: [I] [C++] version script assignment of 'local' to symbol '__once_proxy' failed: symbol not defined [arrow]

2025-01-08 Thread via GitHub
spchamp commented on issue #43355: URL: https://github.com/apache/arrow/issues/43355#issuecomment-2578694999 It seems there's a similar expression is an other file, `cpp/src/parquet/symbols.map` ```diff --- a/cpp/src/parquet/symbols.map +++ b/cpp/src/parquet/symbols.map @@ -2

Re: [PR] Improve `ParquetRecordBatchStreamBuilder` docs / examples [arrow-rs]

2025-01-08 Thread via GitHub
alamb commented on code in PR #6948: URL: https://github.com/apache/arrow-rs/pull/6948#discussion_r1907865637 ## parquet/src/arrow/async_reader/mod.rs: ## @@ -15,65 +15,13 @@ // specific language governing permissions and limitations // under the License. -//! Provides `asyn

Re: [PR] [Parquet] Fix slow dictionary encoding of NaN float values [arrow-rs]

2025-01-08 Thread via GitHub
adamreeve commented on PR #6953: URL: https://github.com/apache/arrow-rs/pull/6953#issuecomment-2578662372 > Thank you @adamreeve -- is there any chance you could break out the benchmark into its own PR so it is easier to compare the before/after performance of this change? Sure, I'v

[PR] [Parquet] Add benchmark and test for writing NaNs to Parquet [arrow-rs]

2025-01-08 Thread via GitHub
adamreeve opened a new pull request, #6955: URL: https://github.com/apache/arrow-rs/pull/6955 # Which issue does this PR close? This doesn't close an issue but adds a benchmark that should be improved when #6952 is fixed. # Rationale for this change Splits out the benc

Re: [PR] GH-44950: [C++] Bump minimum CMake version to 3.25 [arrow]

2025-01-08 Thread via GitHub
kou commented on code in PR #44989: URL: https://github.com/apache/arrow/pull/44989#discussion_r1907852286 ## .env: ## @@ -54,6 +54,7 @@ UBUNTU=22.04 # Default versions for various dependencies CLANG_TOOLS=14 +CMAKE_VERSION=3.25.0 Review Comment: Ah, I see. In gen

Re: [I] [Dev][Release] post-10-docs.sh doesn't work correctly for patch releases [arrow]

2025-01-08 Thread via GitHub
amoeba commented on issue #44887: URL: https://github.com/apache/arrow/issues/44887#issuecomment-2578626177 Thanks for explaining. I like the idea of only showing the latest release in any one major series in the drop down (i.e., only show 18.1 not 18.1 and 18.0). I think we can make

Re: [I] c: error: allocation of insufficient size with GCC 14 [arrow-adbc]

2025-01-08 Thread via GitHub
paleolimbot commented on issue #2424: URL: https://github.com/apache/arrow-adbc/issues/2424#issuecomment-2578598505 FWIW that line has caused me to have to turn of UBSAN/ASAN for my local build for quite some time (since Apple clang aborts that test at runtime if compiled with the default C

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578566955 Revision: 77b39d7f0715db3c4ecd996c59fa94dbbe9223ed Submitted crossbow builds: [ursacomputing/crossbow @ actions-4a0f2ff5a0](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45204: [Integration][Archery] Remove skips for nanoarrow IPC compression ZSTD/uncompressible golden files [arrow]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #45205: URL: https://github.com/apache/arrow/pull/45205#issuecomment-2578586106 :warning: GitHub issue #45204 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-45204: [Integration][Archery] Remove skips for nanoarrow IPC compression ZSTD/uncompressible golden files [arrow]

2025-01-08 Thread via GitHub
paleolimbot opened a new pull request, #45205: URL: https://github.com/apache/arrow/pull/45205 ### Rationale for this change After apache/arrow-nanoarrow#693 , ZSTD compression is now supported in the nanoarrow IPC reader. The list of skips lives in archery, though, and I'd like thos

Re: [PR] fix(cpp): Fix offset handling in ViewArrayAs Range Helpers [arrow-nanoarrow]

2025-01-08 Thread via GitHub
WillAyd commented on PR #702: URL: https://github.com/apache/arrow-nanoarrow/pull/702#issuecomment-2578570598 Awesome - thanks for the help on review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] How to iterate arrays with an offset? Possible ViewArrayAsBytes bug [arrow-nanoarrow]

2025-01-08 Thread via GitHub
WillAyd closed issue #701: How to iterate arrays with an offset? Possible ViewArrayAsBytes bug URL: https://github.com/apache/arrow-nanoarrow/issues/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix(cpp): Fix offset handling in ViewArrayAs Range Helpers [arrow-nanoarrow]

2025-01-08 Thread via GitHub
WillAyd merged PR #702: URL: https://github.com/apache/arrow-nanoarrow/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
amoeba commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578564205 All the packaging jobs are succeeding except for the two conan jobs. As for verification jobs, - verify-rc-source-python-macos-arm64 is re-running - verify-rc-source-python-

Re: [PR] WIP: Testing-only PR to check maint-19.0.0 status [arrow]

2025-01-08 Thread via GitHub
amoeba commented on PR #45194: URL: https://github.com/apache/arrow/pull/45194#issuecomment-2578562032 @github-actions crossbow submit verify-rc-source-python-macos-arm64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] chore(ci): Stop skipping Rust integration tests [arrow-nanoarrow]

2025-01-08 Thread via GitHub
paleolimbot opened a new pull request, #703: URL: https://github.com/apache/arrow-nanoarrow/pull/703 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] [C++] version script assignment of 'local' to symbol '__once_proxy' failed: symbol not defined [arrow]

2025-01-08 Thread via GitHub
spchamp commented on issue #43355: URL: https://github.com/apache/arrow/issues/43355#issuecomment-2578515764 I'm seeing a similar build failure when trying to build the latest pyarrow source, changeset 4ede48c89 on a FreeBSD 14 machine. The compiler is clang 18.1.5 from the FreeBSD base bas

Re: [PR] Improve `ParquetRecordBatchStreamBuilder` docs / examples [arrow-rs]

2025-01-08 Thread via GitHub
etseidl commented on code in PR #6948: URL: https://github.com/apache/arrow-rs/pull/6948#discussion_r1907717600 ## parquet/src/arrow/async_reader/mod.rs: ## @@ -249,53 +197,153 @@ impl ArrowReaderMetadata { /// breaking the pre-existing ParquetRecordBatchStreamBuilder API pub

Re: [I] [C++][Compute] Add percentile rank function [arrow]

2025-01-08 Thread via GitHub
icexelloss commented on issue #45190: URL: https://github.com/apache/arrow/issues/45190#issuecomment-2578441799 This looks good to me. One thing I might add is that there are a few different favors of percentile rank, e.g. (1) scale to 1/n+1, 2/n+1, …, n/n+1 (0-1 exclusive) (2) sca

Re: [PR] MINOR: Bump ch.qos.logback:logback-core from 1.5.12 to 1.5.13 [arrow-java]

2025-01-08 Thread via GitHub
dependabot[bot] closed pull request #459: MINOR: Bump ch.qos.logback:logback-core from 1.5.12 to 1.5.13 URL: https://github.com/apache/arrow-java/pull/459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] MINOR: Bump ch.qos.logback:logback-core from 1.5.12 to 1.5.13 [arrow-java]

2025-01-08 Thread via GitHub
dependabot[bot] commented on PR #459: URL: https://github.com/apache/arrow-java/pull/459#issuecomment-2578379654 Looks like ch.qos.logback:logback-core is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] MINOR: Bump logback.version from 1.5.12 to 1.5.16 [arrow-java]

2025-01-08 Thread via GitHub
laurentgo merged PR #481: URL: https://github.com/apache/arrow-java/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.ap

Re: [I] Add benchmark CI: Debian [arrow-go]

2025-01-08 Thread via GitHub
singh1203 commented on issue #85: URL: https://github.com/apache/arrow-go/issues/85#issuecomment-2578366867 Hello @kou, I would love to work on this issue. Looking at the description, I understand it involves implementing a benchmarking CI workflow for the arrow-go repository using Debian a

Re: [PR] MINOR: [C#] Bump Grpc.Tools from 2.67.0 to 2.68.1 in /csharp [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44979: URL: https://github.com/apache/arrow/pull/44979#issuecomment-2578345035 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit e0f8c5e8e6f8b328a997f7e21bc6fd1a01b3b3fd. There were no

Re: [PR] MINOR: [C#] Bump Google.Protobuf and System.Memory in /csharp [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44978: URL: https://github.com/apache/arrow/pull/44978#issuecomment-2578341881 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8428c47b6dc4d46d1d3839cd82d2bd39f5544a67. There were no

Re: [PR] MINOR: [R] Fix headers [arrow]

2025-01-08 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44960: URL: https://github.com/apache/arrow/pull/44960#issuecomment-2578338819 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 7c547a4b19fd42dbaafc158cf309111c8b08722a. There were no

Re: [PR] chore: Enable Java integration test [arrow-go]

2025-01-08 Thread via GitHub
zeroshade merged PR #240: URL: https://github.com/apache/arrow-go/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

Re: [PR] regenerate arrow-ipc/src/gen with patched flatbuffers [arrow-rs]

2025-01-08 Thread via GitHub
paleolimbot commented on PR #6426: URL: https://github.com/apache/arrow-rs/pull/6426#issuecomment-2578292354 Thank you all for following up on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] Interoperability between arrow-rs and nanoarrow [arrow-rs]

2025-01-08 Thread via GitHub
alamb closed issue #5052: Interoperability between arrow-rs and nanoarrow URL: https://github.com/apache/arrow-rs/issues/5052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] regenerate arrow-ipc/src/gen with patched flatbuffers [arrow-rs]

2025-01-08 Thread via GitHub
alamb merged PR #6426: URL: https://github.com/apache/arrow-rs/pull/6426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

  1   2   >