Re: What's cooking in git.git

2015-08-06 Thread Johannes Schindelin
Hi Junio, On 2015-08-06 00:55, Junio C Hamano wrote: > * sb/submodule-helper (2015-08-05) 1 commit > - submodule: implement `module_list` as a builtin helper > > The beginning of "git submodule" rewritten in C. I am really looking forward to that, with my Windows performance hat firmly on my

Re: [PATCH] git-am: add am.threeWay config variable

2015-08-07 Thread Johannes Schindelin
Hi, On 2015-08-04 16:19, Paul Tan wrote: > From: Remi Lespinet > > Add the am.threeWay configuration variable to use the -3 or --3way > option of git am by default. When am.threeway is set and not desired > for a specific git am command, the --no-3way option can be used to > override it. > > Si

Re: [PATCH v2 3/3] am: let --signoff override --no-signoff

2015-08-07 Thread Johannes Schindelin
Hi Paul, On 2015-08-04 16:08, Paul Tan wrote: > diff --git a/builtin/am.c b/builtin/am.c > index 0961304..8c95aec 100644 > --- a/builtin/am.c > +++ b/builtin/am.c > @@ -2151,8 +2169,9 @@ int cmd_am(int argc, const char **argv, const > [...] > char *prefix) > OPT_BOOL('3', "3way", &s

Re: Windows 7 - long/short and upper/lower filename

2015-08-07 Thread Johannes Schindelin
Hi, On 2015-08-03 23:18, JoséQuintas wrote: > I am using Windows 7 64 bits. ... and Git version... ? > I have a filename called ze_xmlfun.prg > Last week gitgui shows 2 changed files: ZE_XML~1.PRG and ze_xmlfun.prg > At momment I can't update this file, because get a error. > Try delete file, up

Re: wishlist: make it possible to amend commit messages after push to remote

2015-08-07 Thread Johannes Schindelin
Hi, On 2015-08-07 19:10, Jarkko Hietaniemi wrote: > But to be honest, I wasn't expecting a miracle cure. I guess the core > of my gripe is just that: how the commit message is part of the SHA. The commit message is not "part of the SHA" but it is part of the content that defines the SHA-1. I

Re: [PATCH] config.mak.uname: Cygwin: Use renames for creation

2015-08-09 Thread Johannes Schindelin
Hi Adam, On 2015-08-09 04:01, Adam Dinwoodie wrote: > I do not see any difference between the situation here and the situation > for MinGW, which is fundamentally a Cygwin fork, but which already has > this build option set for it in config.mak.uname. This is incorrect. MinGW is distinctly *not*

Re: Bug report Windows 10

2015-08-10 Thread Johannes Schindelin
Hi, On 2015-08-10 14:26, MS-Informatique wrote: > My Windows notebook got updated to Windows 10 and now my Git Bash doesn't > start and when I open an existing repository from Git Gui, I am getting next > error: > "0 [main] us 0 init_cheap: VirtualAlloc pointer is null, Win32 error 487 > Allocati

Re: File Hash for Windows executable

2015-08-10 Thread Johannes Schindelin
Hi Ryan, On 2015-08-10 15:54, Kiser, Ryan Lee wrote: > I've downloaded the Windows installer for Git, Which one. > but can't seem to find hashes published anywhere for verification. Since the > downloaded file doesn't seem to be signed, The newest ones from https://git-for-windows.github.io/

Re: [PATCH 2/2] pager_in_use: make sure output is still going to pager

2015-08-10 Thread Johannes Schindelin
Hi Peff, On 2015-08-10 07:23, Jeff King wrote: > diff --git a/compat/pipe-id.c b/compat/pipe-id.c > new file mode 100644 > index 000..4764c5f > --- /dev/null > +++ b/compat/pipe-id.c > @@ -0,0 +1,25 @@ > +#include "git-compat-util.h" > +#include "compat/pipe-id.h" > +#include "strbuf.h" > + >

Re: Question

2015-08-11 Thread Johannes Schindelin
Hi, On 2015-08-11 10:28, Jet Rey Maza wrote: > I'm wondering why gitbash dont have wget? Please take the time to write coherent questions in the future, giving enough context for others to understand what you are talking about. We are not dogs that you throw some bones, you know? We are highly

Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe

2015-08-12 Thread Johannes Schindelin
Hi Johannes, On 2015-08-11 22:51, Johannes Sixt wrote: > Invoking plink requires special treatment, and we have support and even > test cases for the commands 'plink' and 'tortoiseplink'. We also support > .exe variants for these two and there is a test for 'plink.exe'. > > On Windows, however, w

Re: [msysGit] [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows

2015-08-12 Thread Johannes Schindelin
Hi, On 2015-08-11 22:38, Johannes Sixt wrote: > diff --git a/t/t2019-checkout-ambiguous-ref.sh > b/t/t2019-checkout-ambiguous-ref.sh > index 8396320..199b22d 100755 > --- a/t/t2019-checkout-ambiguous-ref.sh > +++ b/t/t2019-checkout-ambiguous-ref.sh > @@ -69,7 +69,7 @@ test_expect_success 'wildcar

Re: [msysGit] Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe

2015-08-13 Thread Johannes Schindelin
Hi Johannes, On 2015-08-12 20:31, Johannes Sixt wrote: > Am 12.08.2015 um 13:58 schrieb Erik Faye-Lund: >> On Wed, Aug 12, 2015 at 1:07 PM, Johannes Schindelin >> wrote: >>> FWIW Git for Windows has this patch (that I wanted to contribute >>> in due time, wh

Re: [msysGit] [PATCH jk/prune-mtime] prune: close directory earlier during loose-object directory traversal

2015-08-13 Thread Johannes Schindelin
Hi, On 2015-08-12 19:43, Johannes Sixt wrote: > 27e1e22d (prune: factor out loose-object directory traversal, 2014-10-16) > introduced a new function for_each_loose_file_in_objdir() with a helper > for_each_file_in_obj_subdir(). The latter calls callbacks for each file > found during a directory t

Re: [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows

2015-08-13 Thread Johannes Schindelin
Hi Junio, On 2015-08-12 18:28, Junio C Hamano wrote: > Johannes Schindelin writes: > >> On 2015-08-11 22:38, Johannes Sixt wrote: >> >>> diff --git a/t/t2019-checkout-ambiguous-ref.sh >>> b/t/t2019-checkout-ambiguous-ref.sh >>> index 8396320..199b22

Re: [msysGit] Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe

2015-08-13 Thread Johannes Schindelin
Hi kusma, On 2015-08-12 13:58, Erik Faye-Lund wrote: > On Wed, Aug 12, 2015 at 1:07 PM, Johannes Schindelin > wrote: >> >> On 2015-08-11 22:51, Johannes Sixt wrote: >>> Invoking plink requires special treatment, and we have support and even >>> tes

Re: "git am --abort" screwing up index?

2015-08-17 Thread Johannes Schindelin
wanted to >> be doubly sure this time). But maybe it's an effect of the new >> built-in "am". > > I bisected this. It's definitely used to work, and the regression is > from the new built-in am. This patch is a reproducer: -- snipsnap -- >From 5323f1c30

Re: [PATCH] am --abort: merge ORIG_HEAD tree into index

2015-08-17 Thread Johannes Schindelin
Hi Paul, On 2015-08-17 11:48, Paul Tan wrote: > It's true that we need to merge the ORIG_HEAD tree into the index > instead of overwriting it. Patch below. Thanks for your impressive, very responsive work! Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a m

Re: [PATCH] config.mak.uname: Cygwin: Use renames for creation

2015-08-18 Thread Johannes Schindelin
Hi Adam, On 2015-08-09 19:05, Adam Dinwoodie wrote: > On 09/08/2015 10:01, Johannes Schindelin wrote: >> On 2015-08-09 04:01, Adam Dinwoodie wrote: >>> >>>> We've gotten a lot of users on the list who ask why their Git >>>> directories on shared d

Git for Windows 2.5.0

2015-08-18 Thread Johannes Schindelin
Dear Git (for Windows) users, it is my great pleasure to announce the first official version of Git for Windows. We finally have caught up with Git 2.x and are ready to leave the -preview suffix behind (more on that below). It is available at https://git-for-windows.github.io/ and also at https:

Re: No dialog box appears

2015-08-19 Thread Johannes Schindelin
Hi Aleksey, On 2015-08-19 09:33, Цапков Алексей wrote: > When installing the Git is not a dialog box appears with a choice ssh. > What could be the reason? I assume that you are referring to the Git for Windows installer (please state such details in the future). And I assume you were wondering

[PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

2015-08-22 Thread Johannes Schindelin
. So let's be graceful and just return if that data structure is `NULL`. Reported in https://github.com/msysgit/git/issues/363. Signed-off-by: Johannes Schindelin --- notes.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/notes.c b/notes.c index df08209..24a335a 1

Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

2015-08-24 Thread Johannes Schindelin
Hi Peff, On 2015-08-23 19:43, Jeff King wrote: > On Sat, Aug 22, 2015 at 05:14:39PM +0200, Johannes Schindelin wrote: > >> The `format_display_notes()` function clearly assumes that the data >> structure holding the notes has been initialized already, i.e. that the >&

Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

2015-08-24 Thread Johannes Schindelin
Hi Peff, On 2015-08-24 16:43, Jeff King wrote: > On Mon, Aug 24, 2015 at 12:23:52PM +0200, Johannes Schindelin wrote: > >> You're right. I think the best approach for now is to error out when >> `--show-notes` is passed to rev-list. Do you agree? > > Yes (I imagine

Re: [PATCH] compat/inet_ntop.c: Use INET_ADDRSTRLEN and INET6_ADDRSTRLEN macroses

2015-08-25 Thread Johannes Schindelin
Hi Kirill, On 2015-08-25 12:34, brillian...@inbox.ru wrote: > From: Brilliantov Kirill Vladimirovich > > Signed-off-by: Brilliantov Kirill Vladimirovich The commit message makes for an excellent place to fill in the reader on information that is not obvious from reading the patch. For example

Re: [PATCH 1/5] submodule: implement `module_clone` as a builtin helper

2015-08-27 Thread Johannes Schindelin
Hi Stefan, thank you so much for doing this. `git submodule` is really, really slow on Windows... On 2015-08-27 02:52, Stefan Beller wrote: > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index 4b32a3c..f11fb9c 100644 > --- a/builtin/submodule--helper.c > +++ b/builti

Re: [PATCH 2/5] thread-utils: add a threaded task queue

2015-08-27 Thread Johannes Schindelin
Hi Stefan, On 2015-08-27 02:52, Stefan Beller wrote: > diff --git a/run-command.c b/run-command.c > index 28e1d55..cb15cd9 100644 > --- a/run-command.c > +++ b/run-command.c > @@ -668,6 +668,22 @@ int git_atexit(void (*handler)(void)) > > #endif > > +void setup_main_thread(void) > [...] > >

[PATCH] Mingw: verify both ends of the pipe () call

2015-08-27 Thread Johannes Schindelin
From: jfmc The code to open and test the second end of the pipe clearly imitates the code for the first end. A little too closely, though... Let's fix the obvious copy-edit bug. Signed-off-by: Jose F. Morales Signed-off-by: Johannes Schindelin --- compat/mingw.c | 2 +- 1 file chang

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-27 Thread Johannes Schindelin
Hi all, On 2015-08-27 17:55, Johannes Schindelin wrote: > From: jfmc > > The code to open and test the second end of the pipe clearly imitates > the code for the first end. A little too closely, though... Let's fix > the obvious copy-edit bug. > > Signed-off-by: Jos

Re: http.c (curl_easy_setopt and CURLAUTH_ANY)

2015-08-28 Thread Johannes Schindelin
Hi Stephen, On 2015-08-28 08:07, Stephen Kazakoff wrote: > When I'm behind a proxy (with BASIC authentication), I'm unable to > perform a git clone. > > I managed to fix this by editing http.c and recompiling. The change > I'd like to propose is to line 452. > > > From: > > curl_easy_setopt(r

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-28 Thread Johannes Schindelin
Hi Jose, Please do not top-post; I use top-posting as a tell-tale for mails I can safely delete unread when I have too many mails in my inbox. On 2015-08-28 08:37, Jose F. Morales wrote: > Ops... my fault. I was playing with the web editor and forgot that my > profile didn't had my real name (no

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-28 Thread Johannes Schindelin
Hi, On 2015-08-28 11:39, Johannes Schindelin wrote: > On 2015-08-28 08:37, Jose F. Morales wrote: > >> Could I still amend the commit? (it seems to be already pushed into master) > > It was pushed to Git for Windows' master, but here it was submitted to > the Gi

[PATCH v2] Mingw: verify both ends of the pipe () call

2015-08-28 Thread Johannes Schindelin
From: Jose F. Morales The code to open and test the second end of the pipe clearly imitates the code for the first end. A little too closely, though... Let's fix the obvious copy-edit bug. Signed-off-by: Jose F. Morales Signed-off-by: Johannes Schindelin --- compat/mingw.c | 2 +- 1

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-28 Thread Johannes Schindelin
Hi Jonathan, On 2015-08-27 23:50, Jonathan Nieder wrote: > Johannes Schindelin wrote: > >> From: jfmc > > This means the name shown by git shortlog would be jfmc instead of > Jose F. Morales. Intended? Fixed in v2 ;-) Ciao, Dscho -- To unsubscribe from this list: send

Re: [PATCH 0/9] Progress with git submodule

2015-08-28 Thread Johannes Schindelin
Hi Stefan, On 2015-08-28 03:14, Stefan Beller wrote: > Stefan Beller (9): > submodule: implement `module_list` as a builtin helper > submodule: implement `module_name` as a builtin helper > submodule: implement `module_clone` as a builtin helper Another thing that just hit me: is there any

Git for Windows 2.5.1 is out

2015-08-31 Thread Johannes Schindelin
Dear Git (for Windows) users, it is my pleasure to announce the release of Git for Windows 2.5.1. Apart from synchronizing with Git 2.5.1, the following bugs were fixed: • Backspace works now with ConHost-based (cmd.exe) terminal. • When there is a ~/.bashrc but no ~/.bash_profile, the latte

Re: Git crash on different versions, including current

2015-08-31 Thread Johannes Schindelin
Hi Christian, On 2015-08-29 10:41, Christian Soltenborn wrote: > today I ran into a git issue on Windows 7/64. My directory structure > looks like this, and I wondered why the content of a dir wouldn't get added. > > C:\Users\chris\git\GoogleTestExtension > -- .git > -- ConsoleApplication1 (new)

Re: git Dockerfile for ppc64le

2015-08-31 Thread Johannes Schindelin
Hi, On 2015-08-25 06:37, Gawade P wrote: > I have built and tested the latest version on git on multiple > distributions including Ubuntu 15.04 on the ppc64le architecture. I > have run the complete test suite and verified that there are no test > failures. > > I have also written a dockerfile f

Re: [PATCH] mailmap: update my entry with new email address

2015-09-01 Thread Johannes Schindelin
Hi Ramsay, On 2015-09-01 17:50, Ramsay Jones wrote: > diff --git a/.mailmap b/.mailmap > index ece2951..e5b4126 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -186,7 +186,7 @@ Philip Jägenstedt > > Philipp A. Hartmann > Philippe Bruhat > Ralf Thielow > -Ramsay Allan Jones > +Ramsay Jone

Re: Windows path handling changed between versions

2015-09-01 Thread Johannes Schindelin
Hi Geofrey, On 2015-09-01 18:55, Geofrey Sanders wrote: > I recently upgraded from Windows Git 1.6.2 to 2.5.0 and found myself > unable to rebase. Turns out paths didn't used to be case-sensitive and > now they are, causing a number of operations to halt. A repo created > by pointing at the direct

Re: Git book figure bug

2015-09-02 Thread Johannes Schindelin
Hi Jesper, On 2015-09-02 09:45, Jesper Jørgensen wrote: > I am learning how git works, and is using the excellent book on the > official site. > I believe I have located a mistake in one of the images. > It is about Figure 3.17 on this page : > http://git-scm.com/book/en/v2/Git-Branching-Basic-B

Do you plan to release 2.5.2 any time soon?

2015-09-02 Thread Johannes Schindelin
Hi Junio, I have a couple of fixes lined up for bugs in Git for Windows 2.5.1. Do you plan to release 2.5.2 any time soon? If yes, I would hold off, otherwise I will just do a Git for Windows 2.5.1 (Rel 2). Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the bod

Re: GSoC 2015 is over

2015-09-02 Thread Johannes Schindelin
Hi, On Wed, 2 Sep 2015, Paul Tan wrote: > On Wed, Sep 2, 2015 at 12:55 AM, Matthieu Moy > wrote: > > I consider this GSoC as a great success and a pleasant experience. > > Congratulation to Paul and Karthik, and a warm "thank you" to everybody > > who contributed: administrators, mentors, review

Re: [git-for-windows] Re: Git for Windows 2.5.1 is out

2015-09-02 Thread Johannes Schindelin
On Wed, 2 Sep 2015, Aaron Bird wrote: > I am running windows 8.1. Every time I try and open git Bash I get an > unexpected kernal mode trap error and computer instantly shuts down. For lurkers, Aaron also reported this bug at https://github.com/git-for-windows/git/issues/348 and we are eagerly

On a personal note

2015-09-03 Thread Johannes Schindelin
Hey all, yes, it is true: since mid-August I am working for Microsoft. Over a year ago, I got into contact with the Visual Studio Online group at Microsoft, of which I am now a happy member. A large part of my mission is to improve the experience of Git for Windows. This is very exciting to me: I

Re: git bash bug: ipython doesn't work

2015-09-03 Thread Johannes Schindelin
Hi Sergey, On 2015-09-03 18:56, Sergey Chipiga wrote: > I downloaded git for windows v2.5.1. And in git bash I can't launch ipython. > I suppose it forwards stdout somethere. I replied in the ticket you opened on GitHub: https://github.com/git-for-windows/git/issues/352 Ciao, Johannes -- To uns

Re: Do you plan to release 2.5.2 any time soon?

2015-09-04 Thread Johannes Schindelin
Hi Junio, On 2015-09-03 21:00, Junio C Hamano wrote: > Johannes Schindelin writes: > >> I have a couple of fixes lined up for bugs in Git for Windows 2.5.1. Do >> you plan to release 2.5.2 any time soon? If yes, I would hold off, >> otherwise I will just do a Git

Re: On a personal note

2015-09-06 Thread Johannes Schindelin
On 2015-09-03 15:06, Levente wrote: > Is the 'git for windows' development is in a separate branch? https://github.com/git-for-windows/git/ (see the "repository" link on the upper right of http://git-for-windows.github.io/). Ciao, Johannes -- To unsubscribe from this list: send the line "unsubsc

Re: Bug report: GIT PRO/Branches chapter

2015-09-09 Thread Johannes Schindelin
Hi Robert, On 2015-09-09 08:11, Robert Macháček wrote: > Just reading this chapter: > https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell > > I believe that: Figure 3-9. Divergent history > (https://git-scm.com/book/en/v2/book/03-git-branching/images/advance-master.png) > does no

[PATCH] am --skip/--abort: merge HEAD/ORIG_HEAD tree into index

2015-09-09 Thread Johannes Schindelin
-suggested-by: Kim Gybels Original report: https://github.com/git-for-windows/git/issues/365 Acked-by: Paul Tan Signed-off-by: Johannes Schindelin --- contrib/examples/git-am.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/examples/git-am.sh b/contrib/examples/git

Re: [PATCH] am --skip/--abort: merge HEAD/ORIG_HEAD tree into index

2015-09-09 Thread Johannes Schindelin
Hi Junio, On 2015-09-09 11:10, Johannes Schindelin wrote: > This is a backport of the corresponding patch to the builtin am in 2.6: > 3ecc704 (am --skip/--abort: merge HEAD/ORIG_HEAD tree into index, > 2015-08-19). > > Reportedly, it can make a huge difference on Windows, in

Re: storing cover letter of a patch series?

2015-09-10 Thread Johannes Schindelin
Hi Jake, On 2015-09-10 18:28, Jacob Keller wrote: > does anyone know of any tricks for storing a cover letter for a patch > series inside of git somehow? It is not stored as a blob, but I use `git branch --edit-description` to write the cover letter for patch series when I expect a couple of it

Announcing Git for Windows 2.5.2

2015-09-10 Thread Johannes Schindelin
Dear Git users, it is my pleasure to announce Git for Windows 2.5.2. The installers and portable versions can be downloaded from our home page at https://git-for-windows.github.io/. We have been quite busy, lots of contributions (mostly bug reports, but also the occasional Pull Request). Thank

Re: storing cover letter of a patch series?

2015-09-10 Thread Johannes Schindelin
Hi Jake, On 2015-09-10 23:00, Jacob Keller wrote: > On Thu, Sep 10, 2015 at 11:58 AM, Johannes Schindelin > wrote: >> >> On 2015-09-10 18:28, Jacob Keller wrote: >> >>> does anyone know of any tricks for storing a cover letter for a patch >>> series ins

Re: error opening

2015-09-12 Thread Johannes Schindelin
Hi Adrian, please note that Renato never got your mail (you should always use reply-to-all). I re-Cc:ed him, please do not forget to reply-to-all next time. On 2015-09-11 23:33, Adrian Ang wrote: > Renato Akaboci gmail.com> writes: >> >> I´m in trouble just after installation of my Git for Wind

Re: v2.5.2 installation on Windows 10

2015-09-12 Thread Johannes Schindelin
Hi Long, On 2015-09-11 18:13, Long wrote: > Installation of 64bit could complete, but running Git GUI always prompt the > error below: > > Couldn’t read file “C:\Program > Files\Git\cmd\mingw64\libexec\git-core\git-gui”: no such file or > directory Please see the corresponding ticket: https://

Re: v2.5.2 installation on Windows 10

2015-09-12 Thread Johannes Schindelin
Dear Diaoul, it is considered rude on this mailing list to top-post, and likewise to cull the Cc: list. Please do not do that. On 2015-09-12 11:34, Diaoul wrote: > I can confirm this on the same setup (W10 64bit git 2.5.2) Please see the corresponding ticket: https://github.com/git-for-windows

Re: Git Deployment using existing multiple environments

2015-09-12 Thread Johannes Schindelin
Hi, On 2015-09-12 08:31, Sukhwinder Singh wrote: > We already have 3-4 environments setup on our Windows servers without Git > and each environment already has code which is different from each > other. > > There are three environments > Live > UAT > Test (has the latest code) > > > And then d

RE: v2.5.2 installation on Windows 10

2015-09-12 Thread Johannes Schindelin
Hi Long, On 2015-09-12 13:43, Long Yang wrote: > Thanks for the email to confirm the bug. Of course! Thank you for taking the time to report it. > To answer your question first, I found only the Community page at > http://www.git-scm.com/, as I was looking for a forum-kind of page to > see if s

[PATCH] poll: honor the timeout on Win32

2015-09-12 Thread Johannes Schindelin
increasing. (Neither GetSystemTime nor QueryPerformanceCounter have all three of these properties.) Signed-off-by: Edward Thomson Signed-off-by: Johannes Schindelin --- compat/poll/poll.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/compat/poll/poll.c b/compat

Announcing Git for Windows 2.5.2 (Release 2)

2015-09-12 Thread Johannes Schindelin
Dear Git users, you probably noticed that there was a really obvious bug in the "Git GUI" entry in the Start Menu (because it has been reported several times). I just released a new version that squashes this bug and three more. Please find it here: https://github.com/git-for-windows/git/r

Re: [git-for-windows] Re: Announcing Git for Windows 2.5.2

2015-09-12 Thread Johannes Schindelin
Hi Marko, On 2015-09-12 20:46, Marko Palola wrote: > I have some problems with 2.5.2 and 2.5.1 and bitdefender scanner. > but I can use v2.5.0 We have had plenty of reports since the start of the Git for Windows project in 2007. None of them have turned out to be true viruses, all of them were

RE: Git Deployment using existing multiple environments

2015-09-15 Thread Johannes Schindelin
Hi, please stop top-posting. It is quite irritating by now. Thank you. On 2015-09-15 08:50, Sukhwinder Singh wrote: > Now lets say we set up a repository at github which has the latest > code (all test code)., Now at each of our own servers we already have > existing code, that is Test, UAT and

Re: [PATCH 04/67] fsck: don't fsck alternates for connectivity-only check

2015-09-15 Thread Johannes Schindelin
Hi Peff, On 2015-09-15 17:24, Jeff King wrote: > Commit 02976bf (fsck: introduce `git fsck --connectivity-only`, > 2015-06-22) recently gave fsck an option to perform only a > subset of the checks, by skipping the fsck_object_dir() > call. However, it does so only for the local object > directory,

Re: [PATCH 08/67] add reentrant variants of sha1_to_hex and find_unique_abbrev

2015-09-16 Thread Johannes Schindelin
Hi Junio, Jeff & Ramsay, On 2015-09-16 03:32, Junio C Hamano wrote: > Jeff King writes: > >>> Hmm, I haven't read any other patches yet (including those which use these >>> new '_to' functions), but I can't help feeling they should be named >>> something >>> like 'sha1_to_hex_str()' and 'find_u

Re: Big path on git add file [windows bug]

2015-09-16 Thread Johannes Schindelin
Hi Alexey, On 2015-09-16 10:01, Alexey Kasyanchuk wrote: > I tried add one of node.js module to git project. But add operation failed: > > libgit2 returned: Invalid path for filesystem > 'E:/Projects/vsteams/node_modules/gulp-imagemin/node_modules/imagemin/node_modules/imagemin-gifsicle/node_modu

Re: On a personal note

2015-09-17 Thread Johannes Schindelin
Hi Duy, On 2015-09-17 15:29, Duy Nguyen wrote: > On Thu, Sep 3, 2015 at 5:00 PM, Johannes Schindelin > wrote: >> >> yes, it is true: since mid-August I am working for Microsoft. Over a >> year ago, I got into contact with the Visual Studio Online group at >> Micros

Windows patches roadmap, was Re: On a personal note

2015-09-18 Thread Johannes Schindelin
21:27, Stefan Beller wrote: > On Thu, Sep 17, 2015 at 11:54 AM, Johannes Schindelin > wrote: >> >> And yes, the roadmap is pretty clear from the GitHub tickets, e.g. this one: >> >> https://github.com/git-for-windows/git/issues/285 > > That's pretty awesome.

Announcing Git for Windows 2.5.3

2015-09-18 Thread Johannes Schindelin
Dear Git users, it is my pleasure to announce that Git for Windows 2.5.3 can be downloaded from https://git-for-windows.github.io/. I would like to take this opportunity to thank everybody who contributes to this project (and you will see below that there have been quite a few changes since re

Re: Unable to create temporary file '/var/git/tmv3-target-overlay.git/shallow_Un8ZOR': Permission denied

2015-09-19 Thread Johannes Schindelin
Hi Duy, On 2015-09-19 04:21, Duy Nguyen wrote: > On Thu, Sep 17, 2015 at 11:54 PM, Joakim Tjernlund > wrote: >> On Thu, 2015-09-17 at 20:18 +0700, Duy Nguyen wrote: >>> On Mon, Sep 14, 2015 at 10:37 PM, Joakim Tjernlund >>> wrote: >>> > On Mon, 2015-08-31 at 16:56 +0700, Duy Nguyen wrote: >>> >

Re: Unable to create temporary file '/var/git/tmv3-target-overlay.git/shallow_Un8ZOR': Permission denied

2015-09-22 Thread Johannes Schindelin
Hi Joakim, On 2015-09-21 19:08, Joakim Tjernlund wrote: > On Mon, 2015-09-21 at 09:48 -0700, Junio C Hamano wrote: >> Duy Nguyen writes: >> >> > Is it really necessary to remove write access in $GIT_DIR? Do we (git >> > devs) have some guidelines about things in $GIT_DIR? >> >> Those who are allo

Re: Unable to create temporary file '/var/git/tmv3-target-overlay.git/shallow_Un8ZOR': Permission denied

2015-09-23 Thread Johannes Schindelin
Hi Joakim, On 2015-09-22 22:58, Joakim Tjernlund wrote: > On Tue, 2015-09-22 at 22:00 +0200, Johannes Schindelin wrote: >> >> The reason should be easy to understand: Git's concept is based on the idea >> that you have full control over >> your repository. Other

Re: Unable to create temporary file '/var/git/tmv3-target-overlay.git/shallow_Un8ZOR': Permission denied

2015-09-23 Thread Johannes Schindelin
Hi Joakim, On 2015-09-23 22:41, Joakim Tjernlund wrote: > On Wed, 2015-09-23 at 13:10 +0200, Johannes Schindelin wrote: >> >> On 2015-09-22 22:58, Joakim Tjernlund wrote: >> > On Tue, 2015-09-22 at 22:00 +0200, Johannes Schindelin wrote: >> > > >> &

[PATCH 2/4] pack-objects: do not get distracted by stale refs

2015-09-24 Thread Johannes Schindelin
It is quite possible for, say, a remote HEAD to become stale, e.g. when the default branch was renamed. We should still be able to pack our objects when such a thing happens; simply ignore invalid refs (because they cannot matter for the packing process anyway). Signed-off-by: Johannes

[PATCH 1/4] gc: demonstrate failure with stale remote HEAD

2015-09-24 Thread Johannes Schindelin
Signed-off-by: Johannes Schindelin --- t/t6500-gc.sh | 15 +++ 1 file changed, 15 insertions(+) diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh index 63194d8..b736774 100755 --- a/t/t6500-gc.sh +++ b/t/t6500-gc.sh @@ -30,4 +30,19 @@ test_expect_success 'gc -h with invalid configur

[PATCH 0/4] Fix gc failure when a remote HEAD goes stale

2015-09-24 Thread Johannes Schindelin
emote repository gets renamed. Git's garbage collector should handle this gracefully. The best this developer could come up with, is to simply ignore and delete the now-broken refs. Johannes Schindelin (4): gc: demonstrate failure with stale remote HEAD pack-objects: do not get distracte

[PATCH 3/4] mark_reachable_objects(): optionally collect broken refs

2015-09-24 Thread Johannes Schindelin
or of the function is unchanged if that parameter is `NULL`. Signed-off-by: Johannes Schindelin --- builtin/prune.c | 2 +- builtin/reflog.c | 2 +- reachable.c | 26 -- reachable.h | 3 ++- 4 files changed, 24 insertions(+), 9 deletions(-) diff --git a/bu

[PATCH 4/4] gc: remove broken refs

2015-09-24 Thread Johannes Schindelin
When encountering broken refs, such as a stale remote HEAD (which can happen if the active branch was renamed in the remote), it is more helpful to remove those refs than to exit with an error. This fixes https://github.com/git-for-windows/git/issues/423 Signed-off-by: Johannes Schindelin

Re: What's cooking in git.git (Sep 2015, #06; Wed, 23)

2015-09-24 Thread Johannes Schindelin
Hi Junio, On 2015-09-24 00:56, Junio C Hamano wrote: > * jc/fsck-dropped-errors (2015-09-23) 1 commit > - fsck: exit with non-zero when problems are found > > There were some classes of errors that "git fsck" diagnosed to its > standard error that did not cause it to exit with non-zero statu

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-25 Thread Johannes Schindelin
Hi, On 2015-09-25 05:14, Dennis Kaarsemaker wrote: > On do, 2015-09-24 at 17:41 -0700, Junio C Hamano wrote: >> larsxschnei...@gmail.com writes: >> >> > My idea is that the owner of "https://github.com/git/git"; enables this >> > account >> > for Travis (it's free!). Then we would automatically g

Re: Fwd: diff not finding difference

2015-09-25 Thread Johannes Schindelin
Hi Jack Adrian, On 2015-09-24 23:09, Jack Adrian Zappa wrote: > This is a weird one: > > [file-1 begin] > > abcd efg hijklmnop > > [file-1 end] > > [file-2 begin] > > blah blah blah > / > abdc boo ya! > > [file-2

Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions

2015-09-28 Thread Johannes Schindelin
Hi Karsten, On 2015-09-28 12:39, Karsten Blees wrote: > Different git variants record file times in the index with different > precisions, according to their capabilities. E.g. git compiled with NO_NSEC > records seconds only, JGit records the mtime in milliseconds, but leaves > ctime blank (becau

[PATCH v2 2/4] pack-objects: do not get distracted by broken symrefs

2015-09-28 Thread Johannes Schindelin
It is quite possible for, say, a remote HEAD to become broken, e.g. when the default branch was renamed. We should still be able to pack our objects when such a thing happens; simply ignore broken symrefs (because they cannot matter for the packing process anyway). Signed-off-by: Johannes

[PATCH v2 1/4] gc: demonstrate failure with stale remote HEAD

2015-09-28 Thread Johannes Schindelin
Signed-off-by: Johannes Schindelin --- t/t6500-gc.sh | 15 +++ 1 file changed, 15 insertions(+) diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh index 63194d8..b736774 100755 --- a/t/t6500-gc.sh +++ b/t/t6500-gc.sh @@ -30,4 +30,19 @@ test_expect_success 'gc -h with invalid configur

[PATCH v2 3/4] mark_reachable_objects(): optionally collect broken symrefs

2015-09-28 Thread Johannes Schindelin
llect broken symrefs. The behavior of the function is unchanged if that parameter is `NULL`. Signed-off-by: Johannes Schindelin --- builtin/prune.c | 2 +- builtin/reflog.c | 2 +- reachable.c | 25 +++-- reachable.h | 3 ++- 4 files changed, 23 insertions(+), 9 dele

[PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Johannes Schindelin
When encountering broken symrefs, such as a stale remote HEAD (which can happen if the active branch was renamed in the remote), it is more helpful to remove those symrefs than to exit with an error. This fixes https://github.com/git-for-windows/git/issues/423 Signed-off-by: Johannes Schindelin

[PATCH v2 0/4] Fix gc failure when a remote HEAD goes stale

2015-09-28 Thread Johannes Schindelin
emote repository gets renamed. Git's garbage collector should handle this gracefully. The best this developer could come up with, is to simply warn and delete broken symrefs. Thanks to Junio and Peff for their really valuable sanity check. Interdiff vs v1 below diffstat. Johannes Schindelin

[PATCH] Fix "inside work tree" detection on case-insensitive filesystems

2015-09-28 Thread Johannes Schindelin
_TREE` variable (e.g. `C:\test` vs `c:\test`) the user would be greeted by the error message fatal: git-am cannot be used without a working tree. when trying to run a rebase. This fixes https://github.com/git-for-windows/git/issues/402 (reported by Daniel Harding). Signed-off-by: Joh

[PATCH] clone --dissociate: avoid locking pack files

2015-09-28 Thread Johannes Schindelin
. On platforms where a file cannot be deleted if another process still holds a handle on it, we therefore need to take pains to release all pack files and indexes before dissociating. This fixes https://github.com/git-for-windows/git/issues/446 Signed-off-by: Johannes Schindelin --- builtin/cl

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Johannes Schindelin
Hi Junio, On 2015-09-28 20:49, Junio C Hamano wrote: > Junio C Hamano writes: > >> Johannes Schindelin writes: >> >>> When encountering broken symrefs, such as a stale remote HEAD (which can >>> happen if the active branch was renamed in the remote), it

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Johannes Schindelin
Hi Peff, On 2015-09-28 21:03, Jeff King wrote: > On Mon, Sep 28, 2015 at 04:02:08PM +0200, Johannes Schindelin wrote: > >> @@ -136,7 +139,14 @@ int cmd_prune(int argc, const char **argv, const char >> *prefix) >> if (show_progress) >> p

Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions

2015-09-29 Thread Johannes Schindelin
Hi Karsten, On 2015-09-29 12:23, Karsten Blees wrote: > Am 28.09.2015 um 14:52 schrieb Johannes Schindelin: >> Otherwise there would be that little loop-hole where (nsec % 1000) == 0 *by >> chance* and we assume the timestamps to be identical even if they are not. > > Yeah,

Re: [PATCH] git-send-email.perl: Fixed sending of many changes/patches

2015-09-29 Thread Johannes Schindelin
Hi Lars, On 2015-09-29 17:00, Lars Wendler wrote: > From: Stefan Agner > > See http://permalink.gmane.org/gmane.comp.version-control.git/274569 Please summarize the linked discussion in the commit message, as it is the convention here in the Git project to make commit messages self-sufficient,

Announcing Git for Windows 2.6.0

2015-09-29 Thread Johannes Schindelin
Dear Git users, it is my pleasure to announce that Git for Windows 2.6.0 is available (see https://git-for-windows.github.io/ for details and download links). Thank you, contributors! Changes since Git for Windows 2.5.3 (September 18th 2015) New Features • Comes with Git 2.6.0 • The WhoUs

Re: [PATCH] git-send-email.perl: Fixed sending of many/huge changes/patches

2015-09-30 Thread Johannes Schindelin
Hi Lars, On 2015-09-30 09:26, Lars Wendler wrote: > From: Stefan Agner > > Sometimes sending huge patches/commits fail with > > [Net::SMTP::SSL] Connection closed at /usr/lib/git-core/git-send-email > line 1320. > > Running the command with --smtp-debug=1 yields to > > Net::SMTP::SSL: Net::Cm

[PATCH] Provide a dirname() function when NO_LIBGEN_H=YesPlease

2015-09-30 Thread Johannes Schindelin
()` is a sibling of `basename()`, we simply put our very own `gitdirname()` implementation next to `gitbasename()` and use it if `NO_LIBGEN_H` has been set. Signed-off-by: Johannes Schindelin --- I stumbled over the compile warning when upgrading Git for Windows to 2.6.0. There was a

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Johannes Schindelin
Hi Max, On 2015-10-01 05:29, Max Kirillov wrote: > When a builtin has done its job, but waits for pager or not waited > by its caller and still hanging it keeps pack files opened. > This can cause a number of issues, for example on Windows git gc > cannot remove the packs. I did not experience th

Re: [PATCH/RFC 2/2] sha1_file: set packfile to O_CLOEXEC at open

2015-10-02 Thread Johannes Schindelin
Hi Max, On 2015-10-01 05:29, Max Kirillov wrote: > Windows does not support setting O_CLOEXEC by fcntl, > but there is an open flag O_NOINHERIT which results in same > behaviour. Use it in git_open_noatime() and also bring > setting O_CLOEXEC there also to make it consistent. Rename > the function

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Johannes Schindelin
Hi Max, On 2015-10-02 12:05, Johannes Schindelin wrote: > On 2015-10-01 05:29, Max Kirillov wrote: >> When a builtin has done its job, but waits for pager or not waited >> by its caller and still hanging it keeps pack files opened. >> This can cause a number of issues, for e

Re: [RFC/PATCH v1] Add Travis CI support

2015-10-04 Thread Johannes Schindelin
Hi Junio, On 2015-10-04 03:37, Junio C Hamano wrote: > Junio C Hamano writes: > >> On Sat, Oct 3, 2015 at 3:23 PM, Roberto Tyley >> wrote: >>> >>> Given this, enabling Travis CI for git/git seems pretty low risk, >>> are there any strong objections to it happening? >> >> I still don't see a re

  1   2   3   4   5   6   7   8   9   10   >