Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Junio C Hamano
Andreas Schwab writes: > On Jun 30 2019, Johannes Sixt wrote: > >> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh >> index 79bfaeafa9..4b4d06a1c8 100755 >> --- a/t/t5319-multi-pack-index.sh >> +++ b/t/t5319-multi-pack-index.sh >> @@ -443,7 +443,7 @@ test_expect_success 'r

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Derrick Stolee
On 7/1/2019 2:22 PM, Johannes Sixt wrote: > Am 01.07.19 um 14:30 schrieb Derrick Stolee: >> On 7/1/2019 8:11 AM, Johannes Schindelin wrote: >>> Or we stop introducing new Perl calls, and use the perfectly fine >>> `test-tool path-utils file-size` command: >>> >>> https://github.com/git/git/blob/v2.

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Johannes Sixt
Am 01.07.19 um 14:30 schrieb Derrick Stolee: > On 7/1/2019 8:11 AM, Johannes Schindelin wrote: >> Or we stop introducing new Perl calls, and use the perfectly fine >> `test-tool path-utils file-size` command: >> >> https://github.com/git/git/blob/v2.22.0/t/helper/test-path-utils.c#L302-L312 >> >> T

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Andreas Schwab
On Jun 30 2019, Johannes Sixt wrote: > diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh > index 79bfaeafa9..4b4d06a1c8 100755 > --- a/t/t5319-multi-pack-index.sh > +++ b/t/t5319-multi-pack-index.sh > @@ -443,7 +443,7 @@ test_expect_success 'repack with minimum size does not

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Jeff King
On Mon, Jul 01, 2019 at 02:11:43PM +0200, Johannes Schindelin wrote: > Or we stop introducing new Perl calls, and use the perfectly fine > `test-tool path-utils file-size` command: > > https://github.com/git/git/blob/v2.22.0/t/helper/test-path-utils.c#L302-L312 Ah, thanks, I missed that we had a

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Derrick Stolee
On 7/1/2019 8:11 AM, Johannes Schindelin wrote: > Hi Peff, > > On Sun, 30 Jun 2019, Jeff King wrote: > >> On Sun, Jun 30, 2019 at 10:59:34PM +0200, Johannes Sixt wrote: >> >>> Am 30.06.19 um 21:48 schrieb Eric Sunshine: On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt wrote: > diff --git a

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Johannes Schindelin
Hi Peff, On Sun, 30 Jun 2019, Jeff King wrote: > On Sun, Jun 30, 2019 at 10:59:34PM +0200, Johannes Sixt wrote: > > > Am 30.06.19 um 21:48 schrieb Eric Sunshine: > > > On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt wrote: > > >> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Derrick Stolee
Sorry I'm late to the thread. Thanks for reporting this issue, Johannes. On 7/1/2019 7:33 AM, SZEDER Gábor wrote: > On Mon, Jul 01, 2019 at 05:16:02AM -0400, Jeff King wrote: >> I see Gábor suggested using "wc -c" elsewhere in the thread. That would >> be fine with me, too, though I think the requ

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread SZEDER Gábor
On Mon, Jul 01, 2019 at 05:16:02AM -0400, Jeff King wrote: > I see Gábor suggested using "wc -c" elsewhere in the thread. That would > be fine with me, too, though I think the required sed there may be > getting pretty unreadable, too. :) It could be done even without 'sed', though at the expense

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread Jeff King
On Mon, Jul 01, 2019 at 08:33:18AM +0200, Johannes Sixt wrote: > > If we are OK relying on rudimentary perl[1], then: > > > > perl -le "print((stat)[7]) for @ARGV" > > I'm fine with that. But then we should do the sort + head -n 1 at the > same time. I can do that with a small script, but I'm

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-07-01 Thread SZEDER Gábor
On Sun, Jun 30, 2019 at 10:59:34PM +0200, Johannes Sixt wrote: > Am 30.06.19 um 21:48 schrieb Eric Sunshine: > > On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt wrote: > >> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh > >> @@ -443,7 +443,7 @@ test_expect_success 'repack wit

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-06-30 Thread Johannes Sixt
Am 01.07.19 um 00:25 schrieb Jeff King: > On Sun, Jun 30, 2019 at 10:59:34PM +0200, Johannes Sixt wrote: > >> Am 30.06.19 um 21:48 schrieb Eric Sunshine: >>> On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt wrote: diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh @@ -4

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-06-30 Thread Jeff King
On Sun, Jun 30, 2019 at 10:59:34PM +0200, Johannes Sixt wrote: > Am 30.06.19 um 21:48 schrieb Eric Sunshine: > > On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt wrote: > >> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh > >> @@ -443,7 +443,7 @@ test_expect_success 'repack wi

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-06-30 Thread Johannes Sixt
Am 30.06.19 um 21:48 schrieb Eric Sunshine: > On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt wrote: >> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh >> @@ -443,7 +443,7 @@ test_expect_success 'repack with minimum size does not >> alter existing packs' ' >> -

Re: [PATCH] t5319: don't trip over a user name with whitespace

2019-06-30 Thread Eric Sunshine
On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt wrote: > On my Windows system where the POSIX commands are provided by MSYS2, > I observe this output: > > $ ls -l Makefile > -rw-r--r-- 1 Johannes Sixt 197121 101780 Jun 30 09:33 Makefile > > Notice the blank in the user name.

[PATCH] t5319: don't trip over a user name with whitespace

2019-06-30 Thread Johannes Sixt
On my Windows system where the POSIX commands are provided by MSYS2, I observe this output: $ ls -l Makefile -rw-r--r-- 1 Johannes Sixt 197121 101780 Jun 30 09:33 Makefile Notice the blank in the user name. Obviously, extracting the size of a file by counting columns won't work. But two tes

[PATCH v6 1/2] ident: test how GIT_* and user.{name,email} interact

2019-02-05 Thread Ævar Arnfjörð Bjarmason
There were no explicit tests for the interaction between setting GIT_* in the environment, and the user.{name,email} config variables. These tests are basic, but we're about to learn {author,committer}.{name,email} in addition to user.{name,email}, so they'll soon become more useful.

Re: [PATCH v3 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-30 Thread Slavica Djukic
On 26-Oct-18 3:13 AM, Junio C Hamano wrote: Slavica Djukic writes: From: Slavica Please make sure this matches your sign-off below. This is part of enhancement request that ask for 'git stash' to work even if 'user.name' and 'user.email' are not configured. Due to an implementation detai

Re: [PATCH v3 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-25 Thread Junio C Hamano
Slavica Djukic writes: > From: Slavica Please make sure this matches your sign-off below. > This is part of enhancement request that ask for 'git stash' to work > even if 'user.name' and 'user.email' are not configured. > Due to an implementation detail, git-stash undesirably requires > 'user.

[PATCH v3 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-25 Thread Slavica Djukic
From: Slavica This is part of enhancement request that ask for 'git stash' to work even if 'user.name' and 'user.email' are not configured. Due to an implementation detail, git-stash undesirably requires 'user.name' and 'user.email' to be set, but shouldn't. The issue is discussed here: https://p

[PATCH v3 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-25 Thread Slavica Djukic
it with test_must_fail config user.email. Slavica (1): [Outreachy] t3903-stash: test without configured user name t/t3903-stash.sh | 14 ++ 1 file changed, 14 insertions(+) -- 2.19.1.windows.1

Re: [PATCH v2 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Junio C Hamano
Eric Sunshine writes: >> +test_commit 1 && >> +test_config user.useconfigonly true && >> +test_config stash.usebuiltin true && >> +sane_unset GIT_AUTHOR_NAME && >> +sane_unset GIT_AUTHOR_EMAIL && >> +sane_unset GIT_COMMITTER_NAME && >> +sane_unset GIT_COMMITTER_EMAIL &

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Junio C Hamano
Slavica writes: > On 23-Oct-18 8:52 PM, Christian Couder wrote: >> On Tue, Oct 23, 2018 at 6:35 PM Slavica wrote: >>> This is part of enhancement request that ask for `git stash` to work even >>> if `user.name` is not configured. >>> The issue is discussed here: >>> https://public-inbox.org/gi

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Junio C Hamano
Johannes Schindelin writes: >> HOME is set to TRASH_DIRECTORY in t/test-lib.sh already, and we do >> so to avoid getting affected by the real $HOME/.gitconfig of the >> user who happens to be running the test suite. > > My bad. I should have checked. I was under the impression that we set > `HOME

Re: [PATCH v2 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Eric Sunshine
On Wed, Oct 24, 2018 at 4:06 PM Slavica Djukic wrote: > This is part of enhancement request that ask for 'git stash' to work > even if 'user.name' and 'user.email' are not configured. > Due to an implementation detail, git-stash undesirably requires > 'user.name' and 'user.email' to be set, but sh

[PATCH v2 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Slavica Djukic
From: Slavica This is part of enhancement request that ask for 'git stash' to work even if 'user.name' and 'user.email' are not configured. Due to an implementation detail, git-stash undesirably requires 'user.name' and 'user.email' to be set, but shouldn't. The issue is discussed here: https://p

[PATCH v2 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Slavica Djukic
Changes since v1: *changed test title *removed subshell and HOME override *fixed weird identation *unset() replaced with sane_unset() Slavica (1): [Outreachy] t3903-stash: test without configured user name t/t3903-stash.sh | 13 + 1 file changed, 13 insertions

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Johannes Schindelin
Hi Junio, On Wed, 24 Oct 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > On Wed, 24 Oct 2018, Junio C Hamano wrote: > > > >> Slavica writes: > >> > >> > +test_expect_failure 'stash with HOME as non-existing directory' ' > >> > +test_commit 1 && > >> > +test_config user

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Slavica
On 23-Oct-18 8:52 PM, Christian Couder wrote: On Tue, Oct 23, 2018 at 6:35 PM Slavica wrote: This is part of enhancement request that ask for `git stash` to work even if `user.name` is not configured. The issue is discussed here: https://public-inbox.org/git/87o9debty4@evledraar.gmail.c

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Wed, 24 Oct 2018, Junio C Hamano wrote: > >> Slavica writes: >> >> > +test_expect_failure 'stash with HOME as non-existing directory' ' >> > +test_commit 1 && >> > +test_config user.useconfigonly true && >> > +test_config stash.usebuilt

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-24 Thread Johannes Schindelin
Hi Junio, On Wed, 24 Oct 2018, Junio C Hamano wrote: > Slavica writes: > > > +test_expect_failure 'stash with HOME as non-existing directory' ' > > +test_commit 1 && > > +test_config user.useconfigonly true && > > +test_config stash.usebuiltin true && > > +( > > +HOME=$(

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-23 Thread Junio C Hamano
Slavica writes: > +test_expect_failure 'stash with HOME as non-existing directory' ' > +test_commit 1 && > +test_config user.useconfigonly true && > +test_config stash.usebuiltin true && > +( > +HOME=$(pwd)/none && > +export HOME && What is the reason why this tes

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-23 Thread Eric Sunshine
On Tue, Oct 23, 2018 at 12:31 PM Slavica wrote: > This is part of enhancement request that ask for `git stash` to work even if > `user.name` is not configured. > The issue is discussed here: > https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u. As Christian mentioned already,

Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-23 Thread Christian Couder
On Tue, Oct 23, 2018 at 6:35 PM Slavica wrote: > > This is part of enhancement request that ask for `git stash` to work even if > `user.name` is not configured. > The issue is discussed here: > https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u. We prefer commit messages that

[PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

2018-10-23 Thread Slavica
This is part of enhancement request that ask for `git stash` to work even if `user.name` is not configured. The issue is discussed here: https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u. Signed-off-by: Slavica --- t/t3903-stash.sh | 17 + 1 file changed, 17

Re: [PATCH 2/3] getpwuid(mingw): provide a better default for the user name

2018-10-16 Thread Johannes Schindelin
Hi Eric, On Tue, 16 Oct 2018, Eric Sunshine wrote: > On Tue, Oct 16, 2018 at 8:38 AM Johannes Schindelin > wrote: > > On Mon, 15 Oct 2018, Eric Sunshine wrote: > > > On Mon, Oct 15, 2018 at 5:47 AM Johannes Schindelin via GitGitGadget > > > wrote: > > > > + len = ARRAY_SIZE(wbuffer); > >

Re: [PATCH 2/3] getpwuid(mingw): provide a better default for the user name

2018-10-16 Thread Eric Sunshine
On Tue, Oct 16, 2018 at 8:38 AM Johannes Schindelin wrote: > On Mon, 15 Oct 2018, Eric Sunshine wrote: > > On Mon, Oct 15, 2018 at 5:47 AM Johannes Schindelin via GitGitGadget > > wrote: > > > + len = ARRAY_SIZE(wbuffer); > > > + if (GetUserNameExW(type, wbuffer, &len)) { > > > +

Re: [PATCH 2/3] getpwuid(mingw): provide a better default for the user name

2018-10-16 Thread Johannes Schindelin
Hi Eric, On Mon, 15 Oct 2018, Eric Sunshine wrote: > On Mon, Oct 15, 2018 at 5:47 AM Johannes Schindelin via GitGitGadget > wrote: > > We do have the excellent GetUserInfoEx() function to obtain more > > detailed information of the current user (if the user is part of a > > Windows domain); Let'

Re: [PATCH 2/3] getpwuid(mingw): provide a better default for the user name

2018-10-15 Thread Eric Sunshine
On Mon, Oct 15, 2018 at 5:47 AM Johannes Schindelin via GitGitGadget wrote: > We do have the excellent GetUserInfoEx() function to obtain more > detailed information of the current user (if the user is part of a > Windows domain); Let's use it. > [...] > Signed-off-by: Johannes Schindelin > --- >

[PATCH 2/3] getpwuid(mingw): provide a better default for the user name

2018-10-15 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin We do have the excellent GetUserInfoEx() function to obtain more detailed information of the current user (if the user is part of a Windows domain); Let's use it. Suggested by Lutz Roeder. To avoid the cost of loading Secur32.dll (even lazily, loading DLLs takes a non-

Re: user name

2018-05-22 Thread Dennis Powless
stomary to use your real name or a user name when registering to GIT? > > I guess you are talking about using `git config --global user.name > "XXX YYY"`. (Though maybe you are talking about github.com > registration, but in this case you should not have sent this request

Re: user name

2018-05-22 Thread Christian Couder
On Tue, May 22, 2018 at 3:06 PM, Dennis Powless wrote: > Is it customary to use your real name or a user name when registering to GIT? I guess you are talking about using `git config --global user.name "XXX YYY"`. (Though maybe you are talking about github.com registration, but in

user name

2018-05-22 Thread Dennis Powless
Is it customary to use your real name or a user name when registering to GIT? Dennis

[PATCH v2 3/3] t5500: show user name and host in diag-url

2015-02-21 Thread Torsten Bögershausen
The URL for ssh may have include a username before the hostname, like ssh://user@host/repo. When literal IPV6 addresses are used together with a username, the substring "user@[::1]" must be converted into "user@::1". Make that conversion visible for the user, and write userandhost in the diagnosti

[PATCH 3/3] t5500: Show user name and host in diag-url

2015-01-19 Thread Torsten Bögershausen
The URL for ssh may have include a username before the hostname, like ssh://user@host/repo. When literal IPV6 addresses are used together with a username, the substring "user@[::1]" must be converted into "user@::1". Make that conversion visible for the user, and write userandhost in the diagnosti

Re: Authentication with e-mail address as user name for HTTPS remote

2013-08-31 Thread Jeff King
On Sat, Aug 31, 2013 at 08:52:06AM +0200, Patrick Atoon wrote: > Here is what happens. First try cloning without specifying the user name: > > ---8<--- > $ git clone https://git.server.com/git/test.git > Initialized empty Git

Authentication with e-mail address as user name for HTTPS remote

2013-08-30 Thread Patrick Atoon
Hello, I run into a problem with command line git on Linux. The remote git server I try to clone from uses HTTPS as a protocol and requires full fledged e-mail addresses for a user name in its authentication. In TortoiseGit (with winstore) or SourceTree, the user name and password are asked and