Re: use of PWD

2017-11-10 Thread Junio C Hamano
Jeff King writes: > So totally orthogonal to your bug, I wonder if we ought to be doing: > > diff --git a/sha1_file.c b/sha1_file.c > index 057262d46e..0b76233aa7 100644 > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -530,11 +530,11 @@ void prepare_alt_odb(void) > if (alt_odb_tail) >

Re: use of PWD

2017-11-07 Thread Jeff King
as first introduced in commit > 1b9a9467f8b9a8da2fe58d10ae16779492aa7737, which speaks of the "user's > view of the current directory", which is what PWD is. The use of PWD in > that commit may be ok. > > Then in commit 10c4c881c4d2cb0ece0508e7142e189e68445257, > the lim

use of PWD

2017-11-07 Thread Joey Hess
y does git use PWD at all? Some shell code used pwd earlier (leading to similar bugs like the one fixed in v1.5.1.5), but in the C code, it was first introduced in commit 1b9a9467f8b9a8da2fe58d10ae16779492aa7737, which speaks of the "user's view of the current directory", which is wh