Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-09 Thread Junio C Hamano
Matt McCutchen writes: > See my revised proposed text here: > > https://github.com/git/git-scm.com/pull/676/files If somebody says "The ancient version I use has this bug, it does not reproduce with 'next'", the first thing we would ask would be "Does it still happen on 'master'?" Even though i

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-09 Thread Matt McCutchen
On Mon, 2016-02-08 at 14:16 -0800, Junio C Hamano wrote: > Jeff King writes: > > > FWIW, as the person who wrote that section, I think that is a good > > addition.  We do have a link to Simon Tatham's bug-reporting guide, but > > this is a good place to put project-specific advice. > > > > In ad

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-08 Thread Junio C Hamano
Jeff King writes: > FWIW, as the person who wrote that section, I think that is a good > addition. We do have a link to Simon Tatham's bug-reporting guide, but > this is a good place to put project-specific advice. > > In addition to "try it on next" you may want to also mention "try it on > the

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-08 Thread Jeff King
On Sun, Feb 07, 2016 at 08:04:38PM -0500, Matt McCutchen wrote: > > it is very much > > appreciated when reporting bugs people check if a presumed fix is > > already cooking in 'next', try it to verify if it really fixes their > > problem, and send in a "OK fix is good" / "No that does not fix my

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-07 Thread Duy Nguyen
On Mon, Feb 8, 2016 at 8:04 AM, Matt McCutchen wrote: > On Sun, 2016-02-07 at 15:56 -0800, Junio C Hamano wrote: >> Matt McCutchen writes: >> >> > I noticed that when update_linked_gitdir chooses to update >> > .git/worktrees//gitdir, the path it writes is relative, at >> > least >> > under some

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-07 Thread Matt McCutchen
On Sun, 2016-02-07 at 15:56 -0800, Junio C Hamano wrote: > Matt McCutchen writes: > > > I noticed that when update_linked_gitdir chooses to update > > .git/worktrees//gitdir, the path it writes is relative, at > > least > > under some circumstances.  This contradicts the gitrepository- > > layout

Re: update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-07 Thread Junio C Hamano
Matt McCutchen writes: > I noticed that when update_linked_gitdir chooses to update > .git/worktrees//gitdir, the path it writes is relative, at least > under some circumstances.  This contradicts the gitrepository-layout > man page, which says: Duy, is it safe to say that the fix has already be

update_linked_gitdir writes relative path to .git/worktrees//gitdir

2016-02-07 Thread Matt McCutchen
I noticed that when update_linked_gitdir chooses to update .git/worktrees//gitdir, the path it writes is relative, at least under some circumstances.  This contradicts the gitrepository-layout man page, which says: worktrees//gitdir:: A text file containing the absolute path back to the .g