On Sat, Mar 02, 2019 at 10:21:00PM +0100, Johannes Schindelin wrote:
> Do you want to turn these two patches into a proper patch series?
> Otherwise I can take care of it, probably this Monday or Tuesday.
Here they are. The old email sending the first one actually had a typo
(it sent "" inste
Hi Junio,
On Sun, 3 Mar 2019, Junio C Hamano wrote:
> Jeff King writes:
>
> > But for git-fetch, our primary purpose is receiving data and writing it
> > to disk. We should be checking all of our write()s already, and SIGPIPE
> > is just confusing.
>
> Yup, sounds like a very sensible argument
Jeff King writes:
> But for git-fetch, our primary purpose is receiving data and writing it
> to disk. We should be checking all of our write()s already, and SIGPIPE
> is just confusing.
Yup, sounds like a very sensible argument.
> So I'd actually be fine with just declaring that certain comman
Hi Peff,
On Fri, 1 Mar 2019, Jeff King wrote:
> diff --git a/builtin/fetch.c b/builtin/fetch.c
> index b620fd54b4..4ba63d5ac6 100644
> --- a/builtin/fetch.c
> +++ b/builtin/fetch.c
> @@ -1556,7 +1556,9 @@ static int fetch_one(struct remote *remote, int argc,
> const char **argv, int pru
>
>
On Fri, Mar 01, 2019 at 04:02:22PM +0100, Johannes Schindelin wrote:
> > I think that patch does the write_or_die conversion to handle EPIPE, but
> > it would still need to turn off SIGPIPE for the whole process.
> >
> > So you'd also need to stick a:
> >
> > sigchain_push(SIGPIPE, SIG_IGN);
>
Hi Peff,
On Fri, 8 Feb 2019, Jeff King wrote:
> On Fri, Feb 08, 2019 at 10:28:12AM +0100, Johannes Schindelin wrote:
>
> > On Fri, 8 Feb 2019, Johannes Schindelin wrote:
> >
> > > I just had a look at the patch you provided below (for some reason, my
> > > previous search on public-inbox only t
On Fri, Feb 08, 2019 at 10:28:12AM +0100, Johannes Schindelin wrote:
> Hi Peff,
>
> On Fri, 8 Feb 2019, Johannes Schindelin wrote:
>
> > I just had a look at the patch you provided below (for some reason, my
> > previous search on public-inbox only turned up Gábor's mail to which you
> > respond
On Fri, Feb 08, 2019 at 09:32:32AM +0100, Johannes Schindelin wrote:
> Team,
>
> On Mon, 6 Aug 2018, SZEDER Gábor wrote:
>
> > [Resending with Clemens' last used email address.
> > Clemens, please consider sending a patch to update our .mailmap file.]
> >
> >
> > On Mon, Aug 6, 2018 at 5:11 PM
Hi Peff,
On Fri, 8 Feb 2019, Johannes Schindelin wrote:
> I just had a look at the patch you provided below (for some reason, my
> previous search on public-inbox only turned up Gábor's mail to which you
> responded).
>
> Admittedly, I do not really understand all aspects of it, but it applies,
Hi Peff,
I just had a look at the patch you provided below (for some reason, my
previous search on public-inbox only turned up Gábor's mail to which you
responded).
Admittedly, I do not really understand all aspects of it, but it applies,
still, and I kicked off a stress test here:
https
Team,
On Mon, 6 Aug 2018, SZEDER Gábor wrote:
> [Resending with Clemens' last used email address.
> Clemens, please consider sending a patch to update our .mailmap file.]
>
>
> On Mon, Aug 6, 2018 at 5:11 PM SZEDER Gábor wrote:
> >
> > Travis CI changed its default OSX image to use XCode 9.4 o
On Tue, Aug 14, 2018 at 06:32:47PM -0400, Jeff King wrote:
> I suspect the (largely untested) patch below would make your test
> problems go away. Or instead, we could simply add sigpipe=ok to the
> test_must_fail invocation, but I agree with you that the current
> behavior on OS X is not ideal (t
On Mon, Aug 06, 2018 at 05:11:13PM +0200, SZEDER Gábor wrote:
> - 'git upload-pack' receives the request, parses the want line,
> notices the corrupt pack, responds with an 'ERR upload-pack: not
> our ref' pkt-line, and die()s right away.
>
> - 'git fetch' finally approaches the end o
[Resending with Clemens' last used email address.
Clemens, please consider sending a patch to update our .mailmap file.]
On Mon, Aug 6, 2018 at 5:11 PM SZEDER Gábor wrote:
>
> Travis CI changed its default OSX image to use XCode 9.4 on 2018-07-31
> [1]. Since then OSX build jobs fail rather fre
Travis CI changed its default OSX image to use XCode 9.4 on 2018-07-31
[1]. Since then OSX build jobs fail rather frequently because of a
SIGPIPE in the tests 'fetch notices corrupt pack' or 'fetch notices
corrupt idx' in 't5570-git-daemon.sh' [2]. I think this is a symptom
a real bug in Git affe
15 matches
Mail list logo
