Re: t4204-patch-id failures

2016-05-23 Thread Armin Kunaschik
On Tue, May 24, 2016 at 12:23 AM, Junio C Hamano wrote: > Junio C Hamano writes: > Having said all that, this illustrates the root cause of different > behaviours better, but it is harder to reason about than simply > changing the variable name used in this shell function. POSIX reads > a bit f

Re: t4204-patch-id failures

2016-05-23 Thread Junio C Hamano
Junio C Hamano writes: > Both bash and dash seem to run the func1 in the downstream of the > pipe in a separate process, and $name used in "func2 again" is not > affected. But it seems that ksh93 behaves differently (I do not > have access to ksh88). > > An obvious workaround is to replace your

Re: t4204-patch-id failures

2016-05-23 Thread Junio C Hamano
Armin Kunaschik writes: > Essentially it's working like this: > > #!/bin/bash > > func1() { > name=${1} > echo "func1 name=$name" > } > > func2() { > name=${1} > echo "func2 name=$name" > func1 "ordered-$name" > echo "func2 again name=$name" > } >

t4204-patch-id failures

2016-05-23 Thread Armin Kunaschik
Hello, I see 3 test failures in t4202: expecting success: test_patch_id_file_order irrelevant --stable --stable Already on 'same' cmp: cannot open patch-id_ordered-ordered-order---stable-irrelevant not ok 7 - file order is irrelevant with --stable # # test_patch_id_file_ord