RE: suggestion for improved docs on autocrlf

2019-08-16 Thread Yagnatinsky, Mark
bject: Re: suggestion for improved docs on autocrlf On Thu, Aug 15, 2019 at 04:56:05AM +, Yagnatinsky, Mark wrote: > Okay, first attempt at better phrasing. This may need more paragraph breaks, > or something. > Right now it's very wall-of-texty. And probably in a style way too dif

Re: suggestion for improved docs on autocrlf

2019-08-15 Thread Torsten Bögershausen
On Thu, Aug 15, 2019 at 04:56:05AM +, Yagnatinsky, Mark wrote: > Okay, first attempt at better phrasing. This may need more paragraph breaks, > or something. > Right now it's very wall-of-texty. And probably in a style way too different > from the rest of the git docs. > Also, the syntax is

RE: suggestion for improved docs on autocrlf

2019-08-14 Thread Yagnatinsky, Mark
Okay, first attempt at better phrasing. This may need more paragraph breaks, or something. Right now it's very wall-of-texty. And probably in a style way too different from the rest of the git docs. Also, the syntax is probably closer to markdown than AsciiDoc; sorry. Anyway, enough disclaimers

RE: suggestion for improved docs on autocrlf

2019-08-14 Thread Yagnatinsky, Mark
Turns out that this is not intentional behavior of IntelliJ but an unfortunate interaction with a bug in git. Had I been using a more recent version of git, it wouldn't be happening. https://youtrack.jetbrains.com/issue/IDEA-205601 Patched docs on the way eventually. Hopefully it's okay if my sy

Re: suggestion for improved docs on autocrlf

2019-08-13 Thread Junio C Hamano
Torsten Bögershausen writes: >> Sigh. Okay, great, life makes sense again. I want to yell at my >> IDE now. >> >> I now feel brave enough to attempt to come up with better wording >> for autocrlf docs, if you think that's worth trying. > > That would be good, I am happy to review patches. Good

RE: suggestion for improved docs on autocrlf

2019-08-13 Thread Yagnatinsky, Mark
> Would you like to elobarate which IDE that is? IntelliJ from JetBrains. I'm planning on emailing them to at least mention this somewhere in their own docs, because I think it's not there. Will attempt revised wording soon-ish, but not promising today. -

Re: suggestion for improved docs on autocrlf

2019-08-13 Thread Torsten Bögershausen
On Tue, Aug 13, 2019 at 03:31:43PM +, Yagnatinsky, Mark wrote: > Thank you once more. Finally, I believe I understood everything you said. > I was about to say that this contradicts my own experience. > But then I remembered that I normally use my IDE rather than the command line. > And I just

RE: suggestion for improved docs on autocrlf

2019-08-13 Thread Yagnatinsky, Mark
Thank you once more. Finally, I believe I understood everything you said. I was about to say that this contradicts my own experience. But then I remembered that I normally use my IDE rather than the command line. And I just checked that indeed that the behavior of my IDE is totally different! It r

Re: suggestion for improved docs on autocrlf

2019-08-12 Thread Torsten Bögershausen
On Mon, Aug 12, 2019 at 11:18:35AM -0700, Junio C Hamano wrote: > "Yagnatinsky, Mark" writes: > > > ... Assuming the repo has no .gitattributes, > > is it possible to predict what line endings sample.txt will end up with in > > my repo? > > Or does it depend on more information than what I've ju

RE: suggestion for improved docs on autocrlf

2019-08-12 Thread Yagnatinsky, Mark
, Mark Cc: 'Torsten Bögershausen' ; 'git@vger.kernel.org' Subject: Re: suggestion for improved docs on autocrlf "Yagnatinsky, Mark" writes: > ... Assuming the repo has no .gitattributes, > is it possible to predict what line endings sample.txt will end up w

Re: suggestion for improved docs on autocrlf

2019-08-12 Thread Junio C Hamano
"Yagnatinsky, Mark" writes: > ... Assuming the repo has no .gitattributes, > is it possible to predict what line endings sample.txt will end up with in my > repo? > Or does it depend on more information than what I've just written? Binary packagers can ship custom attributes and config that ap

RE: suggestion for improved docs on autocrlf

2019-08-12 Thread Yagnatinsky, Mark
Okay, I feel like I'm on the verge of understanding, but it keeps eluding me, because you keep answering the question I actually asked, rather than the one I should have asked... let me try again, and bear with me if it seems like I'm repeating the same question over and over, because I don't unde

Re: suggestion for improved docs on autocrlf

2019-08-12 Thread Torsten Bögershausen
On Mon, Aug 12, 2019 at 01:47:18PM +, Yagnatinsky, Mark wrote: > Wait a second... suppose a file is committed with CRLF line endings. > You're saying that even if I have autocrlf set to "input" or "auto", the file > will never get "converted" to LF format unless I explicitly renormalize? Yes.

RE: suggestion for improved docs on autocrlf

2019-08-12 Thread Yagnatinsky, Mark
But I don't even have a git attributes file! There's no attribute flipping going on, I think. The CRLF'd file was committed by someone else on my team, who probably has git configured differently than I do. Or am I missing the point? -

Re: suggestion for improved docs on autocrlf

2019-08-12 Thread Junio C Hamano
"Yagnatinsky, Mark" writes: > Wait a second... suppose a file is committed with CRLF line > endings. You're saying that even if I have autocrlf set to > "input" or "auto", the file will never get "converted" to LF > format unless I explicitly renormalize? That sounds like a fairly > sensible be

RE: suggestion for improved docs on autocrlf

2019-08-12 Thread Yagnatinsky, Mark
Wait a second... suppose a file is committed with CRLF line endings. You're saying that even if I have autocrlf set to "input" or "auto", the file will never get "converted" to LF format unless I explicitly renormalize? That sounds like a fairly sensible behavior, but it's not what I've observed i

Re: suggestion for improved docs on autocrlf

2019-08-11 Thread Torsten Bögershausen
On Fri, Aug 09, 2019 at 03:34:05PM +, Yagnatinsky, Mark wrote: > After correcting spelling of renormalize, the end result of the script you > gave is that line endings in working directory are CRLF, > and in the repo are LF. > Is that expected? Yes. "git add" does typically not touch the file

RE: suggestion for improved docs on autocrlf

2019-08-09 Thread Yagnatinsky, Mark
After correcting spelling of renormalize, the end result of the script you gave is that line endings in working directory are CRLF, and in the repo are LF. Is that expected? Surprising? Not sure what you were trying to test there. I also fixed my script to use printf, new version is: (using co

Re: suggestion for improved docs on autocrlf

2019-08-08 Thread Torsten Bögershausen
On Thu, Aug 08, 2019 at 11:08:14PM +, Yagnatinsky, Mark wrote: > Okay, my attempt at better wording for the docs is not going well, because it > turns I that I still don't understand the behavior here! > I thought that "input" means that CRLF will become LF on "git add" but that > seems to be

RE: suggestion for improved docs on autocrlf

2019-08-08 Thread Yagnatinsky, Mark
Okay, my attempt at better wording for the docs is not going well, because it turns I that I still don't understand the behavior here! I thought that "input" means that CRLF will become LF on "git add" but that seems to be true only sometimes. For instance, consider the following 11-line shell sc

RE: suggestion for improved docs on autocrlf

2019-08-08 Thread Yagnatinsky, Mark
> Yes, do I read this as "I will send a patch" ? Probably not, but you can read it as "I will cook up better wording and reply to this thread" -- This message, and any attachments, is for the intended recipient(s) only, may cont

Re: suggestion for improved docs on autocrlf

2019-08-08 Thread Torsten Bögershausen
On Wed, Aug 07, 2019 at 01:08:22PM +, Yagnatinsky, Mark wrote: > I hope this is the right mailing list, hope someone will redirect me if not... Yes, you are at the right place, wellcome to the Git community. > The git documentation (git help config) for core.autocrlf doesn't mention > that f

suggestion for improved docs on autocrlf

2019-08-07 Thread Yagnatinsky, Mark
I hope this is the right mailing list, hope someone will redirect me if not... The git documentation (git help config) for core.autocrlf doesn't mention that false is a valid option; it only mentions true and input. Further, the docs for "input" are misleading, in that they lead the reader to ass