Re: segfault for git log --graph --no-walk --grep a

2013-02-11 Thread Junio C Hamano
Jeff King writes: > On Mon, Feb 11, 2013 at 12:36:52PM -0800, Junio C Hamano wrote: > >> Junio C Hamano writes: >> >> > Jeff King writes: >> > >> >> On Fri, Feb 08, 2013 at 04:47:01PM -0800, Junio C Hamano wrote: >> >> >> >>> > Yeah, that actually is a good point. We should be using >> >>> >

Re: segfault for git log --graph --no-walk --grep a

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 12:36:52PM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > Jeff King writes: > > > >> On Fri, Feb 08, 2013 at 04:47:01PM -0800, Junio C Hamano wrote: > >> > >>> > Yeah, that actually is a good point. We should be using logmsg_reencode > >>> > so that we look

Re: segfault for git log --graph --no-walk --grep a

2013-02-11 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> On Fri, Feb 08, 2013 at 04:47:01PM -0800, Junio C Hamano wrote: >> >>> > Yeah, that actually is a good point. We should be using logmsg_reencode >>> > so that we look for strings in the user's encoding. >>> >>> Perhaps like this. Just like the p

Re: segfault for git log --graph --no-walk --grep a

2013-02-11 Thread Junio C Hamano
Jeff King writes: > On Fri, Feb 08, 2013 at 04:47:01PM -0800, Junio C Hamano wrote: > >> > Yeah, that actually is a good point. We should be using logmsg_reencode >> > so that we look for strings in the user's encoding. >> >> Perhaps like this. Just like the previous one (which should be >> di

Re: segfault for git log --graph --no-walk --grep a

2013-02-11 Thread Jeff King
On Fri, Feb 08, 2013 at 04:47:01PM -0800, Junio C Hamano wrote: > > Yeah, that actually is a good point. We should be using logmsg_reencode > > so that we look for strings in the user's encoding. > > Perhaps like this. Just like the previous one (which should be > discarded), this makes the fun

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Jeff King
On Fri, Feb 08, 2013 at 08:05:24PM -0500, Jeff King wrote: > On Fri, Feb 08, 2013 at 04:47:01PM -0800, Junio C Hamano wrote: > > > > Yeah, that actually is a good point. We should be using logmsg_reencode > > > so that we look for strings in the user's encoding. > > > > Perhaps like this. Just

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Jeff King
On Fri, Feb 08, 2013 at 04:47:01PM -0800, Junio C Hamano wrote: > > Yeah, that actually is a good point. We should be using logmsg_reencode > > so that we look for strings in the user's encoding. > > Perhaps like this. Just like the previous one (which should be > discarded), this makes the fun

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> On Fri, Feb 08, 2013 at 04:22:15PM -0800, Junio C Hamano wrote: >> >>> Junio C Hamano writes: >>> >>> > Thomas Haller writes: >>> > >>> >> it happens in file revision.c:2306 because "commit->buffer" is zero: >>> >> >>> >> retval

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Junio C Hamano
Jeff King writes: > On Fri, Feb 08, 2013 at 04:22:15PM -0800, Junio C Hamano wrote: > >> Junio C Hamano writes: >> >> > Thomas Haller writes: >> > >> >> it happens in file revision.c:2306 because "commit->buffer" is zero: >> >> >> >> retval = grep_buffer(&opt->grep_filter, >> >

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Jeff King
On Fri, Feb 08, 2013 at 04:29:11PM -0800, Junio C Hamano wrote: > Perhaps something along this line... > > -- >8 -- > Subject: "log --grep": commit's buffer may already have been discarded > > Following up on be5c9fb9049e (logmsg_reencode: lazily load missing > commit buffers, 2013-01-26), extra

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Junio C Hamano
Junio C Hamano writes: > Junio C Hamano writes: > >> Thomas Haller writes: >> >>> it happens in file revision.c:2306 because "commit->buffer" is zero: >>> >>> retval = grep_buffer(&opt->grep_filter, >>> commit->buffer, >>> strlen(commit->buf

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Jeff King
On Fri, Feb 08, 2013 at 04:22:15PM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > Thomas Haller writes: > > > >> it happens in file revision.c:2306 because "commit->buffer" is zero: > >> > >> retval = grep_buffer(&opt->grep_filter, > >>

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Junio C Hamano
Junio C Hamano writes: > Thomas Haller writes: > >> it happens in file revision.c:2306 because "commit->buffer" is zero: >> >> retval = grep_buffer(&opt->grep_filter, >> commit->buffer, strlen(commit->buffer)); > > I think this has been fixed

Re: segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Junio C Hamano
Thomas Haller writes: > it happens in file revision.c:2306 because "commit->buffer" is zero: > > retval = grep_buffer(&opt->grep_filter, > commit->buffer, strlen(commit->buffer)); I think this has been fixed at be5c9fb9049e (logmsg_reencode: l

segfault for git log --graph --no-walk --grep a

2013-02-08 Thread Thomas Haller
Hallo, I just found that git crashes with a segmentation fault when calling $ git log --graph --no-walk --grep pattern It happens both for version 1.7.10.4 from Debian (wheezy,amd64) and a fresh compiled git from github (git.git repository, master). For the error to occure, the pattern must ma