Re: no-xmailer tests fail under Mac OS

2014-12-11 Thread Luis Henriques
Jeff King writes: > On Thu, Dec 11, 2014 at 02:11:04PM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote: >> > >> >> > Ah, right, we might be looking for 0 sometimes. The right way to do it >> >> > without destroying the &&

Re: no-xmailer tests fail under Mac OS

2014-12-11 Thread Jeff King
On Thu, Dec 11, 2014 at 02:11:04PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote: > > > >> > Ah, right, we might be looking for 0 sometimes. The right way to do it > >> > without destroying the &&-chaining is: > >> > > >> >

Re: no-xmailer tests fail under Mac OS

2014-12-11 Thread Junio C Hamano
Jeff King writes: > On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote: > >> > Ah, right, we might be looking for 0 sometimes. The right way to do it >> > without destroying the &&-chaining is: >> > >> > { grep ^X-Mailer: out || true } && >> > test_line_count = $expected mailer >>

Re: no-xmailer tests fail under Mac OS

2014-12-09 Thread Junio C Hamano
Michael Blume writes: > Failures start from > > commit d2384abff7a6181fd7b9a51af7e780aa21e5cb8d (refs/bisect/bad) > Author: Luis Henriques > Date: Thu Dec 4 19:11:30 2014 + > > test/send-email: --[no-]xmailer tests > > Add tests for the --[no-]xmailer option. > > Signed-off-by:

Re: no-xmailer tests fail under Mac OS

2014-12-05 Thread Jeff King
On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote: > > Ah, right, we might be looking for 0 sometimes. The right way to do it > > without destroying the &&-chaining is: > > > > { grep ^X-Mailer: out || true } && > > test_line_count = $expected mailer > > Hmm, it doesn't look like

Re: no-xmailer tests fail under Mac OS

2014-12-05 Thread Jeff King
On Fri, Dec 05, 2014 at 10:27:40PM -0800, Michael Blume wrote: > > We have had trouble in the past with "wc -l" output not being strictly > > portable. I do not recall offhand which systems, but it is a good bet > > that this is the culprit. Doing: > > > > grep ^X-Mailer: out >mailer && > > te

Re: no-xmailer tests fail under Mac OS

2014-12-05 Thread Michael Blume
On Fri, Dec 5, 2014 at 9:34 PM, Jeff King wrote: > On Fri, Dec 05, 2014 at 06:05:24PM -0800, Michael Blume wrote: > >> Failures start from >> >> commit d2384abff7a6181fd7b9a51af7e780aa21e5cb8d (refs/bisect/bad) >> Author: Luis Henriques >> Date: Thu Dec 4 19:11:30 2014 + >> >> test/send

Re: no-xmailer tests fail under Mac OS

2014-12-05 Thread Jeff King
On Fri, Dec 05, 2014 at 06:05:24PM -0800, Michael Blume wrote: > Failures start from > > commit d2384abff7a6181fd7b9a51af7e780aa21e5cb8d (refs/bisect/bad) > Author: Luis Henriques > Date: Thu Dec 4 19:11:30 2014 + > > test/send-email: --[no-]xmailer tests > > Add tests for the --

no-xmailer tests fail under Mac OS

2014-12-05 Thread Michael Blume
Failures start from commit d2384abff7a6181fd7b9a51af7e780aa21e5cb8d (refs/bisect/bad) Author: Luis Henriques Date: Thu Dec 4 19:11:30 2014 + test/send-email: --[no-]xmailer tests Add tests for the --[no-]xmailer option. Signed-off-by: Luis Henriques Signed-off-by: Junio