Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-05 Thread Antoine Pelisse
On Thu, Jul 4, 2013 at 2:46 PM, Orgad Shaneh wrote: > On Thu, Jul 4, 2013 at 3:42 PM, Antoine Pelisse wrote: Your problem is that your hook script is not checking $2 so it is overwriting the message even when you do not want to do so. >>> >>> No, it isn't. Not by git-gui at least. Check

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Orgad Shaneh
On Thu, Jul 4, 2013 at 3:42 PM, Antoine Pelisse wrote: >>> Your problem is that your hook script is not checking $2 so it is >>> overwriting the message even when you do not want to do so. >> >> No, it isn't. Not by git-gui at least. Check /tmp/hook.log with the >> hook I provided... > > So what y

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Antoine Pelisse
>> Your problem is that your hook script is not checking $2 so it is >> overwriting the message even when you do not want to do so. > > No, it isn't. Not by git-gui at least. Check /tmp/hook.log with the > hook I provided... So what you mean is that the hook is not executed with the correct parame

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Orgad Shaneh
On Thu, Jul 4, 2013 at 2:19 PM, John Keeping wrote: > On Thu, Jul 04, 2013 at 01:59:10PM +0300, Orgad Shaneh wrote: >> On Thu, Jul 4, 2013 at 1:34 PM, John Keeping wrote: >> > On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote: >> >> Hi, >> >> >> >> If a prepare-commit-msg hook is used,

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread John Keeping
On Thu, Jul 04, 2013 at 01:59:10PM +0300, Orgad Shaneh wrote: > On Thu, Jul 4, 2013 at 1:34 PM, John Keeping wrote: > > On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote: > >> Hi, > >> > >> If a prepare-commit-msg hook is used, git gui executes it for "New Commit". > >> > >> If the "New

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Fredrik Gustafsson
On Thu, Jul 04, 2013 at 01:59:10PM +0300, Orgad Shaneh wrote: > On Thu, Jul 4, 2013 at 1:34 PM, John Keeping wrote: > > On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote: > >> Hi, > >> > >> If a prepare-commit-msg hook is used, git gui executes it for "New Commit". > >> > >> If the "New

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Orgad Shaneh
On Thu, Jul 4, 2013 at 1:34 PM, John Keeping wrote: > On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote: >> Hi, >> >> If a prepare-commit-msg hook is used, git gui executes it for "New Commit". >> >> If the "New Commit" is selected, and then immediately "Amend" (before >> the hook retur

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread John Keeping
On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote: > Hi, > > If a prepare-commit-msg hook is used, git gui executes it for "New Commit". > > If the "New Commit" is selected, and then immediately "Amend" (before > the hook returns), when the hook returns the message is replaced with > t

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Fredrik Gustafsson
On Thu, Jul 04, 2013 at 01:03:31PM +0300, Orgad Shaneh wrote: > On Thu, Jul 4, 2013 at 1:01 PM, Fredrik Gustafsson wrote: > > On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote: > >> If a prepare-commit-msg hook is used, git gui executes it for "New Commit". > >> > >> If the "New Commit"

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Orgad Shaneh
On Thu, Jul 4, 2013 at 1:01 PM, Fredrik Gustafsson wrote: > On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote: >> If a prepare-commit-msg hook is used, git gui executes it for "New Commit". >> >> If the "New Commit" is selected, and then immediately "Amend" (before >> the hook returns),

Re: git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Fredrik Gustafsson
On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote: > If a prepare-commit-msg hook is used, git gui executes it for "New Commit". > > If the "New Commit" is selected, and then immediately "Amend" (before > the hook returns), when the hook returns the message is replaced with > the one pr

git gui replaces amend message when prepare-commit-msg hook is used

2013-07-04 Thread Orgad Shaneh
Hi, If a prepare-commit-msg hook is used, git gui executes it for "New Commit". If the "New Commit" is selected, and then immediately "Amend" (before the hook returns), when the hook returns the message is replaced with the one produced by the hook. - Orgad -- To unsubscribe from this list: send