Re: git diff does not precompose unicode file paths (OS X)

2016-04-04 Thread Alexander Rinass
> On 15 Mar 2016, at 06:45, Torsten Bögershausen wrote: > > >I created a test case but git diff exits with 0 if it does not recognize the > >file >path so the test case always succeeds. Can you give me a hint or one > >>example test case? > > The most clean (?) is to compare "git diff" NFC an

Re: git diff does not precompose unicode file paths (OS X)

2016-03-14 Thread Torsten Bögershausen
>I created a test case but git diff exits with 0 if it does not recognize the file >path so the test case always succeeds. Can you give me a hint or one >example test case? The most clean (?) is to compare "git diff" NFC and git diff NFD, they should give the same result: for "git diff" somet

Re: git diff does not precompose unicode file paths (OS X)

2016-03-14 Thread Alexander Rinass
> On 08 Mar 2016, at 13:30, Torsten Bögershausen wrote: > >>> And if not, I can put it on my TODO-stack. >> I have read through the official contribution guidelines and I think I can >> send an official patch. >> >> In this case, would you prefer to have a single commit since the change >> is r

Re: git diff does not precompose unicode file paths (OS X)

2016-03-08 Thread Torsten Bögershausen
And if not, I can put it on my TODO-stack. I have read through the official contribution guidelines and I think I can send an official patch. In this case, would you prefer to have a single commit since the change is related? Or would you prefer keeping it in separate commits, since they are dif

Re: git diff does not precompose unicode file paths (OS X)

2016-03-07 Thread Torsten Bögershausen
On 03/07/2016 08:47 AM, Alexander Rinass wrote: On 04 Mar 2016, at 19:49, Ramsay Jones wrote: On 04/03/16 14:37, Alexander Rinass wrote: On 04 Mar 2016, at 13:16, Torsten Bögershausen wrote: On 03/04/2016 10:07 AM, Alexander Rinass wrote: [snip] Sticking a precompose_argv(argc, argv) in

Re: git diff does not precompose unicode file paths (OS X)

2016-03-06 Thread Alexander Rinass
> On 04 Mar 2016, at 19:49, Ramsay Jones wrote: > > > > On 04/03/16 14:37, Alexander Rinass wrote: >> >>> On 04 Mar 2016, at 13:16, Torsten Bögershausen wrote: >>> >>> On 03/04/2016 10:07 AM, Alexander Rinass wrote: > [snip] > >> >> Sticking a precompose_argv(argc, argv) into diff.c’s cmd

Re: git diff does not precompose unicode file paths (OS X)

2016-03-04 Thread Ramsay Jones
On 04/03/16 14:37, Alexander Rinass wrote: > >> On 04 Mar 2016, at 13:16, Torsten Bögershausen wrote: >> >> On 03/04/2016 10:07 AM, Alexander Rinass wrote: [snip] > > Sticking a precompose_argv(argc, argv) into diff.c’s cmd_diff function fixes > the issue. > > But I had to disable the check

Re: git diff does not precompose unicode file paths (OS X)

2016-03-04 Thread Junio C Hamano
Alexander Rinass writes: > Sticking a precompose_argv(argc, argv) into diff.c’s cmd_diff > function fixes the issue. > > But I had to disable the check (precomposed_unicode != 1) in > precompose_argv to make it work. That’s probably because > precompose_argv is usually called from parse_options a

Re: git diff does not precompose unicode file paths (OS X)

2016-03-04 Thread Alexander Rinass
> On 04 Mar 2016, at 13:16, Torsten Bögershausen wrote: > > On 03/04/2016 10:07 AM, Alexander Rinass wrote: >> Hallo, >> >> It appears that the git diff command does not precompose file path >> arguments, even if the option core.precomposeunicode is set to true (which >> is the default on OS

Re: git diff does not precompose unicode file paths (OS X)

2016-03-04 Thread Torsten Bögershausen
On 03/04/2016 10:07 AM, Alexander Rinass wrote: Hallo, It appears that the git diff command does not precompose file path arguments, even if the option core.precomposeunicode is set to true (which is the default on OS X). Passing the decomposed form of a file path to the git diff command will

git diff does not precompose unicode file paths (OS X)

2016-03-04 Thread Alexander Rinass
Hallo, It appears that the git diff command does not precompose file path arguments, even if the option core.precomposeunicode is set to true (which is the default on OS X). Passing the decomposed form of a file path to the git diff command will yield no diff for a modified file. In my case,