Re: git describe --contains doesn't work properly for a commit

2015-03-04 Thread Junio C Hamano
Jeff King writes: > On Wed, Mar 04, 2015 at 12:41:57PM -0800, Junio C Hamano wrote: > > >> This one, and $gmane/264101, are a few instances of this known issue >> raised here recently. > > If $gmane/264101 is caused by clock skew, I'd find that disturbing. > Those algorithms are supposed to be "c

Re: git describe --contains doesn't work properly for a commit

2015-03-04 Thread Jeff King
On Wed, Mar 04, 2015 at 12:41:57PM -0800, Junio C Hamano wrote: > > Calculating them is simple. Caching and storage is the bigger question. > > Yes, also having to handle the ones whose generation numbers haven't > been computed yet adds to the complexity. I'm not sure it's that bad. If you cach

Re: git describe --contains doesn't work properly for a commit

2015-03-04 Thread Mike Hommey
On Wed, Mar 04, 2015 at 12:41:57PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > On Wed, Mar 04, 2015 at 04:06:17PM +0100, Michael J Gruber wrote: > > > >> Complexity: Was that due to replace refs? Other than that, it seemed to > >> be simple: max(parent generation numbers)+1. > > > > Ca

Re: git describe --contains doesn't work properly for a commit

2015-03-04 Thread Junio C Hamano
Jeff King writes: > On Wed, Mar 04, 2015 at 04:06:17PM +0100, Michael J Gruber wrote: > >> Complexity: Was that due to replace refs? Other than that, it seemed to >> be simple: max(parent generation numbers)+1. > > Calculating them is simple. Caching and storage is the bigger question. Yes, also

Re: git describe --contains doesn't work properly for a commit

2015-03-04 Thread Jeff King
On Wed, Mar 04, 2015 at 04:06:17PM +0100, Michael J Gruber wrote: > > 3. Introduce a more trust-worthy mechanism for ordering commits. The > > timestamp here is really just a proxy for the oft-discussed > > "generation number" of the commit within the graph. We've avoided > > addi

Re: git describe --contains doesn't work properly for a commit

2015-03-04 Thread Michael J Gruber
Jeff King venit, vidit, dixit 04.03.2015 11:54: > On Thu, Feb 26, 2015 at 03:23:14PM +0100, Michal Hocko wrote: > >> The commit in the middle was ammended to have committer date in the >> past. >> $ git describe --contains d63972e4e4e7eda0444e56739ad09bfbc476b9bd >> tag~1 >> >> but >> $ git descri

Re: git describe --contains doesn't work properly for a commit

2015-03-04 Thread Jeff King
On Thu, Feb 26, 2015 at 03:23:14PM +0100, Michal Hocko wrote: > The commit in the middle was ammended to have committer date in the > past. > $ git describe --contains d63972e4e4e7eda0444e56739ad09bfbc476b9bd > tag~1 > > but > $ git describe --contains 108a0d5972fd2e5f25b2f38cfd2fee73031ff9d3 > f

Re: git describe --contains doesn't work properly for a commit

2015-02-26 Thread Michal Hocko
On Thu 26-02-15 14:35:34, Michal Hocko wrote: > Hi, > I have just encountered an old kernel git commit: > commit c854363e80b49dd04a4de18ebc379eb8c8806674 > Author: Dave Chinner > Date: Sat Feb 6 12:39:36 2010 +1100 > > xfs: Use delayed write for inodes rather than async V2 > [...] OK, I'v

git describe --contains doesn't work properly for a commit

2015-02-26 Thread Michal Hocko
Hi, I have just encountered an old kernel git commit: commit c854363e80b49dd04a4de18ebc379eb8c8806674 Author: Dave Chinner Date: Sat Feb 6 12:39:36 2010 +1100 xfs: Use delayed write for inodes rather than async V2 [...] which cannot be described properly: $ git describe --contains c854363e