RE: git clone silently aborts if stdout gets a broken pipe

2013-09-19 Thread Peter Kjellerstedt
> -Original Message- > From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On > Behalf Of Jeff King > Sent: den 19 september 2013 10:36 > To: Peter Kjellerstedt > Cc: Junio C Hamano; Nguyen Thai Ngoc Duy; git@vger.kernel.org > Subject: Re: git clone sile

Re: git clone silently aborts if stdout gets a broken pipe

2013-09-19 Thread Jeff King
On Thu, Sep 19, 2013 at 09:54:38AM +0200, Peter Kjellerstedt wrote: > > I think your perl script is somewhat questionable, as it is making > > assumptions about the output of git-clone, and you would do better to > > accept arbitrary-sized output > > Well, the whole idea of using Git::command_on

RE: git clone silently aborts if stdout gets a broken pipe

2013-09-19 Thread Peter Kjellerstedt
> -Original Message- > From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On > Behalf Of Jeff King > Sent: den 18 september 2013 20:46 > To: Peter Kjellerstedt > Cc: Junio C Hamano; Nguyen Thai Ngoc Duy; git@vger.kernel.org > Subject: Re: git clone sile

Re: git clone silently aborts if stdout gets a broken pipe

2013-09-18 Thread Jeff King
On Wed, Sep 18, 2013 at 12:31:23PM -0700, Junio C Hamano wrote: > > Hrm, this actually breaks t5701, which expects "clone 2>err" to print > > nothing to stderr. > > Hmm, where in t5701? Ah, you meant t5702 and possibly t5601. Yes, sorry, I meant t5702. > I actually think "it is long and not me

Re: git clone silently aborts if stdout gets a broken pipe

2013-09-18 Thread Junio C Hamano
Jeff King writes: > On Wed, Sep 18, 2013 at 02:45:51PM -0400, Jeff King wrote: > >> That being said, the new messages should almost certainly go to stderr. >> >> -- >8 -- >> Subject: [PATCH] clone: write "checking connectivity" to stderr >> >> In commit 0781aa4 (clone: let the user know when >>

Re: git clone silently aborts if stdout gets a broken pipe

2013-09-18 Thread Jeff King
On Wed, Sep 18, 2013 at 02:45:51PM -0400, Jeff King wrote: > That being said, the new messages should almost certainly go to stderr. > > -- >8 -- > Subject: [PATCH] clone: write "checking connectivity" to stderr > > In commit 0781aa4 (clone: let the user know when > check_everything_connected is

Re: git clone silently aborts if stdout gets a broken pipe

2013-09-18 Thread Jeff King
On Wed, Sep 18, 2013 at 06:52:13PM +0200, Peter Kjellerstedt wrote: > The failing Perl code used a construct like this: > > Git::command_oneline('clone', $url, $path); > > There is no error raised, but the directory specified by > $path is not created. If I look at the process using strac

git clone silently aborts if stdout gets a broken pipe

2013-09-18 Thread Peter Kjellerstedt
One of our Perl scripts that does a git clone suddenly started to fail when I upgraded to git 1.8.4 from 1.8.3.1. The failing Perl code used a construct like this: Git::command_oneline('clone', $url, $path); There is no error raised, but the directory specified by $path is not created.