Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-04 Thread Pratyush Yadav
On 04/09/19 09:39PM, Bert Wesarg wrote: > On Tue, Sep 3, 2019 at 7:15 PM Pratyush Yadav wrote: > > > > On 02/09/19 09:13PM, Bert Wesarg wrote: [snip] > > > > One more observation: > > > > If I write a particularly long line (and consequently the scrollbar > > becomes active), and then hit Ctrl+A t

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-04 Thread Bert Wesarg
On Tue, Sep 3, 2019 at 7:15 PM Pratyush Yadav wrote: > > On 02/09/19 09:13PM, Bert Wesarg wrote: > > On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg > > wrote: > > > > [snip] > > > > On second thought, wouldn't it make more sense to expand the > > > > commit > > > > message buffer instead? The point

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-04 Thread Pratyush Yadav
On 04/09/19 07:42AM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > > Just wanted to chime in on this one: > > On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote: > > On second thought, wouldn't it make more sense to expand the commit > > message buffer instead? The point of resizing that p

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-03 Thread Birger Skogeng Pedersen
Hi Pratyush, Just wanted to chime in on this one: On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote: > On second thought, wouldn't it make more sense to expand the commit > message buffer instead? The point of resizing that pane is to see more > of the commit message. So it makes more sense t

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-03 Thread Pratyush Yadav
On 02/09/19 09:13PM, Bert Wesarg wrote: > On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg wrote: > > [snip] > > > On second thought, wouldn't it make more sense to expand the > > > commit > > > message buffer instead? The point of resizing that pane is to see more > > > of the commit message. So it ma

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Birger Skogeng Pedersen
Bert, Works great now. Thanks a lot for fixing this! Birger

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Bert Wesarg
On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg wrote: > > On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote: > > > > On 03/09/19 12:14AM, Pratyush Yadav wrote: > > > On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote: > > > > On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg > > > > wrote: > > > > > I c

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Bert Wesarg
On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote: > > On 03/09/19 12:14AM, Pratyush Yadav wrote: > > On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote: > > > On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg > > > wrote: > > > > I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6: > >

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Pratyush Yadav
On 03/09/19 12:14AM, Pratyush Yadav wrote: > On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote: > > On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg > > wrote: > > > I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6: > > > > > > https://kgab.selfhost.eu/s/f38GX4caCZBj4mZ > > > > On Mon

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Birger Skogeng Pedersen
On Mon, Sep 2, 2019 at 7:58 PM Bert Wesarg wrote: > up to now, git-gui does not hide any scrollbars, if they are not > needed. IMHO, I would keep it that way, as I don't like the flicker > when it appears and disappears. Imagine you are typing in the bottom > line and than you typed too much. The

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Pratyush Yadav
On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote: > On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg wrote: > > I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6: > > > > https://kgab.selfhost.eu/s/f38GX4caCZBj4mZ > > On Mon, Sep 2, 2019 at 8:12 PM Pratyush Yadav wrote: > > Hmm, it lo

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Birger Skogeng Pedersen
On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg wrote: > I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6: > > https://kgab.selfhost.eu/s/f38GX4caCZBj4mZ On Mon, Sep 2, 2019 at 8:12 PM Pratyush Yadav wrote: > Hmm, it looks fine for me. Which platform are you using? I am running it > o

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Pratyush Yadav
On 02/09/19 07:04PM, Birger Skogeng Pedersen wrote: > Hi Bert, > > > Thanks for picking this up. > I just gave your patch a go, and I think there are a couple of issues. > > > Applying the patch yields: > > $ git apply patch1.patch > patch1.patch:18: indent with spaces. >-yscrollcomman

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Bert Wesarg
On Mon, Sep 2, 2019 at 7:35 PM Junio C Hamano wrote: > > Bert Wesarg writes: > > > the old reasoning was, that you should not create commit messages > > which are too wide. > > True, and that reasoning would justify hiding scrollbar when not > necessary to gain vertical space. Can we arrange the

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Junio C Hamano
Bert Wesarg writes: > the old reasoning was, that you should not create commit messages > which are too wide. True, and that reasoning would justify hiding scrollbar when not necessary to gain vertical space. Can we arrange the scrollbar to appear only when needed?

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Birger Skogeng Pedersen
Hi Bert, Thanks for picking this up. I just gave your patch a go, and I think there are a couple of issues. Applying the patch yields: $ git apply patch1.patch patch1.patch:18: indent with spaces. -yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set} \ patch1.patch:19: indent wit

Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Bert Wesarg
Hi Birger, On Mon, Sep 2, 2019 at 11:13 AM Birger Skogeng Pedersen wrote: > > Hi, > > I just noticed that long lines in the commit message widget does in > fact not show a horizontal scrollbar. > So if a line in the commit message is more than 75 characters, it gets > a bit confusing. > Should it

git-gui: Long lines in commit message gets hidden, no scrollbar appears

2019-09-02 Thread Birger Skogeng Pedersen
Hi, I just noticed that long lines in the commit message widget does in fact not show a horizontal scrollbar. So if a line in the commit message is more than 75 characters, it gets a bit confusing. Should it not have a scrollbar? Example shown here: https://i.imgur.com/I3d6nBJ.png