Re: format-patch subject-prefix gets truncated when using the --numbered flag

2017-02-28 Thread Jeff King
On Tue, Feb 28, 2017 at 11:33:55AM -0800, Junio C Hamano wrote: > And having said all that, if we really want to allow overlong > subject prefix that would end up hiding the real title of the patch, > a modern way to do so would be to use xstrfmt() like the attached > toy-patch does. If you are g

Re: format-patch subject-prefix gets truncated when using the --numbered flag

2017-02-28 Thread Junio C Hamano
Junio C Hamano writes: > Adrian Dudau writes: > >> I noticed that the --subject-prefix string gets truncated sometimes, >> but only when using the --numbered flat. Here's an example: >> >> addu@sestofb11:/data/fb/addu/git$ export longm="very very very very >> very very very very very very very v

Re: format-patch subject-prefix gets truncated when using the --numbered flag

2017-02-28 Thread Jeff King
On Tue, Feb 28, 2017 at 03:59:16PM +, Adrian Dudau wrote: > This is happening on the latest master branch, so I dug through the > code and tracked the issue to this piece of code in log-tree.c: > > if (opt->total > 0) { > static char buffer[64]; > snpri

Re: format-patch subject-prefix gets truncated when using the --numbered flag

2017-02-28 Thread Junio C Hamano
Adrian Dudau writes: > I noticed that the --subject-prefix string gets truncated sometimes, > but only when using the --numbered flat. Here's an example: > > addu@sestofb11:/data/fb/addu/git$ export longm="very very very very > very very very very very very very very very very long prefix" This

format-patch subject-prefix gets truncated when using the --numbered flag

2017-02-28 Thread Adrian Dudau
Hello, I noticed that the --subject-prefix string gets truncated sometimes, but only when using the --numbered flat. Here's an example: addu@sestofb11:/data/fb/addu/git$ export longm="very very very very very very very very very very very very very very long prefix" addu@sestofb11:/data/fb/addu