Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-11 Thread Pratyush Yadav
On 12/09/19 12:04AM, Pratyush Yadav wrote: > On 11/09/19 12:27PM, Birger Skogeng Pedersen wrote: > > Hi Pratyush, > > > > I'm hoping this will be merged, even without changing the radio > > selectors to a checkbox(?). The patch from Bert resolves the issue I > > raised about wanting the hotkey. >

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-11 Thread Pratyush Yadav
On 11/09/19 12:27PM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > I'm hoping this will be merged, even without changing the radio > selectors to a checkbox(?). The patch from Bert resolves the issue I > raised about wanting the hotkey. > What do you think? What do you mean by "this"? I am gu

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-11 Thread Birger Skogeng Pedersen
Hi Pratyush, I'm hoping this will be merged, even without changing the radio selectors to a checkbox(?). The patch from Bert resolves the issue I raised about wanting the hotkey. What do you think? Birger

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-10 Thread David Aguilar
On Wed, Sep 04, 2019 at 09:03:02PM +0200, Bert Wesarg wrote: > On Wed, Sep 4, 2019 at 8:52 PM Johannes Sixt wrote: > > > > Am 04.09.19 um 19:46 schrieb Pratyush Yadav: > > > On 04/09/19 08:24AM, Johannes Sixt wrote: > > >> That is worth a try. The check box title offers a natural hotkey then: > >

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-04 Thread Bert Wesarg
On Wed, Sep 4, 2019 at 8:52 PM Johannes Sixt wrote: > > Am 04.09.19 um 19:46 schrieb Pratyush Yadav: > > On 04/09/19 08:24AM, Johannes Sixt wrote: > >> That is worth a try. The check box title offers a natural hotkey then: > >> "_A_mend last commit", Alt-a. > > > > Right now, the binding proposed

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-04 Thread Johannes Sixt
Am 04.09.19 um 19:46 schrieb Pratyush Yadav: > On 04/09/19 08:24AM, Johannes Sixt wrote: >> That is worth a try. The check box title offers a natural hotkey then: >> "_A_mend last commit", Alt-a. > > Right now, the binding proposed is Ctrl-e. My mental model for the key > bindings as of now is h

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-04 Thread Birger Skogeng Pedersen
Hi, You could argue that A (as in "amend") makes quite an intuitive hotkey. But personally I'm also leaning towards CTRL/CMD+E. The ALT+(letter) combination is used to open a menu, for instance ALT+R opens "Repository", ALT+E opens "Edit", etc. That's the behaviour on Windows, anyways. So the hotk

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-04 Thread Pratyush Yadav
On 04/09/19 08:24AM, Johannes Sixt wrote: > Am 03.09.19 um 14:45 schrieb Pratyush Yadav: > > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it > > immediately takes me to the "Amend last commit" option. Then I can press > > space to select it and Tab again to get back to the

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-03 Thread Johannes Sixt
Am 03.09.19 um 14:45 schrieb Pratyush Yadav: > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it > immediately takes me to the "Amend last commit" option. Then I can press > space to select it and Tab again to get back to the commit message. That works on Windows with Ctrl+S

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-03 Thread Pratyush Yadav
On 03/09/19 04:06PM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > > On Tue, Sep 3, 2019 at 2:45 PM Pratyush Yadav wrote: > > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it > > immediately takes me to the "Amend last commit" option. Then I can press > > space to selec

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-03 Thread Pratyush Yadav
On 04/09/19 01:35AM, David wrote: > On Tue, 3 Sep 2019 at 22:45, Pratyush Yadav wrote: > > > > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it > > immediately takes me to the "Amend last commit" option. Then I can press > > space to select it and Tab again to get back to the

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-03 Thread David
On Tue, 3 Sep 2019 at 22:45, Pratyush Yadav wrote: > > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it > immediately takes me to the "Amend last commit" option. Then I can press > space to select it and Tab again to get back to the commit message. Hi Pratyush Yadav, Yes, w

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-03 Thread Birger Skogeng Pedersen
Hi Pratyush, On Tue, Sep 3, 2019 at 2:45 PM Pratyush Yadav wrote: > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it > immediately takes me to the "Amend last commit" option. Then I can press > space to select it and Tab again to get back to the commit message. It seems th

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-03 Thread Pratyush Yadav
On 03/09/19 07:37AM, Birger Skogeng Pedersen wrote: > On Mon, Sep 2, 2019 at 10:15 PM Bert Wesarg > wrote: > > does Control-Tab works for traversal? > > > Bert, > > Control+Tab works for traversal, but as a means to toggle new/amend > it's very tedious. I have to press Ctrl+Tab 9 times to sele

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-03 Thread Bert Wesarg
David, On Tue, Sep 3, 2019 at 3:01 AM David wrote: > > On Tue, 3 Sep 2019 at 04:11, Bert Wesarg wrote: > > On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen > > wrote: > > > On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen > > > wrote: > > > > > In my pursuit to fully utilize gi

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-02 Thread Birger Skogeng Pedersen
On Mon, Sep 2, 2019 at 10:15 PM Bert Wesarg wrote: > does Control-Tab works for traversal? Bert, Control+Tab works for traversal, but as a means to toggle new/amend it's very tedious. I have to press Ctrl+Tab 9 times to select "new" and 10 times to select "Amend"(!). Then 1 or 2 more times to g

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-02 Thread David
On Tue, 3 Sep 2019 at 04:11, Bert Wesarg wrote: > On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen > wrote: > > On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen > > wrote: > > > In my pursuit to fully utilize git-gui with only using a keyboard, I > > > suggest that there is a ho

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-02 Thread Bert Wesarg
On Mon, Sep 2, 2019 at 10:12 PM Bert Wesarg wrote: > > On Mon, Sep 2, 2019 at 9:49 PM Birger Skogeng Pedersen > wrote: > > > > Hi Bert, > > > > > > On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg > > wrote: > > > I think with your "focus" patch, this is not needed anymore: > > > > > > After focusing

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-02 Thread Bert Wesarg
On Mon, Sep 2, 2019 at 9:49 PM Birger Skogeng Pedersen wrote: > > Hi Bert, > > > On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg wrote: > > I think with your "focus" patch, this is not needed anymore: > > > > After focusing the commit message widget, you can focus the radio > > buttons with Tab/Shift+

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-02 Thread Birger Skogeng Pedersen
Hi Bert, On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg wrote: > I think with your "focus" patch, this is not needed anymore: > > After focusing the commit message widget, you can focus the radio > buttons with Tab/Shift+Tab and press Space. > > I think this is short enough, so that wasting a Letter

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-02 Thread Bert Wesarg
Birger, On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen wrote: > > I just now realized what a terrible suggestion CTRL+Z was. > I propose CTRL/CMD+E to toggle between amend/new commit. > > On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen > wrote: > > > > In my pursuit to fully uti

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-02 Thread Birger Skogeng Pedersen
I just now realized what a terrible suggestion CTRL+Z was. I propose CTRL/CMD+E to toggle between amend/new commit. On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen wrote: > > In my pursuit to fully utilize git-gui with only using a keyboard, I > suggest that there is a hotkey to toggle b

feature request, git-gui: add hotkey to toggle amend/new

2019-08-31 Thread Birger Skogeng Pedersen
In my pursuit to fully utilize git-gui with only using a keyboard, I suggest that there is a hotkey to toggle between selecting "New Commit" and "Amend Last Commit". Not sure which key-combination that fits this purpose best, but my suggestion is CTRL/CMD+Z. Best regards, Birger