Re: contrib/credential/netrc/git-credential-netrc: Use of uninitialized value in string

2013-10-08 Thread Ted Zlatanov
On Tue, 3 Sep 2013 13:35:44 -0400 Jeff King wrote: JK> On Tue, Sep 03, 2013 at 11:23:14AM -0400, Ted Zlatanov wrote: >> Yes, you're right. Something like the following (untested) could work >> and does the wildcards, which I will make into a proper patch and test >> if it looks OK to you. ... J

Re: contrib/credential/netrc/git-credential-netrc: Use of uninitialized value in string

2013-09-03 Thread Jeff King
On Tue, Sep 03, 2013 at 11:23:14AM -0400, Ted Zlatanov wrote: > Yes, you're right. Something like the following (untested) could work > and does the wildcards, which I will make into a proper patch and test > if it looks OK to you. > > Ted > > diff --git a/contrib/credential/netrc/git-credentia

Re: contrib/credential/netrc/git-credential-netrc: Use of uninitialized value in string

2013-09-03 Thread Ted Zlatanov
On Tue, 27 Aug 2013 16:05:51 -0400 Jeff King wrote: JK> On Mon, Aug 26, 2013 at 08:56:23PM -0700, Junio C Hamano wrote: >> Antoine Pelisse writes: >> >> > I've tried to use the netrc credential with git-send-email >> > (v1.8.4-rc2), and I've had the following log (running with -d -v): >> >> P

Re: contrib/credential/netrc/git-credential-netrc: Use of uninitialized value in string

2013-08-27 Thread Jeff King
On Mon, Aug 26, 2013 at 08:56:23PM -0700, Junio C Hamano wrote: > Antoine Pelisse writes: > > > I've tried to use the netrc credential with git-send-email > > (v1.8.4-rc2), and I've had the following log (running with -d -v): > > Peff what do you think? From credential layer's point of view, I

Re: contrib/credential/netrc/git-credential-netrc: Use of uninitialized value in string

2013-08-26 Thread Junio C Hamano
Antoine Pelisse writes: > I've tried to use the netrc credential with git-send-email > (v1.8.4-rc2), and I've had the following log (running with -d -v): Peff what do you think? From credential layer's point of view, I think we make it totally up to the helper to decide if a request matches wha

contrib/credential/netrc/git-credential-netrc: Use of uninitialized value in string

2013-08-24 Thread Antoine Pelisse
Hello, I've tried to use the netrc credential with git-send-email (v1.8.4-rc2), and I've had the following log (running with -d -v): We were given search token protocol and value smtp We were given search token host and value smtp.gmail.com:587 We were given search token username and value apeli..