Re: compile error in Git v2.7.0-rc0

2015-12-14 Thread Junio C Hamano
On Mon, Dec 14, 2015 at 12:52 PM, Jeff King wrote: > On Mon, Dec 14, 2015 at 03:46:25PM -0500, Jeff King wrote: > >> I don't think that fix is right, though. We should be passing "host" to >> gethostbyname. > > Here it is in patch form. It can go on top of ep/ident-with-getaddrinfo. Thanks. I r

Re: compile error in Git v2.7.0-rc0

2015-12-14 Thread Jeff King
On Mon, Dec 14, 2015 at 03:46:25PM -0500, Jeff King wrote: > I don't think that fix is right, though. We should be passing "host" to > gethostbyname. Here it is in patch form. It can go on top of ep/ident-with-getaddrinfo. -- >8 -- Subject: [PATCH] ident: fix undefined variable when NO_IPV6 is s

Re: compile error in Git v2.7.0-rc0

2015-12-14 Thread Jeff King
On Mon, Dec 14, 2015 at 12:35:25PM -0800, Junio C Hamano wrote: > johan defries writes: > > > Probably because I have NO_IPV6 defined. > > > > ident.c: In function ‘canonical_name’: > > ident.c:89:37: error: ‘buf’ undeclared (first use in this function) > > struct hostent *he = gethostbyname(b

Re: compile error in Git v2.7.0-rc0

2015-12-14 Thread Junio C Hamano
johan defries writes: > Probably because I have NO_IPV6 defined. > > ident.c: In function ‘canonical_name’: > ident.c:89:37: error: ‘buf’ undeclared (first use in this function) > struct hostent *he = gethostbyname(buf); > ^ > ident.c:89:37: note: each undec

compile error in Git v2.7.0-rc0

2015-12-14 Thread johan defries
Probably because I have NO_IPV6 defined. ident.c: In function ‘canonical_name’: ident.c:89:37: error: ‘buf’ undeclared (first use in this function) struct hostent *he = gethostbyname(buf); ^ ident.c:89:37: note: each undeclared identifier is reported only onc