Re: change symlink

2012-10-31 Thread Jeff King
On Wed, Oct 31, 2012 at 08:30:57AM -0400, Jeff King wrote: > Something like this seems to fix it for me, but I am not sure if that > would affect other callers. > [...] > + return !is_dir || !S_ISGITLINK(istate->cache[pos]->ce_mode); That's completely wrong, of course. It should be:

Re: change symlink

2012-10-31 Thread Jeff King
On Wed, Oct 31, 2012 at 08:05:05AM -0400, Jeff King wrote: > > however (what got me started wondering about this and a point i forgot > > about) - t2/one/test doesn't show up under 'untracked files' in in > > status that scenario. shouldn't it? > > Yes, I think that is a bug. > > My guess is tha

Re: change symlink

2012-10-31 Thread Jeff King
On Tue, Oct 30, 2012 at 10:22:04PM +, shawn wilson wrote: > On Tue, Oct 30, 2012 at 10:09 PM, Andreas Schwab > wrote: > > shawn wilson writes: > > > >> and once it's added, status says: > >> # renamed:t2 -> t2/one/test > >> > >> that's not exactly true, but... > > > > What's wrong

Re: change symlink

2012-10-30 Thread shawn wilson
On Tue, Oct 30, 2012 at 10:09 PM, Andreas Schwab wrote: > shawn wilson writes: > >> and once it's added, status says: >> # renamed:t2 -> t2/one/test >> >> that's not exactly true, but... > > What's wrong with it? Both files have the same contents, which is the > link target for symlink

Re: change symlink

2012-10-30 Thread Andreas Schwab
shawn wilson writes: > and once it's added, status says: > # renamed:t2 -> t2/one/test > > that's not exactly true, but... What's wrong with it? Both files have the same contents, which is the link target for symlinks. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key finge

Re: change symlink

2012-10-30 Thread Andreas Schwab
shawn wilson writes: > why is this different? You didn't tell git about t2/one/test. You need to add it first to make it known. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely differe

Re: change symlink

2012-10-30 Thread shawn wilson
On Tue, Oct 30, 2012 at 9:35 PM, Andreas Schwab wrote: > shawn wilson writes: > >> but should t2 be reported as 'deleted'? > > Sure, that's what you did. > if i do the same to a file (same repo): touch test2 git add test2 git commit test2 -m "test2" rm test ln -s test2 test git status # On b

Re: change symlink

2012-10-30 Thread Andreas Schwab
shawn wilson writes: > but should t2 be reported as 'deleted'? Sure, that's what you did. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list:

Re: change symlink

2012-10-30 Thread shawn wilson
On Tue, Oct 30, 2012 at 9:19 PM, Andreas Schwab wrote: > shawn wilson writes: >> % git status >> # On branch master >> # Changes not staged for commit: >> # (use "git add/rm ..." to update what will be committed) >> # (use "git checkout -- ..." to discard changes in working directory) >> #

Re: change symlink

2012-10-30 Thread Andreas Schwab
shawn wilson writes: > i'm curious why this is being reported as deleted in status and diff > and not modified? this was tested on a build of the master branch of > the current git repo (1.8.0). > > mkdir t cd t; git --init > > touch test > git add test > git commit test -m "test" > > ln -s test