Re: cgit and global configuration

2019-06-12 Thread Jeff King
On Tue, Jun 11, 2019 at 04:22:32PM -0400, Jeff Hostetler wrote: > As for going forward, I see 3 options: > > [1] update your tests to allow this. (I didn't dig thru your > tests to see how extensive this might be.) > > [2] define your own version of common-main.c and link with it > inst

Re: cgit and global configuration

2019-06-11 Thread Jeff Hostetler
On 6/11/2019 11:04 AM, Christian Hesse wrote: Dear Jeff, dear Junio, for cgit we use the static git library built into the executable. This used to work well, but breaks with latest release v2.22.0: Our code unsets HOME and XDG_CONFIG_HOME to mitigate loading arbitrary configuration. We have

Re: cgit and global configuration

2019-06-11 Thread Junio C Hamano
Christian Hesse writes: > With the new trace2 code in place at least tracing configuration is loaded > before cmd_main() kicks in. This happens in trace2_initialize_fl() -> > tr2_sysenv_load() -> read_very_early_config(). I think that is as designed. > The offending commit is > bce9db6d ("trace

cgit and global configuration

2019-06-11 Thread Christian Hesse
Dear Jeff, dear Junio, for cgit we use the static git library built into the executable. This used to work well, but breaks with latest release v2.22.0: Our code unsets HOME and XDG_CONFIG_HOME to mitigate loading arbitrary configuration. We have tests that use strace to check for access to direct