Re: bug: git submodule add fails when .git is a symlink

2016-04-20 Thread Stefan Beller
On Wed, Apr 20, 2016 at 9:41 AM, Stefan Beller wrote: > On Wed, Mar 2, 2016 at 12:49 AM, Jeff King wrote: >> On Tue, Mar 01, 2016 at 07:17:20PM -0400, Joey Hess wrote: >> >>> Junio C Hamano wrote: >>> > A more pertinent question may be which version of Git did the above >>> > ever work, I guess.

Re: bug: git submodule add fails when .git is a symlink

2016-04-20 Thread Stefan Beller
On Wed, Mar 2, 2016 at 12:49 AM, Jeff King wrote: > On Tue, Mar 01, 2016 at 07:17:20PM -0400, Joey Hess wrote: > >> Junio C Hamano wrote: >> > A more pertinent question may be which version of Git did the above >> > ever work, I guess. We fairly liberally chdir around and I do not >> > think we d

Re: bug: git submodule add fails when .git is a symlink

2016-03-02 Thread Jeff King
On Tue, Mar 01, 2016 at 07:17:20PM -0400, Joey Hess wrote: > Junio C Hamano wrote: > > A more pertinent question may be which version of Git did the above > > ever work, I guess. We fairly liberally chdir around and I do not > > think we deliberately avoid assuming that "cd .git && cd .." might >

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Joey Hess
Junio C Hamano wrote: > A more pertinent question may be which version of Git did the above > ever work, I guess. We fairly liberally chdir around and I do not > think we deliberately avoid assuming that "cd .git && cd .." might > not come back to the original directory, for example, so I wouldn't

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Joey Hess
Stefan Beller wrote: > To elaborate on that: Starting in 2.7 parts of the submodule stuff > has been rewritten in C, in 2.8 even more and there is more in flight for > > 2.8. > > However your bug is also to be found in 2.6, which doesn't contain any > recent rewrites, so it is a rather long stand

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Mar 1, 2016 at 12:42 PM, Joey Hess wrote: >> git init gitdir >> mkdir worktree >> cd worktree >> ln -s ../gitdir/.git .git >> git submodule add /any/git/repo sub >> >> fatal: Could not chdir to '../../../sub': No suc

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Stefan Beller
On Tue, Mar 1, 2016 at 1:39 PM, Stefan Beller wrote: > On Tue, Mar 1, 2016 at 12:42 PM, Joey Hess wrote: >> git init gitdir >> mkdir worktree >> cd worktree >> ln -s ../gitdir/.git .git >> git submodule add /any/git/repo sub >> >> fatal: Could not c

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Stefan Beller
On Tue, Mar 1, 2016 at 12:42 PM, Joey Hess wrote: > git init gitdir > mkdir worktree > cd worktree > ln -s ../gitdir/.git .git > git submodule add /any/git/repo sub > > fatal: Could not chdir to '../../../sub': No such file or directory > > Fairly su

bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Joey Hess
git init gitdir mkdir worktree cd worktree ln -s ../gitdir/.git .git git submodule add /any/git/repo sub fatal: Could not chdir to '../../../sub': No such file or directory Fairly sure this is a bug.. -- see shy jo signature.asc Description: PGP