Re: allow a differn't diff.context config for git format-patch

2019-05-14 Thread Jeff King
On Tue, May 14, 2019 at 05:54:46AM -0400, Jeff King wrote: > On Sun, May 12, 2019 at 07:29:42AM -0500, Shawn Landden wrote: > > > > After init_revisions(), we'll have called diff_setup(), which puts > > > diff_context_default into revs->diffopt. So we still have to do the "if > > > we have a form

Re: allow a differn't diff.context config for git format-patch

2019-05-14 Thread Jeff King
On Sun, May 12, 2019 at 07:29:42AM -0500, Shawn Landden wrote: > > After init_revisions(), we'll have called diff_setup(), which puts > > diff_context_default into revs->diffopt. So we still have to do the "if > > we have a format-specific value, then override..." conditional. But we > > can do it

Re: allow a differn't diff.context config for git format-patch

2019-05-12 Thread Shawn Landden
On Mon, Apr 22, 2019 at 10:55 PM Jeff King wrote: > > On Tue, Apr 23, 2019 at 12:45:17PM +0900, Junio C Hamano wrote: > > > Jeff King writes: > > > > > ... I don't think it would be > > > too big a problem for format-patch to learn some options to configure > > > its diffs. We already have some o

Re: allow a differn't diff.context config for git format-patch

2019-04-22 Thread Jeff King
On Tue, Apr 23, 2019 at 12:45:17PM +0900, Junio C Hamano wrote: > Jeff King writes: > > > ... I don't think it would be > > too big a problem for format-patch to learn some options to configure > > its diffs. We already have some options in format.* for various things. > > I am not sure; diff.c

Re: allow a differn't diff.context config for git format-patch

2019-04-22 Thread Junio C Hamano
Jeff King writes: > ... I don't think it would be > too big a problem for format-patch to learn some options to configure > its diffs. We already have some options in format.* for various things. I am not sure; diff.context is rather special in that the variable behind it belongs to the diff lay

Re: allow a differn't diff.context config for git format-patch

2019-04-22 Thread Jeff King
On Sun, Apr 14, 2019 at 04:48:53PM -0500, Shawn Landden wrote: > When I send patches I want them to have lots of context, but when just > looking at a diff, I can always open the file for context. Seems like a reasonable thing to want. You can already use "git format-patch -U20 ...". The usual ad

allow a differn't diff.context config for git format-patch

2019-04-14 Thread Shawn Landden
When I send patches I want them to have lots of context, but when just looking at a diff, I can always open the file for context. -SHawn