Re: Worktree creation race

2019-02-01 Thread Eric Sunshine
On Fri, Feb 1, 2019 at 8:17 AM Duy Nguyen wrote: > I'm not going to bother you with code yet (although if you want, you > can check out branch worktree-name on my gitlab repo), but this is > what the user facing changes look like. Looking good? > > -- 8< -- > diff --git a/Documentation/git-worktre

Re: Worktree creation race

2019-02-01 Thread Junio C Hamano
Eric Sunshine writes: > Another possibility would be to skip the stat() and instead do the > mkdir() in a loop, incrementing the sequence number each time through > the loop. That should eliminate the race entirely (I think). Yeah, I think that is the only sensible option to rely on the atomicit

Re: Worktree creation race

2019-02-01 Thread Duy Nguyen
On Fri, Feb 01, 2019 at 02:06:43PM +0700, Duy Nguyen wrote: > worrying about races like this. The mkdir loop would be one way to go. > But I'm going to add a new option to let the user control this > directory name. This is necessary since this name is now exposed via > "worktrees/" reference space

Re: Worktree creation race

2019-01-31 Thread Duy Nguyen
Thanks for including me. Apparently I did miss some emails :) On Fri, Feb 1, 2019 at 1:27 PM Eric Sunshine wrote: > > On Mon, Jan 28, 2019 at 7:58 AM Marketa Calabkova wrote: > > On 15/01/2019 15:03, Marketa Calabkova wrote: > > > I am writing to report a bug. The original report is from my coll

Re: Worktree creation race

2019-01-31 Thread Eric Sunshine
On Mon, Jan 28, 2019 at 7:58 AM Marketa Calabkova wrote: > On 15/01/2019 15:03, Marketa Calabkova wrote: > > I am writing to report a bug. The original report is from my colleague, I > > am also providing his suggestions. > > > > There is insufficient locking for worktree addition. Adding worktre

Re: Worktree creation race

2019-01-28 Thread Marketa Calabkova
Hi, you have probably overseen my email :) . Please, I would like to get it fixed. Does anyone has a suggestion what to do with this bug? It looks like a one-line fix probably in builtin/worktree.c, but I have no idea how to do it. Sorry. Thank you, Marketa On 15/01/2019 15:03, Marketa Calabkov

Worktree creation race

2019-01-15 Thread Marketa Calabkova
Hello, I am writing to report a bug. The original report is from my colleague, I am also providing his suggestions. There is insufficient locking for worktree addition. Adding worktree may fail. The problem is that git reads the directory entries in $GIT_DIR/worktrees, finds a worktree name th