Re: Strangeness with git-add and nested repositories

2016-04-28 Thread Junio C Hamano
Junio C Hamano writes: > A cursory bisection suggests that this used to work up to at least > v2.7.4; this must be a recent regression. No, false report. This seems to be broken from ages ago. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord..

Re: Strangeness with git-add and nested repositories

2016-04-28 Thread Junio C Hamano
Junio C Hamano writes: > My undertanding of what _should_ happen in the world order as > currently defined (not necessarily implemented) is: > > * "git add -- A B" must work the same way as "git add -- B A" and >"git add -- A; git add -- B" > > * "git add -- path/to/subdir/file", when any o

Re: Strangeness with git-add and nested repositories

2016-04-28 Thread Andrew J
On Thu, Apr 28, 2016 at 9:48 AM, Junio C Hamano wrote: > Junio C Hamano writes: > When given multiple paths, e.g. "git add A/B/C A/D", it tries to > "optimize" things by first finding common leading directory (in this > case "A/") and doing something slightly different, and I think the > bug Andr

Re: Strangeness with git-add and nested repositories

2016-04-28 Thread Stefan Beller
On Thu, Apr 28, 2016 at 9:39 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> I think (pure speculation), that it the error is in the context >> (repository) switching logic. >> What happens if you alter the order, i.e. give testfile first and then >> the files in the nested >> repos? >> >>

Re: Strangeness with git-add and nested repositories

2016-04-28 Thread Junio C Hamano
Junio C Hamano writes: > * "git add -- path/to/subdir/file", when any of path/, path/to/, >path/to/subdir/ is a Git repository that is different from the >current Git repository, must fail. If any of the leading directories in that long path is actually a git repository that is differen

Re: Strangeness with git-add and nested repositories

2016-04-28 Thread Junio C Hamano
Stefan Beller writes: > I think (pure speculation), that it the error is in the context > (repository) switching logic. > What happens if you alter the order, i.e. give testfile first and then > the files in the nested > repos? > > git add -- file path/to/subdir/file > > should do internally

Re: Strangeness with git-add and nested repositories

2016-04-28 Thread Stefan Beller
On Wed, Apr 27, 2016 at 11:10 PM, Andrew J wrote: > Hi Stefan, > > On Wed, Apr 27, 2016 at 9:08 AM, Stefan Beller wrote: >> I think (pure speculation), that it the error is in the context >> (repository) switching logic. >> What happens if you alter the order, i.e. give testfile first and then >>

Re: Strangeness with git-add and nested repositories

2016-04-27 Thread Andrew J
Hi Stefan, On Wed, Apr 27, 2016 at 9:08 AM, Stefan Beller wrote: > I think (pure speculation), that it the error is in the context > (repository) switching logic. > What happens if you alter the order, i.e. give testfile first and then > the files in the nested > repos? Interestingly, reversing

Re: Strangeness with git-add and nested repositories

2016-04-27 Thread Stefan Beller
On Wed, Apr 27, 2016 at 1:31 AM, Andrew J wrote: > I've noticed some strangeness with git-add and nested repos. > > This tar.gz has a reproduction script, parent repo, and nested repo > that exhibits the issue: > https://drive.google.com/uc?export=download&id=0Bwjufq6oAZMfcGVxZ2dlMElEVlE > > If yo

Strangeness with git-add and nested repositories

2016-04-27 Thread Andrew J
I've noticed some strangeness with git-add and nested repos. This tar.gz has a reproduction script, parent repo, and nested repo that exhibits the issue: https://drive.google.com/uc?export=download&id=0Bwjufq6oAZMfcGVxZ2dlMElEVlE If you extract the archive and do the following (on linux please, I