René Scharfe writes:
> Sure, but we'd need to move the code to handle the raw format as well, no?
> Perhaps like this? It depends on callers of parse_revision_opt() calling
> setup_revisions() before using decorations. And it may have other side
> effects; I'm not comfortable with this change.
Am 02.08.19 um 23:20 schrieb Junio C Hamano:
> René Scharfe writes:
>
>> Having cmd_log_init_finish() call load_ref_decorations() before
>> setup_revisions() would indeed solve the issue as well. But we need
>> to call the latter to check if --pretty=raw was given and avoid loading
>> decorations
On Fri, Aug 02, 2019 at 02:20:31PM -0700, Junio C Hamano wrote:
> > This would require that higher level to parse the user format to check
> > if %d or %D is present before formatting the first item. Hmm.
>
> Yes. Don't we pre-scan what kind of formatting primitives are used
> in the end-user s
René Scharfe writes:
> Having cmd_log_init_finish() call load_ref_decorations() before
> setup_revisions() would indeed solve the issue as well. But we need
> to call the latter to check if --pretty=raw was given and avoid loading
> decorations in that case, don't we?
I was thinking about givin
Am 02.08.19 um 21:14 schrieb Junio C Hamano:
> I can see how this would help, but it somehow feels a bit brittle
> to rely on where the decorations get loaded.
Right.
> I wonder if it would help to move the ability to handle decoration
> filter down from the log layer to revisions.c API layer.
>
René Scharfe writes:
> Am 02.08.19 um 10:47 schrieb Étienne SERVAIS:
>> Thus, when I enter
>>
>> ```
>> git log --oneline --graph --decorate=full
>> --decorate-refs-exclude='refs/tags/'
>> ```
>> The selected tags are properly excluded but once I add the
>> `simplify-by-decoration` option
>>
>>
Am 02.08.19 um 10:47 schrieb Étienne SERVAIS:
> Thus, when I enter
>
> ```
> git log --oneline --graph --decorate=full
> --decorate-refs-exclude='refs/tags/'
> ```
> The selected tags are properly excluded but once I add the
> `simplify-by-decoration` option
>
> ```
> git log --oneline --graph -
Hi there,
I've asked this question yesterday on stackoverflow:
https://stackoverflow.com/q/57305719/2622010
And have been confirmed it does look like a bug.
Unfortunately I'm unable to update to latest git revision but a search through
the release notes didn't show anything related to this prob
8 matches
Mail list logo
