Re: Segfault in master due to 4fbcca4eff

2018-09-21 Thread Ævar Arnfjörð Bjarmason
On Fri, Sep 21 2018, Jeff King wrote: > On Sat, Sep 22, 2018 at 01:37:17AM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > Thanks, both of you ;-). I was aware of the issue and proposed fix >> > but forgot about it when merging things down to 'master'. Sorry >> > about that. >> >> Just a follow-

Re: Segfault in master due to 4fbcca4eff

2018-09-21 Thread Jeff King
On Sat, Sep 22, 2018 at 01:37:17AM +0200, Ævar Arnfjörð Bjarmason wrote: > > Thanks, both of you ;-). I was aware of the issue and proposed fix > > but forgot about it when merging things down to 'master'. Sorry > > about that. > > Just a follow-up question, in your merge commit you just pushed

Re: Segfault in master due to 4fbcca4eff

2018-09-21 Thread Ævar Arnfjörð Bjarmason
On Fri, Sep 21 2018, Junio C Hamano wrote: > Derrick Stolee writes: > >> On 9/21/2018 10:40 AM, Ævar Arnfjörð Bjarmason wrote: >>> On Fri, Sep 21 2018, Derrick Stolee wrote: >>> This error was reported by Peff [1] and fixed in [2], but as stated [3] I was waiting for more review

Re: Segfault in master due to 4fbcca4eff

2018-09-21 Thread Junio C Hamano
Derrick Stolee writes: > On 9/21/2018 10:40 AM, Ævar Arnfjörð Bjarmason wrote: >> On Fri, Sep 21 2018, Derrick Stolee wrote: >> >>> >>> This error was reported by Peff [1] and fixed in [2], but as stated >>> [3] I was waiting for more review before sending a v3. I'll send that >>> v3 shortly, res

Re: Segfault in master due to 4fbcca4eff

2018-09-21 Thread Derrick Stolee
On 9/21/2018 10:40 AM, Ævar Arnfjörð Bjarmason wrote: On Fri, Sep 21 2018, Derrick Stolee wrote: This error was reported by Peff [1] and fixed in [2], but as stated [3] I was waiting for more review before sending a v3. I'll send that v3 shortly, responding to the feedback so far. -Stolee [1

Re: Segfault in master due to 4fbcca4eff

2018-09-21 Thread Ævar Arnfjörð Bjarmason
On Fri, Sep 21 2018, Derrick Stolee wrote: > On 9/21/2018 10:30 AM, Ævar Arnfjörð Bjarmason wrote: >> On Fri, Sep 21 2018, Junio C Hamano wrote: >> >>> * ds/reachable (2018-08-28) 19 commits >>>(merged to 'next' on 2018-08-28 at b1634b371d) >>> + commit-reach: correct accidental #include o

Re: Segfault in master due to 4fbcca4eff

2018-09-21 Thread Derrick Stolee
On 9/21/2018 10:30 AM, Ævar Arnfjörð Bjarmason wrote: On Fri, Sep 21 2018, Junio C Hamano wrote: * ds/reachable (2018-08-28) 19 commits (merged to 'next' on 2018-08-28 at b1634b371d) + commit-reach: correct accidental #include of C file (merged to 'next' on 2018-08-22 at 17f3275afb) +

Segfault in master due to 4fbcca4eff

2018-09-21 Thread Ævar Arnfjörð Bjarmason
On Fri, Sep 21 2018, Junio C Hamano wrote: > * ds/reachable (2018-08-28) 19 commits > (merged to 'next' on 2018-08-28 at b1634b371d) > + commit-reach: correct accidental #include of C file > (merged to 'next' on 2018-08-22 at 17f3275afb) > + commit-reach: use can_all_from_reach > + commit