Re: Referring to commits in commit messages

2018-12-23 Thread Jacob Keller
On Wed, Dec 19, 2018 at 2:36 PM Jonathan Nieder wrote: > In Linux kernel land, Documentation/process/submitting-patches.rst > contains the following: > > -- >8 -- > If your patch fixes a bug in a specific commit, e.g. you found an issue using > ``git bisect``, please use the 'Fixes:' tag with the

Re: Referring to commits in commit messages

2018-12-19 Thread Jeff King
On Wed, Dec 19, 2018 at 03:29:48PM -0800, Jonathan Nieder wrote: > > I'm also not sure it really matters all that much either way. If you buy > > my argument that this is just about placing the general era of the > > commit in the mind of the reader, then "just before v2.11" or "just > > after v2.

Re: Referring to commits in commit messages

2018-12-19 Thread Ævar Arnfjörð Bjarmason
On Wed, Dec 19 2018, Jonathan Nieder wrote: > Hi, > > Duy Nguyen wrote: >> On Wed, Dec 19, 2018 at 6:04 PM Ævar Arnfjörð Bjarmason > >>> E.g. when composing >>> https://public-inbox.org/git/878t0lfwrj@evledraar.gmail.com/ I >>> remembered PERLLIB_EXTRA went back & forth between >>> working/b

Re: Referring to commits in commit messages

2018-12-19 Thread Jonathan Nieder
Jeff King wrote: > On Wed, Dec 19, 2018 at 10:39:27AM -0800, Jonathan Nieder wrote: >> Is there some rule about how long the hex string has to be for this to >> work? > > In both cases, it has to be 7 characters. Thanks. [...] >> The issue with this is that it is ambiguous about what the tag nam

Re: Referring to commits in commit messages

2018-12-19 Thread Jeff King
On Wed, Dec 19, 2018 at 10:39:27AM -0800, Jonathan Nieder wrote: > Jeff King wrote: > > > - web interfaces like GitHub won't linkify this type of reference > > (whereas they will for something that looks like a hex object id) > > > > - my terminal makes it easy to select hex strings, but

Re: Referring to commits in commit messages

2018-12-19 Thread Jonathan Nieder
Hi, Duy Nguyen wrote: > On Wed, Dec 19, 2018 at 6:04 PM Ævar Arnfjörð Bjarmason >> E.g. when composing >> https://public-inbox.org/git/878t0lfwrj@evledraar.gmail.com/ I >> remembered PERLLIB_EXTRA went back & forth between >> working/breaking/working with your/my/your patch, so: >> >> git

Re: Referring to commits in commit messages

2018-12-19 Thread Ævar Arnfjörð Bjarmason
On Wed, Dec 19 2018, Jeff King wrote: > On Wed, Dec 19, 2018 at 03:02:14PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> On Mon, Dec 17 2018, Jonathan Nieder wrote: >> >> > v2.11.0-rc3~3^2~1 (stripspace: respect repository config, 2016-11-21) >> >> Minor nit not just on this patch, but your patches

Re: Referring to commits in commit messages

2018-12-19 Thread Jonathan Nieder
Hi, Jeff King wrote: > - web interfaces like GitHub won't linkify this type of reference > (whereas they will for something that looks like a hex object id) > > - my terminal makes it easy to select hex strings, but doesn't > understand this git-describe output :) > > These tools _cou

Re: Referring to commits in commit messages

2018-12-19 Thread Jeff King
On Wed, Dec 19, 2018 at 03:02:14PM +0100, Ævar Arnfjörð Bjarmason wrote: > On Mon, Dec 17 2018, Jonathan Nieder wrote: > > > v2.11.0-rc3~3^2~1 (stripspace: respect repository config, 2016-11-21) > > Minor nit not just on this patch, but your patches in general: I think > you're the only one usin

Re: Referring to commits in commit messages

2018-12-19 Thread SZEDER Gábor
On Wed, Dec 19, 2018 at 03:02:14PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Dec 17 2018, Jonathan Nieder wrote: > > > v2.11.0-rc3~3^2~1 (stripspace: respect repository config, 2016-11-21) > > Minor nit not just on this patch, but your patches in general: I think > you're the only one us

Re: Referring to commits in commit messages

2018-12-19 Thread Duy Nguyen
On Wed, Dec 19, 2018 at 6:04 PM Ævar Arnfjörð Bjarmason wrote: > > > On Mon, Dec 17 2018, Jonathan Nieder wrote: > > > v2.11.0-rc3~3^2~1 (stripspace: respect repository config, 2016-11-21) > > Minor nit not just on this patch, but your patches in general: I think > you're the only one using this t

Referring to commits in commit messages

2018-12-19 Thread Ævar Arnfjörð Bjarmason
On Mon, Dec 17 2018, Jonathan Nieder wrote: > v2.11.0-rc3~3^2~1 (stripspace: respect repository config, 2016-11-21) Minor nit not just on this patch, but your patches in general: I think you're the only one using this type of template instead of the `%h ("%s", %ad)` format documented in Submitt