Re: [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees

2019-09-06 Thread Derrick Stolee
On 9/4/2019 5:21 PM, Taylor Blau wrote: > Hi Garima, > > On Wed, Sep 04, 2019 at 02:25:55PM -0400, Garima Singh wrote: >> >> On 9/3/2019 10:22 PM, Taylor Blau wrote: >>> Hi, >>> >>> I was running some of the new 'git commit-graph' commands, and noticed >>> that I could consistently get 'git commit

Re: [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees

2019-09-04 Thread Jeff King
On Wed, Sep 04, 2019 at 05:21:21PM -0400, Taylor Blau wrote: > > I like the idea of completely bailing if the commit can't be parsed too. > > Only question: Is there a reason you chose to die() instead of BUG() like > > the other two places in that function? What is the criteria of choosing one >

Re: [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees

2019-09-04 Thread Taylor Blau
Hi Garima, On Wed, Sep 04, 2019 at 02:25:55PM -0400, Garima Singh wrote: > > On 9/3/2019 10:22 PM, Taylor Blau wrote: > > Hi, > > > > I was running some of the new 'git commit-graph' commands, and noticed > > that I could consistently get 'git commit-graph write --reachable' to > > segfault when a

Re: [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees

2019-09-04 Thread Garima Singh
On 9/3/2019 10:22 PM, Taylor Blau wrote: Hi, I was running some of the new 'git commit-graph' commands, and noticed that I could consistently get 'git commit-graph write --reachable' to segfault when a commit's root tree is corrupt. I have an extremely-unfinished fix attached as an RFC PATCH