Re: [PATCH v3 1/3] factor out refresh_and_write_cache function

2019-09-12 Thread Junio C Hamano
Thomas Gummerer writes: > On 09/11, Johannes Schindelin wrote: >> Hi Thomas, >> >> On Fri, 6 Sep 2019, Thomas Gummerer wrote: >> > Oops, I didn't realize there was another series in flight that also >> > introduces 'repo_refresh_and_write_index'. Probably should have done >> > a test merge of t

Re: [PATCH v3 1/3] factor out refresh_and_write_cache function

2019-09-11 Thread Thomas Gummerer
On 09/11, Johannes Schindelin wrote: > Hi Thomas, > > On Fri, 6 Sep 2019, Thomas Gummerer wrote: > > Oops, I didn't realize there was another series in flight that also > > introduces 'repo_refresh_and_write_index'. Probably should have done > > a test merge of this with pu. > > Yep, our patches

Re: [PATCH v3 1/3] factor out refresh_and_write_cache function

2019-09-11 Thread Johannes Schindelin
Hi Thomas, On Fri, 6 Sep 2019, Thomas Gummerer wrote: > On 09/05, Junio C Hamano wrote: > > Thomas Gummerer writes: > > > > > Getting the lock for the index, refreshing it and then writing it is a > > > pattern that happens more than once throughout the codebase, and isn't > > > trivial to get r

Re: [PATCH v3 1/3] factor out refresh_and_write_cache function

2019-09-06 Thread Thomas Gummerer
On 09/05, Junio C Hamano wrote: > Thomas Gummerer writes: > > > Getting the lock for the index, refreshing it and then writing it is a > > pattern that happens more than once throughout the codebase, and isn't > > trivial to get right. Factor out the refresh_and_write_cache function > > from bui

Re: [PATCH v3 1/3] factor out refresh_and_write_cache function

2019-09-05 Thread Junio C Hamano
Thomas Gummerer writes: > Getting the lock for the index, refreshing it and then writing it is a > pattern that happens more than once throughout the codebase, and isn't > trivial to get right. Factor out the refresh_and_write_cache function > from builtin/am.c to read-cache.c, so it can be re-u