Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget

2019-10-17 Thread Pratyush Yadav
On 17/10/19 07:08AM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > On Wed, Oct 16, 2019 at 9:28 PM Pratyush Yadav wrote: > > I mentioned this earlier, and I'll mention this again: I'm not sure > > whether this feature would be a good thing for the larger population. So > > this _might_ not en

Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget

2019-10-16 Thread Birger Skogeng Pedersen
Hi Johannes, On Thu, Oct 17, 2019 at 7:33 AM Johannes Sixt wrote: > FWIW, I would prefer to experiment with the feature for a few weeks > before it (or a configuration that enables it by default) is baked in. Yes please do. Obviously I'm glad someone other than me will be actually testing it. (A

Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget

2019-10-16 Thread Johannes Sixt
Am 17.10.19 um 07:08 schrieb Birger Skogeng Pedersen: > Hi Pratyush, > > On Wed, Oct 16, 2019 at 9:28 PM Pratyush Yadav wrote: >> I mentioned this earlier, and I'll mention this again: I'm not sure >> whether this feature would be a good thing for the larger population. So >> this _might_ not end

Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget

2019-10-16 Thread Birger Skogeng Pedersen
Hi Pratyush, On Wed, Oct 16, 2019 at 9:28 PM Pratyush Yadav wrote: > I mentioned this earlier, and I'll mention this again: I'm not sure > whether this feature would be a good thing for the larger population. So > this _might_ not end up being accepted depending on how people react to > the propo

Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget

2019-10-16 Thread Pratyush Yadav
On 15/10/19 12:51PM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > Thanks for reviewing. How does this work, do I send a re-roll of the > patch(es)? Yes, please do. I mentioned this earlier, and I'll mention this again: I'm not sure whether this feature would be a good thing for the larger

Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget

2019-10-15 Thread Birger Skogeng Pedersen
Hi Pratyush, Thanks for reviewing. How does this work, do I send a re-roll of the patch(es)? Birger

Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget

2019-10-13 Thread Pratyush Yadav
Hi Birger, Your subject is a bit redundant. A reader of this commit can easily see the diff and know that you implemented "proc select_path_in_widget". What's more important is why you implemented it. That is what should go in the commit message. So for example in this patch, you can say somet