On Tue, Sep 3, 2019 at 4:22 PM Pratyush Yadav wrote:
>
> On 02/09/19 09:42PM, Bert Wesarg wrote:
> > On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen
> > wrote:
> > >
> > > The user cannot change focus between the list of files, the diff view and
> > > the commit message widgets without usi
On 02/09/19 09:42PM, Bert Wesarg wrote:
> On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen
> wrote:
> >
> > The user cannot change focus between the list of files, the diff view and
> > the commit message widgets without using the mouse (clicking either of
> > the four widgets).
> >
> > With
Hi Bert,
On Mon, Sep 2, 2019 at 9:42 PM Bert Wesarg wrote:
> So we only remember the lno in the widget, that could mean, that we
> select the wrong file after a rescan, which shifted the previous path
> one down. Can we remember the pathname instead, and try to find this
> again in the file list
On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen
wrote:
>
> The user cannot change focus between the list of files, the diff view and
> the commit message widgets without using the mouse (clicking either of
> the four widgets).
>
> With this patch, the user may set ui focus to the previously
Ah, sorry I misunderstood you.
Thanks,
Birger
On 02/09/19 08:35PM, Birger Skogeng Pedersen wrote:
> On Mon, Sep 2, 2019 at 8:19 PM Pratyush Yadav wrote:
> > You missed removing this extra blank line. Will fix it up locally.
> >
> > > + set _index $file_lists_last_clicked($widget)
> > [snip]
>
>
> To be honest I felt the blank li
On Mon, Sep 2, 2019 at 8:19 PM Pratyush Yadav wrote:
> You missed removing this extra blank line. Will fix it up locally.
>
> > + set _index $file_lists_last_clicked($widget)
> [snip]
To be honest I felt the blank line there was appropriate, in an
attempt to follow the same code styl
Hi Birger,
Other than a minor change that I can do locally, this looks good. I'll
test it a bit and then merge it. Thanks.
On 01/09/19 09:36PM, Birger Skogeng Pedersen wrote:
[snip]
> +proc select_path_in {widget} {
> + global file_lists last_clicked selected_paths ui_workdir
> + global
8 matches
Mail list logo
