Re: Date handling.

2005-04-14 Thread Paul Jackson
> I'd think the 8:00am-before-the-first-coffee checkins would be the > most worrying :-) For me, it was the Friday evening after beer bust checkin. But my employer can't afford those anymore, so I'm safe. -- I won't rest till it's the best ... Programmer, Lin

Re: Date handling.

2005-04-14 Thread David Woodhouse
On Thu, 2005-04-14 at 14:01 -0700, H. Peter Anvin wrote: > Both of these are metadata; they may not be directly relevant to the > filesystem, but are attributes relevant to the client thereof; > effectively an xattr. Right. That's perfectly acceptable -- and that's the reason why I think it's al

Re: Date handling.

2005-04-14 Thread H. Peter Anvin
David Woodhouse wrote: On Thu, 2005-04-14 at 12:42 -0700, Luck, Tony wrote: This is a very good point ... but this still has problems with the "git is a filesystem, not a SCM" mantra. Timezone comments don't belong in the git inode. Yeah, but really I'd want to see other serious users of it before

RE: Date handling.

2005-04-14 Thread David Woodhouse
On Thu, 2005-04-14 at 12:42 -0700, Luck, Tony wrote: > This is a very good point ... but this still has problems with the > "git is a filesystem, not a SCM" mantra. Timezone comments don't > belong in the git inode. Yeah, but really I'd want to see other serious users of it before I'd accept that

Re: RE: Date handling.

2005-04-14 Thread Petr Baudis
Dear diary, on Thu, Apr 14, 2005 at 09:42:28PM CEST, I got a letter where "Luck, Tony" <[EMAIL PROTECTED]> told me that... > >I'd prefer not to lose the information. If someone has committed a > >change at 2am, I like to know that it was 2am for _them_. It helps me > >decide where to look first for

RE: Date handling.

2005-04-14 Thread Luck, Tony
>I'd prefer not to lose the information. If someone has committed a >change at 2am, I like to know that it was 2am for _them_. It helps me >decide where to look first for the cause of problems. :) I'd think the 8:00am-before-the-first-coffee checkins would be the most worrying :-) >It also helps

Re: Date handling.

2005-04-14 Thread David Woodhouse
On Thu, 2005-04-14 at 12:19 -0700, [EMAIL PROTECTED] wrote: > With a UTC date, why would anyone care in which timezone the commit was > made? Any pretty printing would most likely be prettiest if it is done > relative to the timezone of the person looking at the commit record, not > the person who

Re: Date handling.

2005-04-14 Thread tony . luck
> OK. commit-tree now eats RFC2822 dates as AUTHOR_DATE because that's > what you're going to want to feed it. We store seconds since UTC epoch, > we add the author's or committer's timezone as auxiliary data so that > dates can be pretty-printed in the original timezone later if anyone > cares. W

Re: Date handling.

2005-04-14 Thread David Woodhouse
On Thu, 2005-04-14 at 02:12 -0700, Linus Torvalds wrote: > I take that back. I'd be much happier with you doing and testing it, > because now I'm crashing. OK. commit-tree now eats RFC2822 dates as AUTHOR_DATE because that's what you're going to want to feed it. We store seconds since UTC epoch,

Re: Date handling.

2005-04-14 Thread David Woodhouse
On Thu, 2005-04-14 at 02:00 -0700, Linus Torvalds wrote: > I do like text output, but if it is painful, the "unix seconds" format is > certainly a hell of a lot simpler. And quite frankly, if we change it, we > might as well just change it all the way. So I'd almost prefer (1). Text _output_ is

Re: Date handling.

2005-04-14 Thread Linus Torvalds
On Thu, 14 Apr 2005, Linus Torvalds wrote: > > Yeah, I think this is the right thing to do. I can change "commit" to do > it. I take that back. I'd be much happier with you doing and testing it, because now I'm crashing. Linus - To unsubscribe from this list: send the line "u

Re: Date handling.

2005-04-14 Thread Linus Torvalds
On Thu, 14 Apr 2005, David Woodhouse wrote: > > I see two possible solutions: > 1. Just store seconds-since-GMT-epoch and if we really want, the > timezone as auxiliary information. Yeah, I think this is the right thing to do. I can change "commit" to do it. I used to think tha