Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-07 Thread Jørgen Edelbo
On 06-09-2013 23:49, Phil Hord wrote: Can you think of a sane way to separate the "from" and the "to" branches in the GUI? I mean, I would like to push "HEAD" and I would like it to go to "refs/for/frotz-2.0". My first attemt at this change was to do do exactly that: always push HEAD, and bei

Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-06 Thread Phil Hord
On Fri, Sep 6, 2013 at 6:30 AM, Joergen Edelbo wrote: > Problem: It is not possible to push for Gerrit review as you will > always try to push to "refs/heads/..." on the remote. > > Changes done: > > Add an option to select "Gerrit review" and a corresponding entry > for a branch name. If this opt

RE: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-06 Thread Jørgen Edelbo
Junio C Hamano < gits...@pobox.com> writes: > Isn't the right way to improve the situation to let the command line tools > know how the user wants to push things out and just have Git-GUI delegate > the choice to the underlying "git push"? Thank you for all the constructive feedback. I realize th

Re: RE: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-05 Thread Heiko Voigt
On Thu, Sep 05, 2013 at 09:18:25AM +, Jørgen Edelbo wrote: > > -Original Message- > > From: Johannes Sixt [mailto:j.s...@viscovery.net] > > Sent: 5. september 2013 10:57 > > > > Please do not top-post. > > > > Am 9/5/2013 10:29, schrieb Jørgen Edelbo: > > > -Original Message-

Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-05 Thread Junio C Hamano
Joergen Edelbo writes: > +proc get_remote_branch {} { > + global push_branchtype push_branch push_new > + set branch {} > + switch -- $push_branchtype { > + existing { set branch $push_branch } > + create { set branch $push_new } > + } > + return $branch > +} > + > +pr

Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-05 Thread Junio C Hamano
Jørgen Edelbo writes: >> You say I can only push HEAD. I understand this that I have to stop work on C >> (perhaps commit or stash any unfinished work), then checkout A, push it, >> checkout B, push it, checkout C and unstash the unfinished work. If my >> understanding is correct, the new restric

Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-05 Thread Johannes Sixt
Am 9/5/2013 11:18, schrieb Jørgen Edelbo: > Forgetting to push something that you have just > completed is very far from what I am used to. "Forgetting to push" is just one of many reasons why a branch that is not equal to HEAD is not yet pushed... The new restriction is just too tight. -- Hanne

RE: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-05 Thread Jørgen Edelbo
> -Original Message- > From: Johannes Sixt [mailto:j.s...@viscovery.net] > Sent: 5. september 2013 10:57 > > Please do not top-post. > > Am 9/5/2013 10:29, schrieb Jørgen Edelbo: > > -Original Message- From: Johannes Sixt > >> Am 9/2/2013 10:54, schrieb Joergen Edelbo: > >>> Chang

Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-05 Thread Johannes Sixt
Please do not top-post. Am 9/5/2013 10:29, schrieb Jørgen Edelbo: > -Original Message- From: Johannes Sixt >> Am 9/2/2013 10:54, schrieb Joergen Edelbo: >>> Changes done: >>> >>> Remove selection of branches to push - push always HEAD. This can be >>> justified by the fact that this far t

RE: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-05 Thread Jørgen Edelbo
delbo -Original Message- From: Johannes Sixt [mailto:j.s...@viscovery.net] Sent: 5. september 2013 08:42 To: Jørgen Edelbo Cc: git@vger.kernel.org; spea...@spearce.org; hvo...@hvoigt.net Subject: Re: [PATCH] git-gui: Modify push dialog to support Gerrit review Am 9/2/2013 10:54, schrieb Jo

Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-04 Thread Johannes Sixt
Am 9/2/2013 10:54, schrieb Joergen Edelbo: > Changes done: > > Remove selection of branches to push - push always HEAD. > This can be justified by the fact that this far the most > common thing to do. What are your plans to support a topic-based workflow? "Far the most common thing to happen" is

Re: [PATCH] git-gui: Modify push dialog to support Gerrit review

2013-09-04 Thread Heiko Voigt
Hi, On Mon, Sep 02, 2013 at 10:54:19AM +0200, Joergen Edelbo wrote: > Problem: It is not possible to push for Gerrit review > as you will always try to push to /refs/heads/... on > the remote. As you should not be forced to work on a > branch with the same name as some branch on the remote, > some