Re: Please review my code

2018-01-26 Thread Оля Тележная
2018-01-26 19:42 GMT+03:00 Christian Couder : > On Fri, Jan 26, 2018 at 11:32 AM, Оля Тележная > wrote: >> 2018-01-25 23:22 GMT+03:00 Christian Couder : >>> On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная >>> wrote: Please look at my code: https://github.com/telezhnaya/git/commits/catfi

Re: Please review my code

2018-01-26 Thread Christian Couder
On Fri, Jan 26, 2018 at 11:32 AM, Оля Тележная wrote: > 2018-01-25 23:22 GMT+03:00 Christian Couder : >> On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная >> wrote: >>> Please look at my code: >>> https://github.com/telezhnaya/git/commits/catfile >>> You could send me any ideas here or in Github. >>

Re: Please review my code

2018-01-26 Thread Оля Тележная
2018-01-25 23:22 GMT+03:00 Christian Couder : > Hi Olga, > > On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная > wrote: >> Hi everyone, >> I haven't sent the code by mailing lists because 25 commits (every >> commit in separate message) look like a spam. > > Yeah, so now that you added tests, it migh

Re: Please review my code

2018-01-25 Thread Christian Couder
Hi Olga, On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная wrote: > Hi everyone, > I haven't sent the code by mailing lists because 25 commits (every > commit in separate message) look like a spam. Yeah, so now that you added tests, it might be interesting to see if the patch series can be refactore

Please review my code

2018-01-25 Thread Оля Тележная
Hi everyone, I haven't sent the code by mailing lists because 25 commits (every commit in separate message) look like a spam. Please look at my code: https://github.com/telezhnaya/git/commits/catfile You could send me any ideas here or in Github. The main idea of the patch is to get rid of using