Re: Minor bug in git branch --set-upstream-to adding superfluous branch section to config

2013-03-29 Thread Junio C Hamano
Phil Haack writes: > Hello there! Please /cc me with responses as I'm not on the mailing list. > > I'm using git version 1.8.1.msysgit.1 and I ran into a very minor issue. It > doesn't actually seem to affect operations, but I thought I'd report it in > case > someone felt it was worth cleaning

Re: Minor bug in git branch --set-upstream-to adding superfluous branch section to config

2013-03-29 Thread Jeff King
On Fri, Mar 29, 2013 at 06:20:28PM +0100, Thomas Rast wrote: > Jeff King writes: > > > I think what happens is that the config editor runs > > through the files linearly, munging whatever lines necessary for the > > requested operation, and leaving everything else untouched (as it must, > > to l

Re: Minor bug in git branch --set-upstream-to adding superfluous branch section to config

2013-03-29 Thread Thomas Rast
Jeff King writes: > I think what happens is that the config editor runs > through the files linearly, munging whatever lines necessary for the > requested operation, and leaving everything else untouched (as it must, > to leave comments and whitespace intact). But it does not keep a > look-behind

Re: Minor bug in git branch --set-upstream-to adding superfluous branch section to config

2013-03-29 Thread Jeff King
On Fri, Mar 29, 2013 at 09:29:14AM -0700, Phil Haack wrote: > If you run the following set of commands: > > git checkout -b some-branch > git push origin some-branch > git branch --set-upstream-to origin/some-branch > git branch --unset-upstream some-branch > git branch --set-

Minor bug in git branch --set-upstream-to adding superfluous branch section to config

2013-03-29 Thread Phil Haack
Hello there! Please /cc me with responses as I'm not on the mailing list. I'm using git version 1.8.1.msysgit.1 and I ran into a very minor issue. It doesn't actually seem to affect operations, but I thought I'd report it in case someone felt it was worth cleaning up. If you run the following set